Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add buffered_metrics object type #853

Merged

Conversation

andrewqian2001datadog
Copy link
Contributor

@andrewqian2001datadog andrewqian2001datadog commented Sep 4, 2024

What does this PR do?

Adds BufferedMetric object to allow for extended aggregation (Distribution, Histogram, Timing metrics)

Based on off existing Go code

Description of the Change

Adds a buffered_metrics.py class that has all the properties that Distribution, Histogram and Timing metrics require

Verification Process

Added unit tests matching the existing tests

Additional Notes

  1. This PR will merge onto a feature branch.

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@andrewqian2001datadog andrewqian2001datadog changed the base branch from master to add-extended-aggregation September 4, 2024 18:58
@andrewqian2001datadog andrewqian2001datadog self-assigned this Sep 4, 2024
@andrewqian2001datadog andrewqian2001datadog marked this pull request as ready for review September 4, 2024 19:15
@andrewqian2001datadog andrewqian2001datadog added the changelog/no-changelog Changes don't appear in changelog label Sep 4, 2024
datadog/dogstatsd/buffered_metrics.py Show resolved Hide resolved
datadog/dogstatsd/buffered_metrics.py Show resolved Hide resolved
datadog/dogstatsd/buffered_metrics.py Show resolved Hide resolved
@andrewqian2001datadog andrewqian2001datadog merged commit c171911 into add-extended-aggregation Sep 10, 2024
9 checks passed
@andrewqian2001datadog andrewqian2001datadog deleted the add_buffered_metric_object branch September 10, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog Changes don't appear in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants