RUM-15877: Add fed2 endpoint to DatadogSite - #542
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #542 +/- ##
=============================================
- Coverage 74.49% 74.42% -0.06%
+ Complexity 291 289 -2
=============================================
Files 40 40
Lines 1172 1173 +1
Branches 139 139
=============================================
Hits 873 873
Misses 233 233
- Partials 66 67 +1
🚀 New features to boost your workflow:
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80ce7f14c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** | ||
| * The US2_FED site (FedRAMP compatible): [fed2.ddog-gov.com](https://fed2.ddog-gov.com). | ||
| */ | ||
| US2_FED("us2.ddog-gov.com"), |
There was a problem hiding this comment.
When users configure the new site through DATADOG_SITE or datadog-ci.json, resolveSite/siteFromDatadogCiConfig call DatadogSite.fromDomain, which only compares against this domain string. The new site is documented here and in the linked SDK change as fed2.ddog-gov.com (https://github.com/DataDog/dd-sdk-android/pull/3383/files#diff-...), but this value is us2.ddog-gov.com, so a user following that domain gets null and silently falls back to US1 instead of uploading to US2_FED. Please either store the fed2 domain here or add it as an accepted alias for fromDomain.
Useful? React with 👍 / 👎.
80ce7f1 to
fa922a2
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa922a2d03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** | ||
| * The US2_FED site (FedRAMP compatible): [us2.ddog-gov.com](https://us2.ddog-gov.com). | ||
| */ | ||
| US2_FED("us2.ddog-gov.com"), |
There was a problem hiding this comment.
Fresh evidence: this revision still sets US2_FED to us2.ddog-gov.com, while the companion Android SDK change for RUM-15877 documents the US2_FED site as fed2.ddog-gov.com. resolveSite/siteFromDatadogCiConfig accept DATADOG_SITE and datadog-ci.json values only through DatadogSite.fromDomain, so customers using the documented fed2.ddog-gov.com value are treated as unknown and fall back to US1 instead of uploading to US2_FED; please accept fed2.ddog-gov.com as the config domain or add it as an alias.
Useful? React with 👍 / 👎.
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
3 participants
What does this PR do?
Similar PR in the SDK DataDog/dd-sdk-android#3383
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)