Skip to content

Improve CI pipeline and image maintenance - #619

Open
kikoveiga wants to merge 1 commit into
developfrom
kikoveiga/remove-woke-ci-cleanup
Open

Improve CI pipeline and image maintenance#619
kikoveiga wants to merge 1 commit into
developfrom
kikoveiga/remove-woke-ci-cleanup

Conversation

@kikoveiga

@kikoveiga kikoveiga commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces the shared static-analysis pipeline with repository-owned Detekt, Ktlint, Android Lint, license, and generated-file checks aligned with dd-sdk-android.
  • Centralizes Ktlint configuration, standardizes source headers, and converts the remaining Groovy build script to Kotlin DSL.
  • Replaces JaCoCo and its flaky per-module coverage threshold with Kover 0.9.8 while preserving module-level Datadog coverage uploads.
  • Streamlines the CI image and build context, embeds the checksum-verified Java tracer, updates Android tooling, and supports architecture-aware Datadog CI installation.
  • Aligns pipeline stage naming and auto-cancels superseded short-lived branch pipelines while protecting stateful jobs.

Validation

  • ./gradlew koverXmlReport :build-config:test :dd-sdk-android-gradle-plugin:checkThirdPartyLicences
  • ./gradlew ktlintCheck :build-config:ktlintCheck detekt --continue
  • ./gradlew checkGeneratedFiles --no-configuration-cache
  • ./gradlew lintRelease --continue
  • ./gradlew :samples:variants:tasks
  • GitLab YAML and diff formatting checks

Notes

  • These are CI and build-tooling changes; no plugin version bump is required.
  • The manual ci-image job must publish and sign image 19.
  • The full image build was not run locally because Docker was unavailable.

@kikoveiga
kikoveiga force-pushed the kikoveiga/remove-woke-ci-cleanup branch 2 times, most recently from b67a8bb to 59f101e Compare September 1, 2026 13:36
@kikoveiga kikoveiga changed the title Remove Woke and streamline the CI image Improve CI pipeline and image maintenance Sep 1, 2026
@kikoveiga
kikoveiga force-pushed the kikoveiga/remove-woke-ci-cleanup branch 4 times, most recently from 33a683a to c8bddf5 Compare September 1, 2026 14:36
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 2, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 62.62% (-14.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2cfab7e | Docs | View more details | Give us feedback!

@kikoveiga
kikoveiga force-pushed the kikoveiga/remove-woke-ci-cleanup branch 4 times, most recently from 79c9948 to f4639eb Compare September 2, 2026 13:34
@kikoveiga
kikoveiga force-pushed the kikoveiga/remove-woke-ci-cleanup branch from f4639eb to 2cfab7e Compare September 2, 2026 13:35
@kikoveiga
kikoveiga marked this pull request as ready for review September 2, 2026 13:35
@kikoveiga
kikoveiga requested review from a team as code owners September 2, 2026 13:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T13:39:18.354429Z 2cfab7e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread ci/Dockerfile.gitlab
@@ -1,56 +1,35 @@
# syntax=docker/dockerfile:1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this line for? we don't have such in dd-sdk-android repo

Comment thread ci/Dockerfile.gitlab
ENV PATH=${PATH}:${ANDROID_HOME}/platform-tools:${ANDROID_SDK_ROOT}/build-tools/${ANDROID_BUILD_TOOLS}:${ANDROID_NDK}

# Install Datadog Java tracer
ENV DD_TRACER_VERSION=1.54.0 \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use the latest version which is 1.65.1? if it doesn't break anything

- analysis
- test
- verify
- test-pyramid

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't really have "test pyramid" notion here, because we have only 2 layers: unit tests + instrumented

but we can keep it

extends: .verification-job
script:
- GRADLE_OPTS="-Xmx2560m" ./gradlew :dd-sdk-android-gradle-plugin:checkThirdPartyLicences --stacktrace --no-daemon
- ./gradlew checkGeneratedFiles --stacktrace --no-daemon --no-configuration-cache

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what breaks configuration cache here?


# TESTS

test:plugin:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that we have the same in Android SDK repo: shouldn't we match task prefix with a stage name? but probably it doesn't matter

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in Groovy on purpose, I guess we need either revert this change or admit that we don't acknowledge plugin usage from Groovy build script and have a single samples/variants flavor which is backed by Kotlin buildscript only (which is samples/variants-kotlin currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants