Improve CI pipeline and image maintenance - #619
Conversation
b67a8bb to
59f101e
Compare
33a683a to
c8bddf5
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: 2cfab7e | Docs | View more details | Give us feedback! |
79c9948 to
f4639eb
Compare
f4639eb to
2cfab7e
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| @@ -1,56 +1,35 @@ | |||
| # syntax=docker/dockerfile:1 | |||
There was a problem hiding this comment.
what is this line for? we don't have such in dd-sdk-android repo
| ENV PATH=${PATH}:${ANDROID_HOME}/platform-tools:${ANDROID_SDK_ROOT}/build-tools/${ANDROID_BUILD_TOOLS}:${ANDROID_NDK} | ||
|
|
||
| # Install Datadog Java tracer | ||
| ENV DD_TRACER_VERSION=1.54.0 \ |
There was a problem hiding this comment.
maybe use the latest version which is 1.65.1? if it doesn't break anything
| - analysis | ||
| - test | ||
| - verify | ||
| - test-pyramid |
There was a problem hiding this comment.
we don't really have "test pyramid" notion here, because we have only 2 layers: unit tests + instrumented
but we can keep it
| extends: .verification-job | ||
| script: | ||
| - GRADLE_OPTS="-Xmx2560m" ./gradlew :dd-sdk-android-gradle-plugin:checkThirdPartyLicences --stacktrace --no-daemon | ||
| - ./gradlew checkGeneratedFiles --stacktrace --no-daemon --no-configuration-cache |
There was a problem hiding this comment.
what breaks configuration cache here?
|
|
||
| # TESTS | ||
|
|
||
| test:plugin: |
There was a problem hiding this comment.
Just noticed that we have the same in Android SDK repo: shouldn't we match task prefix with a stage name? but probably it doesn't matter
There was a problem hiding this comment.
This was in Groovy on purpose, I guess we need either revert this change or admit that we don't acknowledge plugin usage from Groovy build script and have a single samples/variants flavor which is backed by Kotlin buildscript only (which is samples/variants-kotlin currently).
Summary
dd-sdk-android.Validation
./gradlew koverXmlReport :build-config:test :dd-sdk-android-gradle-plugin:checkThirdPartyLicences./gradlew ktlintCheck :build-config:ktlintCheck detekt --continue./gradlew checkGeneratedFiles --no-configuration-cache./gradlew lintRelease --continue./gradlew :samples:variants:tasksNotes
ci-imagejob must publish and sign image19.