Merge release/3.13.0 into develop - #3778
Conversation
Prepare the 3.13.0 release
987df57 to
4dd3878
Compare
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 2 tests - 2 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 4dd3878 | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dd3878e78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }.doWait(timeoutMs = FINAL_WAIT_MS) | ||
|
|
||
| LeakAssertions.assertNoLeaks() | ||
| } |
There was a problem hiding this comment.
Preserve the restored leak assertion
The immediate parent already adds a JobService reference matcher in MockServerActivityTestRule.beforeActivityLaunched() and explicitly re-enables LeakAssertions.assertNoLeaks() for this test, but this change reapplies the older release-branch deletion while retaining that matcher. As a result, this startup scenario once again stops detecting application leaks and can silently regress; keep the restored assertion now that its CI false positive is filtered.
Useful? React with 👍 / 👎.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)