Skip to content

Merge release/3.13.0 into develop - #3778

Merged
jonathanmos merged 8 commits into
developfrom
jmoskovich/merge-3-13-0-into-develop
Aug 26, 2026
Merged

Merge release/3.13.0 into develop#3778
jonathanmos merged 8 commits into
developfrom
jmoskovich/merge-3-13-0-into-develop

Conversation

@jonathanmos

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos
jonathanmos force-pushed the jmoskovich/merge-3-13-0-into-develop branch from 987df57 to 4dd3878 Compare August 26, 2026 13:43
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Aug 26, 2026

Copy link
Copy Markdown

Tests

All CI checks and tests passed. Datadog automation helped this PR pass.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 2 tests - 2 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 70.98% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4dd3878 | Docs | View more details | Give us feedback!

@jonathanmos
jonathanmos marked this pull request as ready for review August 26, 2026 14:03
@jonathanmos
jonathanmos requested review from a team as code owners August 26, 2026 14:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4dd3878e78

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 111 to 112
}.doWait(timeoutMs = FINAL_WAIT_MS)

LeakAssertions.assertNoLeaks()
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the restored leak assertion

The immediate parent already adds a JobService reference matcher in MockServerActivityTestRule.beforeActivityLaunched() and explicitly re-enables LeakAssertions.assertNoLeaks() for this test, but this change reapplies the older release-branch deletion while retaining that matcher. As a result, this startup scenario once again stops detecting application leaks and can silently regress; keep the restored assertion now that its CI false positive is filtered.

Useful? React with 👍 / 👎.

@jonathanmos
jonathanmos merged commit b14ee24 into develop Aug 26, 2026
26 checks passed
@jonathanmos
jonathanmos deleted the jmoskovich/merge-3-13-0-into-develop branch August 26, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants