Skip to content

[IGNORE - Automation test] Merge release/3.13.0 into develop - #3780

Closed
abrooksv wants to merge 7 commits into
developfrom
release-merge-back/3.13.0-into-develop
Closed

[IGNORE - Automation test] Merge release/3.13.0 into develop#3780
abrooksv wants to merge 7 commits into
developfrom
release-merge-back/3.13.0-into-develop

Conversation

@abrooksv

Copy link
Copy Markdown
Contributor

Automated merge-back PR created by CI after release 3.13.0.

⚠️ Unresolved conflicts left in: instrumented/integration/src/androidTest/kotlin/com/datadog/android/sdk/rules/MockServerActivityTestRule.kt — please resolve before merging.

@abrooksv
abrooksv requested review from a team as code owners August 26, 2026 17:42
@abrooksv abrooksv changed the title Merge release/3.13.0 into develop [IGNORE - Automation test] Merge release/3.13.0 into develop Aug 26, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9da2e8a98a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +58 to +62
<<<<<<< HEAD
// This configures some well know cases for Android when memory leaks shouldn't be detected
LeakCanary.config = LeakCanary.config.copy(
referenceMatchers = AndroidReferenceMatchers.appDefaults
||||||| a31a0aa82

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve the committed merge conflict

Resolve these raw conflict markers before merging. Whenever the instrumented:integration Android test sources are compiled, <<<<<<<, |||||||, and >>>>>>> are parsed as Kotlin and compilation fails, preventing the repository's prescribed integration suite from running. Keep the developed branch that adds the JobService matcher and remove all marker/alternate-branch lines.

AGENTS.md reference: AGENTS.md:L37-L45

Useful? React with 👍 / 👎.

Comment on lines 111 to 112
}.doWait(timeoutMs = FINAL_WAIT_MS)

LeakAssertions.assertNoLeaks()
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the leak assertion in the startup test

Restore LeakAssertions.assertNoLeaks() after the event verification. When this startup instrumentation test runs, it now completes without checking for retained activities, undoing the parent branch's explicit fix that added the JobService reference matcher so this test could perform leak detection without the known CI false positive; real leaks introduced in this TTID path will therefore pass unnoticed.

Useful? React with 👍 / 👎.

@abrooksv abrooksv closed this Aug 26, 2026
@abrooksv
abrooksv deleted the release-merge-back/3.13.0-into-develop branch August 26, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants