[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

dudikeleti · 2024-09-27T11:07:01Z

Summary of changes

ProbeProcessor can be inialized from various places and it do a low of work. If the LiveDebugger isn't fully initialized, it useless to create it. This PR verify this.

datadog-ddstaging · 2024-09-27T11:29:17Z

Datadog Report

Branch report: dudik/probeprocessor-guard
Commit report: fffb451
Test service: dd-trace-dotnet

❌ 1 Failed (1 Known Flaky), 459085 Passed, 3572 Skipped, 31h 55m 28.48s Total Time

❌ Failed Tests (1)

WorkingWithContinuousProfiler - Datadog.Trace.Tools.dd_dotnet.ArtifactTests.Checks.ProcessBasicChecksTests - ❄️ Known flaky - Details

Expand for error

 
 Expected string "Runningchecksonprocess7516Processname:Samples.Console----STARTINGTRACERSETUPCHECKS-----Targetprocessisrunningwith.NETFramework1.CheckingModulesNeededsotheTracerLoads:[SUCCESS]:Thenativelibraryversion3.6.0.0isloadedintotheprocess.Error:System.IO.FileNotFoundException:C:\Windows\Microsoft.NET\assembly\GAC_MSIL\Datadog.Trace\v4.0_3.6.0.0__def86d061d0d2eeb\Datadog.Trace.dllatSystem.Diagnostics.FileVersionInfo.GetVersionInfo(String)+0x72atDatadog.Trace.Tools.dd_dotnet.Checks.ProcessBasicCheck.Run(ProcessInfo,IRegistryService)+0x2f7atDatadog.Trace.Tools.dd_dotnet.CheckProcessCommand.<ExecuteAsync>d__2.MoveNext()+0x142---Endofstacktracefrompreviouslocation---atSystem.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()+0x20atSystem.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task)+0xb2atSystem.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task,ConfigureAwaitOptions)+0x4batSystem.CommandLine.Invocation.AnonymousCommandHandler.<InvokeAsync>d__6.MoveNext()+0x1ca---Endofstacktracefrompreviouslocation---.Invocation.AnonymousCommandHandler.<InvokeAsync>d__6.MoveNext () + 0x1ca --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Invocation.AnonymousCommandHandler.SyncUsingAsync(InvocationC ontext) + 0x2b    at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInv ocationChain>b__0>d.MoveNext() + 0x100 --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<< UseParseErrorReporting>b__0>d.MoveNext() + 0xf2 --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<< UseHelp>b__0>d.MoveNext() + 0xbf --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<CancelOnProcessTer mination>b__1_0>d.MoveNext() + 0x14d --- End of stack trace from previous location ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x20    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0xb2    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat ion(Task, ConfigureAwaitOptions) + 0x4b    at System.CommandLine.Invocation.InvocationPipeline.<Invoke>g__FullInvocationChain| 3_0(InvocationContext) + 0x77    at Datadog.Trace.Tools.dd_dotnet.Program.Main(String[] args) + 0x2dc " to contain the strings: {"The tracer version 3.6.0.0 is loaded into the process.", "DD_PROFILING_ENABLED is set.", "The environment variable COR_PROFILER is set to the correct value of {846F5F1C-F9AE-4B07-969E-05C26BC060D8}.", "The environment variable COR_ENABLE_PROFILING is set to the correct value of 1."}.

GreenMatan

LGTM

andrewlock · 2024-11-15T00:05:10Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (72ms)  : 62, 82
     .   : milestone, 72,
    master - mean (72ms)  : 63, 80
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (1,105ms)  : 1087, 1124
     .   : milestone, 1105,
    master - mean (1,112ms)  : 1089, 1134
     .   : milestone, 1112,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (108ms)  : 107, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (769ms)  : 753, 784
     .   : milestone, 769,
    master - mean (769ms)  : 752, 786
     .   : milestone, 769,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (92ms)  : 88, 96
     .   : milestone, 92,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (724ms)  : 709, 739
     .   : milestone, 724,
    master - mean (727ms)  : 711, 743
     .   : milestone, 727,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (191ms)  : 186, 197
     .   : milestone, 191,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (1,213ms)  : 1184, 1242
     .   : milestone, 1213,
    master - mean (1,212ms)  : 1190, 1233
     .   : milestone, 1212,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (276ms)  : 271, 282
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (945ms)  : 929, 961
     .   : milestone, 945,
    master - mean (947ms)  : 928, 967
     .   : milestone, 947,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (266ms)  : 263, 270
     .   : milestone, 266,
    master - mean (265ms)  : 260, 271
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (932ms)  : 913, 951
     .   : milestone, 932,
    master - mean (927ms)  : 909, 946
     .   : milestone, 927,

andrewlock · 2024-11-15T02:01:07Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (10.983M)   : 0, 10982559
    master (10.944M)   : 0, 10944015
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6092) (7.067M)   : 0, 7067272
    master (7.057M)   : 0, 7056507
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.397M)   : 0, 7396993

    section Manual
    master (10.989M)   : 0, 10989408

    section Manual + Automatic
    This PR (6092) (6.609M)   : 0, 6609431
    master (6.497M)   : 0, 6497193

    section DD_TRACE_ENABLED=0
    master (10.120M)   : 0, 10120165

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (9.509M)   : 0, 9508770
    master (9.525M)   : 0, 9525130
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6092) (6.396M)   : 0, 6395688
    master (6.342M)   : 0, 6341726

    section Trace stats
    master (6.735M)   : 0, 6734878

    section Manual
    master (9.691M)   : 0, 9691279

    section Manual + Automatic
    This PR (6092) (5.795M)   : 0, 5795445
    master (6.026M)   : 0, 6026482

    section DD_TRACE_ENABLED=0
    master (8.854M)   : 0, 8853804

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (9.824M)   : 0, 9824188
    master (9.757M)   : 0, 9756807
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6092) (6.381M)   : 0, 6381292
    master (6.431M)   : 0, 6430770
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.942M)   : 0, 6942250

    section Manual
    master (9.619M)   : 0, 9618588

    section Manual + Automatic
    This PR (6092) (5.959M)   : 0, 5958568
    master (5.770M)   : 0, 5770008

    section DD_TRACE_ENABLED=0
    master (8.744M)   : 0, 8743620

andrewlock · 2024-11-15T03:32:57Z

Benchmarks Report for tracer 🐌

Benchmarks for #6092 compared to master:

1 benchmarks are faster, with geometric mean 1.126
1 benchmarks are slower, with geometric mean 1.119
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.25μs	45.5ns	265ns	0.0239	0.00798	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.2μs	55.7ns	315ns	0.0194	0.00971	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	55.5ns	215ns	1.04	0.305	0.0962	6.2 KB
#6092	`StartStopWithChild`	net6.0	8.09μs	46.5ns	354ns	0.0159	0.00796	0	5.61 KB
#6092	`StartStopWithChild`	netcoreapp3.1	10.2μs	46.8ns	219ns	0.0149	0.00498	0	5.8 KB
#6092	`StartStopWithChild`	net472	16.4μs	49ns	190ns	1.05	0.304	0.0986	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	496μs	699ns	2.71μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	650μs	966ns	3.74μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	861μs	858ns	3.32μs	0.428	3.3 KB
#6092	`WriteAndFlushEnrichedTraces`	net6.0	481μs	467ns	1.81μs	0	2.7 KB
#6092	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	659μs	227ns	880ns	0	2.7 KB
#6092	`WriteAndFlushEnrichedTraces`	net472	855μs	554ns	2.07μs	0.428	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	207μs	1.37μs	13.6μs	0.192	18.73 KB
master	`SendRequest`	netcoreapp3.1	229μs	1.38μs	13.8μs	0.224	20.89 KB
master	`SendRequest`	net472	9.25E‑05ns	6.31E‑05ns	0.000236ns	0	0 b
#6092	`SendRequest`	net6.0	199μs	1.14μs	8.2μs	0.202	18.73 KB
#6092	`SendRequest`	netcoreapp3.1	225μs	1.32μs	12.1μs	0.215	20.89 KB
#6092	`SendRequest`	net472	0.000137ns	0.000137ns	0.000511ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	579μs	2.69μs	10.4μs	0.576	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	682μs	3.1μs	12μs	0.357	0	0	41.88 KB
master	`WriteAndFlushEnrichedTraces`	net472	883μs	2.03μs	7.85μs	8.3	2.62	0.437	53.31 KB
#6092	`WriteAndFlushEnrichedTraces`	net6.0	579μs	2.97μs	14.3μs	0.571	0	0	41.58 KB
#6092	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	687μs	3.34μs	13.8μs	0.332	0	0	41.84 KB
#6092	`WriteAndFlushEnrichedTraces`	net472	859μs	3.71μs	14.4μs	8.28	2.48	0.414	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.35μs	0.883ns	3.42ns	0.0141	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.85ns	7.16ns	0.0139	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.07μs	1.46ns	5.26ns	0.157	0.00104	987 B
#6092	`ExecuteNonQuery`	net6.0	1.3μs	1.19ns	4.59ns	0.0143	0	1.02 KB
#6092	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.49ns	5.38ns	0.0134	0	1.02 KB
#6092	`ExecuteNonQuery`	net472	2.09μs	1.37ns	5.14ns	0.156	0.00105	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.21μs	1.1ns	4.12ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.624ns	2.33ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.53μs	2.79ns	10.8ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.27μs	0.836ns	3.13ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	1.2ns	4.5ns	0.0142	1.02 KB
master	`CallElasticsearchAsync`	net472	2.52μs	0.612ns	2.37ns	0.166	1.05 KB
#6092	`CallElasticsearch`	net6.0	1.13μs	0.863ns	3.23ns	0.0136	976 B
#6092	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.956ns	3.58ns	0.0127	976 B
#6092	`CallElasticsearch`	net472	2.48μs	0.841ns	3.15ns	0.157	995 B
#6092	`CallElasticsearchAsync`	net6.0	1.31μs	0.595ns	2.23ns	0.0138	952 B
#6092	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.623ns	2.41ns	0.0138	1.02 KB
#6092	`CallElasticsearchAsync`	net472	2.62μs	0.701ns	2.72ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.3μs	1.62ns	6.05ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.788ns	2.84ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.85μs	0.516ns	2ns	0.145	915 B
#6092	`ExecuteAsync`	net6.0	1.3μs	0.825ns	3.09ns	0.0136	952 B
#6092	`ExecuteAsync`	netcoreapp3.1	1.66μs	0.571ns	2.21ns	0.0124	952 B
#6092	`ExecuteAsync`	net472	1.81μs	0.363ns	1.31ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.52μs	2.91ns	10.9ns	0.0317	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.39μs	2.04ns	7.89ns	0.0377	2.85 KB
master	`SendAsync`	net472	7.38μs	1.14ns	4.1ns	0.493	3.12 KB
#6092	`SendAsync`	net6.0	4.52μs	1.89ns	7.31ns	0.0319	2.31 KB
#6092	`SendAsync`	netcoreapp3.1	5.39μs	1.85ns	6.94ns	0.0377	2.85 KB
#6092	`SendAsync`	net472	7.32μs	2.11ns	8.16ns	0.495	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.46μs	0.767ns	2.87ns	0.0235	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.23μs	0.922ns	3.33ns	0.0224	1.64 KB
master	`EnrichedLog`	net472	2.68μs	2.36ns	9.16ns	0.249	1.57 KB
#6092	`EnrichedLog`	net6.0	1.57μs	0.643ns	2.49ns	0.0235	1.64 KB
#6092	`EnrichedLog`	netcoreapp3.1	2.27μs	0.995ns	3.72ns	0.0216	1.64 KB
#6092	`EnrichedLog`	net472	2.76μs	2.25ns	8.12ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	120μs	195ns	753ns	0.0608	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	124ns	480ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	117ns	451ns	0.678	0.226	4.46 KB
#6092	`EnrichedLog`	net6.0	120μs	118ns	443ns	0.06	0	4.28 KB
#6092	`EnrichedLog`	netcoreapp3.1	125μs	150ns	541ns	0	0	4.28 KB
#6092	`EnrichedLog`	net472	152μs	64.3ns	249ns	0.684	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.18μs	0.827ns	3.2ns	0.0303	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	0.881ns	3.41ns	0.0294	2.2 KB
master	`EnrichedLog`	net472	4.89μs	0.857ns	3.32ns	0.32	2.02 KB
#6092	`EnrichedLog`	net6.0	2.95μs	1.81ns	7ns	0.0313	2.2 KB
#6092	`EnrichedLog`	netcoreapp3.1	4.07μs	1.17ns	4.54ns	0.0285	2.2 KB
#6092	`EnrichedLog`	net472	4.85μs	1.39ns	5.21ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.45μs	0.571ns	2.14ns	0.0159	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.988ns	3.83ns	0.0151	1.14 KB
master	`SendReceive`	net472	2.15μs	4.13ns	16ns	0.183	1.16 KB
#6092	`SendReceive`	net6.0	1.32μs	1.35ns	5.22ns	0.0163	1.14 KB
#6092	`SendReceive`	netcoreapp3.1	1.74μs	1.14ns	4.41ns	0.0158	1.14 KB
#6092	`SendReceive`	net472	2.13μs	1.08ns	4.18ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.77μs	0.916ns	3.55ns	0.0222	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.96μs	1.59ns	6.18ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.28μs	0.877ns	3.16ns	0.324	2.04 KB
#6092	`EnrichedLog`	net6.0	2.68μs	1.02ns	3.95ns	0.0226	1.6 KB
#6092	`EnrichedLog`	netcoreapp3.1	4.09μs	1.11ns	4.16ns	0.0204	1.65 KB
#6092	`EnrichedLog`	net472	4.34μs	0.711ns	2.56ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6092

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.126	628.52	558.36

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	410ns	1.06ns	4.1ns	0.00816	576 B
master	`StartFinishSpan`	netcoreapp3.1	629ns	0.53ns	2.05ns	0.00762	576 B
master	`StartFinishSpan`	net472	731ns	1.77ns	6.85ns	0.0915	578 B
master	`StartFinishScope`	net6.0	489ns	0.578ns	2.24ns	0.00981	696 B
master	`StartFinishScope`	netcoreapp3.1	684ns	2.39ns	9.27ns	0.00943	696 B
master	`StartFinishScope`	net472	896ns	1.22ns	4.72ns	0.104	658 B
#6092	`StartFinishSpan`	net6.0	416ns	0.256ns	0.993ns	0.00808	576 B
#6092	`StartFinishSpan`	netcoreapp3.1	557ns	0.975ns	3.77ns	0.00781	576 B
#6092	`StartFinishSpan`	net472	683ns	0.313ns	1.17ns	0.0917	578 B
#6092	`StartFinishScope`	net6.0	483ns	0.422ns	1.64ns	0.00987	696 B
#6092	`StartFinishScope`	netcoreapp3.1	750ns	0.518ns	1.79ns	0.00937	696 B
#6092	`StartFinishScope`	net472	919ns	1.06ns	4.1ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6092

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.119	603.70	675.44

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	603ns	0.4ns	1.55ns	0.00961	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	903ns	0.558ns	2.16ns	0.00904	696 B
master	`RunOnMethodBegin`	net472	1.12μs	0.744ns	2.78ns	0.104	658 B
#6092	`RunOnMethodBegin`	net6.0	676ns	0.41ns	1.59ns	0.00975	696 B
#6092	`RunOnMethodBegin`	netcoreapp3.1	994ns	0.791ns	3.06ns	0.00943	696 B
#6092	`RunOnMethodBegin`	net472	1.13μs	0.902ns	3.49ns	0.105	658 B

dudikeleti requested a review from a team as a code owner September 27, 2024 11:07

github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Sep 27, 2024

dudikeleti requested a review from GreenMatan October 1, 2024 12:10

GreenMatan approved these changes Nov 11, 2024

View reviewed changes

dudikeleti force-pushed the dudik/probeprocessor-guard branch 8 times, most recently from e623163 to 09789c3 Compare November 14, 2024 18:35

Do not add probe processor when LiveDebugger isn't fully initialized

684cda6

dudikeleti force-pushed the dudik/probeprocessor-guard branch from 09789c3 to 684cda6 Compare November 14, 2024 23:25

fix build

fffb451

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

dudikeleti commented Sep 27, 2024

datadog-ddstaging bot commented Sep 27, 2024 •

edited

Loading

GreenMatan left a comment

andrewlock commented Nov 15, 2024

andrewlock commented Nov 15, 2024

andrewlock commented Nov 15, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6092

Raw results

Slower ⚠️ in #6092

Raw results

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

Are you sure you want to change the base?

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized #6092

Conversation

dudikeleti commented Sep 27, 2024

Summary of changes

datadog-ddstaging bot commented Sep 27, 2024 • edited Loading

Datadog Report

❌ Failed Tests (1)

GreenMatan left a comment

Choose a reason for hiding this comment

andrewlock commented Nov 15, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 15, 2024

Throughput/Crank Report ⚡

andrewlock commented Nov 15, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6092

Raw results

Slower ⚠️ in #6092

Raw results

datadog-ddstaging bot commented Sep 27, 2024 •

edited

Loading