Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baggage part 1/3: change propagator signatures #6157

Merged
merged 40 commits into from
Nov 1, 2024
Merged

Baggage part 1/3: change propagator signatures #6157

merged 40 commits into from
Nov 1, 2024
+2,089 −1,057

Commits on Oct 31, 2024

  1. add new types

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b99e050 View commit details
    Browse the repository at this point in the history

  2. add PropagatorType property to IContextInjector and IContextExtractor

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d096da0 View commit details
    Browse the repository at this point in the history

  3. change IContextInjector and IContextExtractor to use PropagationContext

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f9a2a13 View commit details
    Browse the repository at this point in the history

  4. refactor SpanContextPropagator to use PropagationContext

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    abca132 View commit details
    Browse the repository at this point in the history

  5. refactor all propagators to use PropagationContext

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4f762f3 View commit details
    Browse the repository at this point in the history

  6. fix propagator usages

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    301e73a View commit details
    Browse the repository at this point in the history

  7. fix propagator usages in tests

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2ba4385 View commit details
    Browse the repository at this point in the history

  8. assert that baggage is null in the trace context extraction tests

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ade0a1c View commit details
    Browse the repository at this point in the history

  9. initialize the AsyncLocal<Baggage>

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3f8cf8f View commit details
    Browse the repository at this point in the history

  10. simplify merging Baggage in SpanContextPropagator.Extract()

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bf6a8e2 View commit details
    Browse the repository at this point in the history

  11. rename method

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3236458 View commit details
    Browse the repository at this point in the history

  12. assert that baggage is null 

    Co-authored-by: Zach Montoya <[email protected]>
    @lucaspimentel @zacharycmontoya
    lucaspimentel and zacharycmontoya committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    55a7759 View commit details
    Browse the repository at this point in the history

  13. rename Baggage methods

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    41ae893 View commit details
    Browse the repository at this point in the history

  14. fix Baggage.Merge() and add test case

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0d181db View commit details
    Browse the repository at this point in the history

  15. don't inject/extract baggage from the existing SpanContextInjector/Sp… 

    …anContextExtractor public apis
    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a029eec View commit details
    Browse the repository at this point in the history

  16. move methods to keep all Extract() overloads together

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    850d5ae View commit details
    Browse the repository at this point in the history

  17. update xml-doc comments

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bb6d299 View commit details
    Browse the repository at this point in the history

  18. avoid boxing

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8b02062 View commit details
    Browse the repository at this point in the history

  19. fix locking in Baggage.AddOrReplace() and add Baggage.MergeInto()

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1d66b31 View commit details
    Browse the repository at this point in the history

  20. add extension method PropagationContext.MergeBaggageInto()

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1292e9f View commit details
    Browse the repository at this point in the history

  21. use extension method PropagationContext.MergeBaggageInto()

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    92278eb View commit details
    Browse the repository at this point in the history

  22. use Baggage.MergeInto()

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ca5dcc0 View commit details
    Browse the repository at this point in the history

  23. make Baggage.Add public to enable collection initialization syntax

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d624cf0 View commit details
    Browse the repository at this point in the history

  24. remove unused Baggage.Merge(), update unit tests

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fa9ee54 View commit details
    Browse the repository at this point in the history

  25. don't merge extracted baggage in HttpWebRequest_EndGetResponse_Integr… 

    …ation
    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    96fcc77 View commit details
    Browse the repository at this point in the history

  26. inline the only call to Baggage.GetEmptyEnumerator()

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    101375d View commit details
    Browse the repository at this point in the history

  27. make GetEnumerator() and the static Baggage.AddOrReplace() private

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    943843d View commit details
    Browse the repository at this point in the history

  28. remove unused Baggage.GetAllItems()

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    123040e View commit details
    Browse the repository at this point in the history

  29. let SpanContextPropagator.Extract return null Baggage again

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    59bbba7 View commit details
    Browse the repository at this point in the history

  30. make Baggage sealed and add a nullable annotation

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4c5a9ea View commit details
    Browse the repository at this point in the history

  31. move Remove() methods together

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bfa715e View commit details
    Browse the repository at this point in the history

  32. implements Contains() and move Contains() methods together

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d4d3efb View commit details
    Browse the repository at this point in the history

  33. imeplement CopyTo()

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    86e4ca3 View commit details
    Browse the repository at this point in the history

  34. merge extracted baggage in RabbitMQIntegration

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a2b373a View commit details
    Browse the repository at this point in the history

  35. misc clean up

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    bd39647 View commit details
    Browse the repository at this point in the history

  36. fix comment

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f205700 View commit details
    Browse the repository at this point in the history

  37. use Baggage collection initializer syntax in tests

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d52c016 View commit details
    Browse the repository at this point in the history

  38. fix race condition when reading _items.Count, rename locals for consi… 

    …stency
    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a720a99 View commit details
    Browse the repository at this point in the history

  39. resolve another possible deadlock

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a1ddad9 View commit details
    Browse the repository at this point in the history

  40. rename static AddOrReplace to avoid confusion

    @lucaspimentel
    lucaspimentel committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6c5a422 View commit details
    Browse the repository at this point in the history