[Profiler] Use chrono types instead of integer type #6288
+396
−418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:profiler
gleocadie
force-pushed
the
gleocadie/use-strong-type-for-time-instead-of-int
branch
from
a16e088
to
2a7c290
Compare
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 460525 Passed, 3238 Skipped, 21h 16m 33.72s Total Time ❌ Failed Tests (1)
|
gleocadie
force-pushed
the
gleocadie/use-strong-type-for-time-instead-of-int
branch
2 times, most recently
from
7b57237
to
f50ff96
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6288) - mean (71ms) : 63, 80
. : milestone, 71,
master - mean (74ms) : 65, 83
. : milestone, 74,
section CallTarget+Inlining+NGEN
This PR (6288) - mean (1,108ms) : 1089, 1128
. : milestone, 1108,
master - mean (1,110ms) : 1085, 1135
. : milestone, 1110,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6288) - mean (108ms) : 106, 110
. : milestone, 108,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6288) - mean (761ms) : 746, 776
. : milestone, 761,
master - mean (767ms) : 752, 783
. : milestone, 767,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6288) - mean (92ms) : 90, 93
. : milestone, 92,
master - mean (92ms) : 89, 95
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6288) - mean (719ms) : 704, 734
. : milestone, 719,
master - mean (727ms) : 714, 739
. : milestone, 727,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6288) - mean (191ms) : 185, 197
. : milestone, 191,
master - mean (190ms) : 187, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6288) - mean (1,211ms) : 1189, 1232
. : milestone, 1211,
master - mean (1,212ms) : 1184, 1240
. : milestone, 1212,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6288) - mean (278ms) : 273, 282
. : milestone, 278,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6288) - mean (942ms) : 923, 962
. : milestone, 942,
master - mean (942ms) : 926, 959
. : milestone, 942,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6288) - mean (266ms) : 262, 271
. : milestone, 266,
master - mean (266ms) : 262, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6288) - mean (926ms) : 910, 942
. : milestone, 926,
master - mean (927ms) : 910, 945
. : milestone, 927,
|
gleocadie
force-pushed
the
gleocadie/use-strong-type-for-time-instead-of-int
branch
from
f50ff96
to
55acb33
Compare
gleocadie
force-pushed
the
gleocadie/use-strong-type-for-time-instead-of-int
branch
2 times, most recently
from
7faabb5
to
fbf9825
Compare
gleocadie
changed the title
gleocadie
force-pushed
the
gleocadie/use-strong-type-for-time-instead-of-int
branch
from
fbf9825
to
f6bd75e
Compare
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6288) (11.166M) : 0, 11166306
master (11.106M) : 0, 11106407
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6288) (7.213M) : 0, 7213062
master (7.204M) : 0, 7204056
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.595M) : 0, 7595165
section Manual
master (11.008M) : 0, 11007592
section Manual + Automatic
This PR (6288) (6.624M) : 0, 6623725
master (6.725M) : 0, 6725238
section DD_TRACE_ENABLED=0
master (10.307M) : 0, 10307106
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6288) (9.610M) : 0, 9609538
master (9.667M) : 0, 9666990
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6288) (6.507M) : 0, 6507391
master (6.549M) : 0, 6549462
section Trace stats
master (6.703M) : 0, 6702885
section Manual
master (9.608M) : 0, 9608456
section Manual + Automatic
This PR (6288) (5.962M) : 0, 5962217
master (5.958M) : 0, 5958327
section DD_TRACE_ENABLED=0
master (8.816M) : 0, 8816192
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6288) (9.653M) : 0, 9652550
master (9.761M) : 0, 9761080
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6288) (6.274M) : 0, 6274285
master (6.222M) : 0, 6221888
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.068M) : 0, 7067863
section Manual
master (9.826M) : 0, 9826453
section Manual + Automatic
This PR (6288) (5.996M) : 0, 5996334
master (5.724M) : 0, 5723553
section DD_TRACE_ENABLED=0
master (9.178M) : 0, 9177760
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details