feat(contrib/mark3labs/mcp-go): skip telemetry injection for UI-only tools#4942
Open
jboolean wants to merge 1 commit into
Open
feat(contrib/mark3labs/mcp-go): skip telemetry injection for UI-only tools#4942jboolean wants to merge 1 commit into
jboolean wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
apm:ecosystem
This was referenced Jun 24, 2026
Contributor
Author
3 tasks
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 2ff4a7b | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-07-01 16:38:29 Comparing candidate commit 2ff4a7b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 321 metrics, 2 unstable metrics, 1 flaky benchmarks without significant changes.
|
jboolean
commented
Jun 24, 2026
jboolean
force-pushed
the
jb/mcp-intent-from-context
branch
from
0f308e2 to
301b597
Compare
jboolean
force-pushed
the
jb/mcp-skip-ui-only-tools
branch
from
d0e5464 to
0d1c005
Compare
jboolean
force-pushed
the
jb/mcp-skip-ui-only-tools
branch
from
0d1c005 to
a8261f9
Compare
jboolean
force-pushed
the
jb/mcp-intent-from-context
branch
from
301b597 to
ce524bf
Compare
2 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8261f9663
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if meta == nil { | ||
| return true | ||
| } | ||
| uiMap, ok := meta.AdditionalFields["ui"].(map[string]any) |
There was a problem hiding this comment.
When a server constructs the same valid _meta.ui.visibility wire format with a typed Go value, such as a struct or map[string][]string, this assertion falls through and treats the tool as model-callable. mcp.Meta.AdditionalFields accepts arbitrary values and will marshal those typed values correctly, so app-only tools declared that way still get required telemetry injected in tools/list, leaving the UI calls rejected for the scenario this change is meant to fix.
Useful? React with 👍 / 👎.
jboolean
force-pushed
the
jb/mcp-intent-from-context
branch
from
ce524bf to
ec14544
Compare
jboolean
force-pushed
the
jb/mcp-skip-ui-only-tools
branch
2 times, most recently
from
a850ceb to
cb69328
Compare
jboolean
force-pushed
the
jb/mcp-intent-from-context
branch
from
ec14544 to
0c444d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
2 tasks
jboolean
force-pushed
the
jb/mcp-skip-ui-only-tools
branch
from
cb69328 to
5f2c10d
Compare
Contributor
Config Audit |
jboolean
force-pushed
the
jb/mcp-skip-ui-only-tools
branch
2 times, most recently
from
2ff4a7b to
33051de
Compare
jboolean
force-pushed
the
jb/mcp-intent-from-context
branch
2 times, most recently
from
08d7e54 to
13679e8
Compare
jboolean
force-pushed
the
jb/mcp-skip-ui-only-tools
branch
from
33051de to
0c444d5
Compare
jboolean
changed the base branch from
jb/mcp-intent-from-context
to
graphite-base/4942
jboolean
force-pushed
the
jb/mcp-skip-ui-only-tools
branch
from
5f2c10d to
2ff4a7b
Compare
jboolean
force-pushed
the
graphite-base/4942
branch
from
13679e8 to
2de53a9
Compare
jboolean
changed the base branch from
graphite-base/4942
to
jb/mcp-intent-from-context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stack ports functionality added in the clone of this contrib in dd-source back to dd-trace-go.
Summary
The intent-capture
ListToolshook unconditionally addstelemetryas a required field to every tool's input schema. That breaks tools annotated as UI-only (_meta.ui.visibilityexcluding"model"): they are invoked by the app UI, not by the model, so the UI caller has nointentto supply. OpenAI's MCP client strictly validates tool arguments against the advertised schema and rejects every UI-driven call as a result.This change adds an
isModelCallablehelper that inspects*mcp.Meta.AdditionalFields["ui"]["visibility"](handling both[]stringand[]anyshapes from JSON round-trips) and short-circuits the injection when the model is not in the visibility list. Tools with no_meta.ui.visibilitycontinue to default to model-callable per the MCP Apps spec.Ported from internal dd-source PR #420911.
Test plan
TestIntentCaptureSkipsUIOnlyTools— three tools (model-only, UI-only[app], dual[app, model]); assertstelemetryis injected for model and dual but not for UI-only.Stacked on #4941.
MCP standard reference
The
_meta.ui.visibilityfield is part of the official MCP Apps extension. Values:["model", "app"](default),["model"], or["app"]— they control which actor may invoke the tool. UI-only tools (["app"]) are invoked by the host shell, never by the model. This PR's skip logic respects that standard.Parallel port in the modelcontextprotocol/go-sdk contrib: #4949