-
Notifications
You must be signed in to change notification settings - Fork 300
[Debugger] Allow double interval for diagnostics uploads #8681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (324.503 µs) : 272, 377
. : milestone, 325,
basic (313.733 µs) : 303, 324
. : milestone, 314,
loop (10.154 ms) : 10113, 10195
. : milestone, 10154,
section candidate
noprobe (304.735 µs) : 280, 329
. : milestone, 305,
basic (311.125 µs) : 302, 320
. : milestone, 311,
loop (11.519 ms) : 11486, 11552
. : milestone, 11519,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~ffdad5861a, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062070
Total [baseline] (10.513 s) : 0, 10513346
Agent [candidate] (1.056 s) : 0, 1056003
Total [candidate] (10.527 s) : 0, 10526583
section appsec
Agent [baseline] (1.205 s) : 0, 1204973
Total [baseline] (10.775 s) : 0, 10774587
Agent [candidate] (1.197 s) : 0, 1197332
Total [candidate] (10.812 s) : 0, 10812382
section iast
Agent [baseline] (1.186 s) : 0, 1185953
Total [baseline] (11.031 s) : 0, 11031336
Agent [candidate] (1.188 s) : 0, 1187863
Total [candidate] (11.034 s) : 0, 11033970
section profiling
Agent [baseline] (1.295 s) : 0, 1294985
Total [baseline] (10.909 s) : 0, 10908663
Agent [candidate] (1.292 s) : 0, 1291868
Total [candidate] (10.922 s) : 0, 10922210
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~ffdad5861a, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.854 ms) : 0, 726854
BytebuddyAgent [candidate] (722.068 ms) : 0, 722068
GlobalTracer [baseline] (239.961 ms) : 0, 239961
GlobalTracer [candidate] (239.816 ms) : 0, 239816
AppSec [baseline] (54.768 ms) : 0, 54768
AppSec [candidate] (54.493 ms) : 0, 54493
Debugger [baseline] (4.437 ms) : 0, 4437
Debugger [candidate] (4.437 ms) : 0, 4437
Remote Config [baseline] (700.164 µs) : 0, 700
Remote Config [candidate] (719.787 µs) : 0, 720
Telemetry [baseline] (14.442 ms) : 0, 14442
Telemetry [candidate] (13.625 ms) : 0, 13625
section appsec
BytebuddyAgent [baseline] (745.09 ms) : 0, 745090
BytebuddyAgent [candidate] (739.951 ms) : 0, 739951
GlobalTracer [baseline] (237.748 ms) : 0, 237748
GlobalTracer [candidate] (235.803 ms) : 0, 235803
IAST [baseline] (21.847 ms) : 0, 21847
IAST [candidate] (21.434 ms) : 0, 21434
AppSec [baseline] (177.214 ms) : 0, 177214
AppSec [candidate] (176.942 ms) : 0, 176942
Debugger [baseline] (4.248 ms) : 0, 4248
Debugger [candidate] (4.263 ms) : 0, 4263
Remote Config [baseline] (635.039 µs) : 0, 635
Remote Config [candidate] (651.302 µs) : 0, 651
Telemetry [baseline] (8.246 ms) : 0, 8246
Telemetry [candidate] (8.265 ms) : 0, 8265
section iast
BytebuddyAgent [baseline] (842.23 ms) : 0, 842230
BytebuddyAgent [candidate] (843.726 ms) : 0, 843726
GlobalTracer [baseline] (229.972 ms) : 0, 229972
GlobalTracer [candidate] (230.823 ms) : 0, 230823
IAST [baseline] (22.608 ms) : 0, 22608
IAST [candidate] (22.801 ms) : 0, 22801
AppSec [baseline] (56.763 ms) : 0, 56763
AppSec [candidate] (56.326 ms) : 0, 56326
Debugger [baseline] (4.15 ms) : 0, 4150
Debugger [candidate] (4.097 ms) : 0, 4097
Remote Config [baseline] (619.175 µs) : 0, 619
Remote Config [candidate] (613.019 µs) : 0, 613
Telemetry [baseline] (8.791 ms) : 0, 8791
Telemetry [candidate] (8.753 ms) : 0, 8753
section profiling
BytebuddyAgent [baseline] (716.405 ms) : 0, 716405
BytebuddyAgent [candidate] (712.675 ms) : 0, 712675
GlobalTracer [baseline] (359.062 ms) : 0, 359062
GlobalTracer [candidate] (359.923 ms) : 0, 359923
AppSec [baseline] (54.317 ms) : 0, 54317
AppSec [candidate] (53.538 ms) : 0, 53538
Debugger [baseline] (4.32 ms) : 0, 4320
Debugger [candidate] (4.293 ms) : 0, 4293
Remote Config [baseline] (721.638 µs) : 0, 722
Remote Config [candidate] (706.647 µs) : 0, 707
Telemetry [baseline] (8.995 ms) : 0, 8995
Telemetry [candidate] (8.929 ms) : 0, 8929
ProfilingAgent [baseline] (102.877 ms) : 0, 102877
ProfilingAgent [candidate] (103.883 ms) : 0, 103883
Profiling [baseline] (102.904 ms) : 0, 102904
Profiling [candidate] (103.908 ms) : 0, 103908
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~ffdad5861a, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059651
Total [baseline] (8.698 s) : 0, 8697567
Agent [candidate] (1.067 s) : 0, 1066900
Total [candidate] (8.709 s) : 0, 8709129
section iast
Agent [baseline] (1.184 s) : 0, 1183666
Total [baseline] (9.293 s) : 0, 9292903
Agent [candidate] (1.186 s) : 0, 1185554
Total [candidate] (9.252 s) : 0, 9251645
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1182275
Total [baseline] (9.271 s) : 0, 9270636
Agent [candidate] (1.184 s) : 0, 1183638
Total [candidate] (9.283 s) : 0, 9283431
section iast_TELEMETRY_OFF
Agent [baseline] (1.182 s) : 0, 1182314
Total [baseline] (9.267 s) : 0, 9266708
Agent [candidate] (1.186 s) : 0, 1185679
Total [candidate] (9.274 s) : 0, 9274308
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~ffdad5861a, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.334 ms) : 0, 722334
BytebuddyAgent [candidate] (728.184 ms) : 0, 728184
GlobalTracer [baseline] (239.835 ms) : 0, 239835
GlobalTracer [candidate] (241.752 ms) : 0, 241752
AppSec [baseline] (56.588 ms) : 0, 56588
AppSec [candidate] (55.76 ms) : 0, 55760
Debugger [baseline] (4.435 ms) : 0, 4435
Debugger [candidate] (4.406 ms) : 0, 4406
Remote Config [baseline] (710.317 µs) : 0, 710
Remote Config [candidate] (708.918 µs) : 0, 709
Telemetry [baseline] (15.032 ms) : 0, 15032
Telemetry [candidate] (15.115 ms) : 0, 15115
section iast
BytebuddyAgent [baseline] (841.045 ms) : 0, 841045
BytebuddyAgent [candidate] (841.944 ms) : 0, 841944
GlobalTracer [baseline] (229.79 ms) : 0, 229790
GlobalTracer [candidate] (229.985 ms) : 0, 229985
IAST [baseline] (22.766 ms) : 0, 22766
IAST [candidate] (22.72 ms) : 0, 22720
AppSec [baseline] (55.898 ms) : 0, 55898
AppSec [candidate] (56.59 ms) : 0, 56590
Debugger [baseline] (4.14 ms) : 0, 4140
Debugger [candidate] (4.142 ms) : 0, 4142
Remote Config [baseline] (610.331 µs) : 0, 610
Remote Config [candidate] (604.92 µs) : 0, 605
Telemetry [baseline] (8.688 ms) : 0, 8688
Telemetry [candidate] (8.799 ms) : 0, 8799
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.143 ms) : 0, 840143
BytebuddyAgent [candidate] (840.721 ms) : 0, 840721
GlobalTracer [baseline] (229.389 ms) : 0, 229389
GlobalTracer [candidate] (229.849 ms) : 0, 229849
IAST [baseline] (22.737 ms) : 0, 22737
IAST [candidate] (22.588 ms) : 0, 22588
AppSec [baseline] (55.762 ms) : 0, 55762
AppSec [candidate] (56.206 ms) : 0, 56206
Debugger [baseline] (4.128 ms) : 0, 4128
Debugger [candidate] (4.143 ms) : 0, 4143
Remote Config [baseline] (610.082 µs) : 0, 610
Remote Config [candidate] (598.302 µs) : 0, 598
Telemetry [baseline] (8.724 ms) : 0, 8724
Telemetry [candidate] (8.787 ms) : 0, 8787
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.795 ms) : 0, 839795
BytebuddyAgent [candidate] (841.125 ms) : 0, 841125
GlobalTracer [baseline] (230.085 ms) : 0, 230085
GlobalTracer [candidate] (231.49 ms) : 0, 231490
IAST [baseline] (22.275 ms) : 0, 22275
IAST [candidate] (22.39 ms) : 0, 22390
AppSec [baseline] (56.1 ms) : 0, 56100
AppSec [candidate] (56.513 ms) : 0, 56513
Debugger [baseline] (4.11 ms) : 0, 4110
Debugger [candidate] (4.136 ms) : 0, 4136
Remote Config [baseline] (607.034 µs) : 0, 607
Remote Config [candidate] (611.35 µs) : 0, 611
Telemetry [baseline] (8.656 ms) : 0, 8656
Telemetry [candidate] (8.662 ms) : 0, 8662
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~ffdad5861a, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section baseline
no_agent (380.607 µs) : 361, 400
. : milestone, 381,
iast (518.263 µs) : 496, 540
. : milestone, 518,
iast_FULL (735.191 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (569.67 µs) : 547, 592
. : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (520.139 µs) : 498, 542
. : milestone, 520,
iast_INACTIVE (473.602 µs) : 452, 495
. : milestone, 474,
iast_TELEMETRY_OFF (504.88 µs) : 483, 527
. : milestone, 505,
tracing (465.728 µs) : 445, 486
. : milestone, 466,
section candidate
no_agent (387.011 µs) : 367, 407
. : milestone, 387,
iast (521.672 µs) : 499, 544
. : milestone, 522,
iast_FULL (738.414 µs) : 716, 761
. : milestone, 738,
iast_GLOBAL (570.652 µs) : 548, 594
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (519.179 µs) : 497, 541
. : milestone, 519,
iast_INACTIVE (464.864 µs) : 444, 486
. : milestone, 465,
iast_TELEMETRY_OFF (506.243 µs) : 484, 528
. : milestone, 506,
tracing (465.123 µs) : 444, 486
. : milestone, 465,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~ffdad5861a, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1361
. : milestone, 1341,
appsec (1.738 ms) : 1715, 1762
. : milestone, 1738,
appsec_no_iast (1.784 ms) : 1761, 1806
. : milestone, 1784,
code_origins (1.695 ms) : 1667, 1722
. : milestone, 1695,
iast (1.529 ms) : 1505, 1554
. : milestone, 1529,
profiling (1.512 ms) : 1489, 1536
. : milestone, 1512,
tracing (1.499 ms) : 1474, 1523
. : milestone, 1499,
section candidate
no_agent (1.379 ms) : 1360, 1399
. : milestone, 1379,
appsec (1.741 ms) : 1717, 1765
. : milestone, 1741,
appsec_no_iast (1.756 ms) : 1732, 1780
. : milestone, 1756,
code_origins (1.671 ms) : 1644, 1698
. : milestone, 1671,
iast (1.533 ms) : 1509, 1557
. : milestone, 1533,
profiling (1.577 ms) : 1553, 1602
. : milestone, 1577,
tracing (1.522 ms) : 1498, 1547
. : milestone, 1522,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~ffdad5861a, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section baseline
no_agent (14.822 s) : 14822000, 14822000
. : milestone, 14822000,
appsec (15.113 s) : 15113000, 15113000
. : milestone, 15113000,
iast (18.401 s) : 18401000, 18401000
. : milestone, 18401000,
iast_GLOBAL (17.694 s) : 17694000, 17694000
. : milestone, 17694000,
profiling (14.991 s) : 14991000, 14991000
. : milestone, 14991000,
tracing (14.649 s) : 14649000, 14649000
. : milestone, 14649000,
section candidate
no_agent (15.628 s) : 15628000, 15628000
. : milestone, 15628000,
appsec (15.117 s) : 15117000, 15117000
. : milestone, 15117000,
iast (18.648 s) : 18648000, 18648000
. : milestone, 18648000,
iast_GLOBAL (18.216 s) : 18216000, 18216000
. : milestone, 18216000,
profiling (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
tracing (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~ffdad5861a, baseline=1.48.0-SNAPSHOT~c9b9007111
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.372 ms) : 2325, 2418
. : milestone, 2372,
iast (2.148 ms) : 2090, 2207
. : milestone, 2148,
iast_GLOBAL (2.197 ms) : 2138, 2257
. : milestone, 2197,
profiling (2.015 ms) : 1967, 2063
. : milestone, 2015,
tracing (1.976 ms) : 1930, 2021
. : milestone, 1976,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.371 ms) : 2325, 2417
. : milestone, 2371,
iast (2.156 ms) : 2098, 2215
. : milestone, 2156,
iast_GLOBAL (2.195 ms) : 2137, 2254
. : milestone, 2195,
profiling (1.995 ms) : 1948, 2041
. : milestone, 1995,
tracing (1.983 ms) : 1938, 2029
. : milestone, 1983,
|
What Does This Do
Updated
DynamicInstrumentationDiagnosticsInterval
to support double values instead of integers.Motivation
Allowing sub-second intervals can significantly improve system testing by enabling more frequent diagnostics. Rather than introducing a new variable or renaming the existing one, this change maintains compatibility while extending functionality in a simple and effective way.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]