-
Couldn't load subscription status.
- Fork 315
Add Config Inversion Linter for Config Definitions #9849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: af20a7c | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~af20a7ce35, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1035615
Total [baseline] (10.892 s) : 0, 10892478
Agent [candidate] (1.031 s) : 0, 1031078
Total [candidate] (10.833 s) : 0, 10833330
section appsec
Agent [baseline] (1.218 s) : 0, 1217768
Total [baseline] (10.93 s) : 0, 10929533
Agent [candidate] (1.211 s) : 0, 1210536
Total [candidate] (11.006 s) : 0, 11005913
section iast
Agent [baseline] (1.168 s) : 0, 1167773
Total [baseline] (11.184 s) : 0, 11183739
Agent [candidate] (1.169 s) : 0, 1168757
Total [candidate] (11.168 s) : 0, 11168466
section profiling
Agent [baseline] (1.174 s) : 0, 1173892
Total [baseline] (10.915 s) : 0, 10915430
Agent [candidate] (1.173 s) : 0, 1172758
Total [candidate] (11.007 s) : 0, 11006919
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~af20a7ce35, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (706.343 ms) : 0, 706343
BytebuddyAgent [candidate] (702.884 ms) : 0, 702884
GlobalTracer [baseline] (245.988 ms) : 0, 245988
GlobalTracer [candidate] (245.354 ms) : 0, 245354
AppSec [baseline] (32.383 ms) : 0, 32383
AppSec [candidate] (32.311 ms) : 0, 32311
Debugger [baseline] (6.427 ms) : 0, 6427
Debugger [candidate] (6.385 ms) : 0, 6385
Remote Config [baseline] (685.703 µs) : 0, 686
Remote Config [candidate] (684.918 µs) : 0, 685
Telemetry [baseline] (13.586 ms) : 0, 13586
Telemetry [candidate] (15.174 ms) : 0, 15174
Flare Poller [baseline] (7.306 ms) : 0, 7306
Flare Poller [candidate] (5.676 ms) : 0, 5676
section appsec
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (734.965 ms) : 0, 734965
BytebuddyAgent [candidate] (731.281 ms) : 0, 731281
GlobalTracer [baseline] (239.103 ms) : 0, 239103
GlobalTracer [candidate] (237.66 ms) : 0, 237660
IAST [baseline] (25.489 ms) : 0, 25489
IAST [candidate] (25.163 ms) : 0, 25163
AppSec [baseline] (175.972 ms) : 0, 175972
AppSec [candidate] (174.777 ms) : 0, 174777
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (5.958 ms) : 0, 5958
Remote Config [baseline] (662.115 µs) : 0, 662
Remote Config [candidate] (629.273 µs) : 0, 629
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.394 ms) : 0, 8394
Flare Poller [baseline] (4.007 ms) : 0, 4007
Flare Poller [candidate] (3.917 ms) : 0, 3917
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.499 ms) : 0, 1499
BytebuddyAgent [baseline] (828.865 ms) : 0, 828865
BytebuddyAgent [candidate] (829.279 ms) : 0, 829279
GlobalTracer [baseline] (234.665 ms) : 0, 234665
GlobalTracer [candidate] (235.192 ms) : 0, 235192
IAST [baseline] (31.957 ms) : 0, 31957
IAST [candidate] (33.718 ms) : 0, 33718
AppSec [baseline] (30.03 ms) : 0, 30030
AppSec [candidate] (28.059 ms) : 0, 28059
Debugger [baseline] (6.126 ms) : 0, 6126
Debugger [candidate] (6.192 ms) : 0, 6192
Remote Config [baseline] (606.779 µs) : 0, 607
Remote Config [candidate] (599.569 µs) : 0, 600
Telemetry [baseline] (8.454 ms) : 0, 8454
Telemetry [candidate] (8.484 ms) : 0, 8484
Flare Poller [baseline] (4.135 ms) : 0, 4135
Flare Poller [candidate] (4.188 ms) : 0, 4188
section profiling
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (727.457 ms) : 0, 727457
BytebuddyAgent [candidate] (726.145 ms) : 0, 726145
GlobalTracer [baseline] (220.435 ms) : 0, 220435
GlobalTracer [candidate] (220.258 ms) : 0, 220258
AppSec [baseline] (32.185 ms) : 0, 32185
AppSec [candidate] (32.29 ms) : 0, 32290
Debugger [baseline] (13.731 ms) : 0, 13731
Debugger [candidate] (10.598 ms) : 0, 10598
Remote Config [baseline] (700.411 µs) : 0, 700
Remote Config [candidate] (3.041 ms) : 0, 3041
Telemetry [baseline] (8.972 ms) : 0, 8972
Telemetry [candidate] (9.325 ms) : 0, 9325
Flare Poller [baseline] (4.132 ms) : 0, 4132
Flare Poller [candidate] (4.069 ms) : 0, 4069
ProfilingAgent [baseline] (109.341 ms) : 0, 109341
ProfilingAgent [candidate] (109.631 ms) : 0, 109631
Profiling [baseline] (109.975 ms) : 0, 109975
Profiling [candidate] (110.273 ms) : 0, 110273
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~af20a7ce35, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.031 s) : 0, 1030502
Total [baseline] (8.683 s) : 0, 8682928
Agent [candidate] (1.04 s) : 0, 1040099
Total [candidate] (8.661 s) : 0, 8661190
section iast
Agent [baseline] (1.177 s) : 0, 1177251
Total [baseline] (9.372 s) : 0, 9371894
Agent [candidate] (1.17 s) : 0, 1169867
Total [candidate] (9.412 s) : 0, 9412479
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~af20a7ce35, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (702.178 ms) : 0, 702178
BytebuddyAgent [candidate] (709.102 ms) : 0, 709102
GlobalTracer [baseline] (245.379 ms) : 0, 245379
GlobalTracer [candidate] (247.191 ms) : 0, 247191
AppSec [baseline] (32.26 ms) : 0, 32260
AppSec [candidate] (32.718 ms) : 0, 32718
Debugger [baseline] (6.374 ms) : 0, 6374
Debugger [candidate] (6.459 ms) : 0, 6459
Remote Config [baseline] (696.323 µs) : 0, 696
Remote Config [candidate] (687.509 µs) : 0, 688
Telemetry [baseline] (13.076 ms) : 0, 13076
Telemetry [candidate] (15.229 ms) : 0, 15229
Flare Poller [baseline] (7.891 ms) : 0, 7891
Flare Poller [candidate] (5.863 ms) : 0, 5863
section iast
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.492 ms) : 0, 1492
BytebuddyAgent [baseline] (835.3 ms) : 0, 835300
BytebuddyAgent [candidate] (831.363 ms) : 0, 831363
GlobalTracer [baseline] (237.112 ms) : 0, 237112
GlobalTracer [candidate] (234.935 ms) : 0, 234935
IAST [baseline] (35.687 ms) : 0, 35687
IAST [candidate] (34.462 ms) : 0, 34462
AppSec [baseline] (26.755 ms) : 0, 26755
AppSec [candidate] (26.962 ms) : 0, 26962
Debugger [baseline] (6.218 ms) : 0, 6218
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (616.089 µs) : 0, 616
Remote Config [candidate] (587.966 µs) : 0, 588
Telemetry [baseline] (8.482 ms) : 0, 8482
Telemetry [candidate] (8.373 ms) : 0, 8373
Flare Poller [baseline] (4.14 ms) : 0, 4140
Flare Poller [candidate] (4.109 ms) : 0, 4109
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~af20a7ce35, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section baseline
no_agent (36.013 ms) : 35724, 36302
. : milestone, 36013,
appsec (46.82 ms) : 46418, 47222
. : milestone, 46820,
code_origins (43.663 ms) : 43291, 44035
. : milestone, 43663,
iast (44.689 ms) : 44305, 45073
. : milestone, 44689,
profiling (48.18 ms) : 47731, 48628
. : milestone, 48180,
tracing (43.303 ms) : 42944, 43662
. : milestone, 43303,
section candidate
no_agent (37.256 ms) : 36954, 37559
. : milestone, 37256,
appsec (46.853 ms) : 46436, 47269
. : milestone, 46853,
code_origins (43.827 ms) : 43461, 44194
. : milestone, 43827,
iast (45.668 ms) : 45272, 46065
. : milestone, 45668,
profiling (46.615 ms) : 46191, 47039
. : milestone, 46615,
tracing (44.79 ms) : 44405, 45174
. : milestone, 44790,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~af20a7ce35, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section baseline
no_agent (4.411 ms) : 4356, 4465
. : milestone, 4411,
iast (9.596 ms) : 9433, 9758
. : milestone, 9596,
iast_FULL (14.805 ms) : 14506, 15103
. : milestone, 14805,
iast_GLOBAL (10.306 ms) : 10124, 10487
. : milestone, 10306,
profiling (8.911 ms) : 8771, 9051
. : milestone, 8911,
tracing (8.193 ms) : 8071, 8314
. : milestone, 8193,
section candidate
no_agent (4.399 ms) : 4346, 4453
. : milestone, 4399,
iast (9.58 ms) : 9422, 9739
. : milestone, 9580,
iast_FULL (14.289 ms) : 14002, 14576
. : milestone, 14289,
iast_GLOBAL (11.161 ms) : 10957, 11364
. : milestone, 11161,
profiling (9.092 ms) : 8945, 9239
. : milestone, 9092,
tracing (7.881 ms) : 7768, 7994
. : milestone, 7881,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~af20a7ce35, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.742 ms) : 3525, 3960
. : milestone, 3742,
iast (2.215 ms) : 2151, 2279
. : milestone, 2215,
iast_GLOBAL (2.258 ms) : 2194, 2322
. : milestone, 2258,
profiling (2.074 ms) : 2022, 2127
. : milestone, 2074,
tracing (2.031 ms) : 1981, 2081
. : milestone, 2031,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.647 ms) : 3434, 3860
. : milestone, 3647,
iast (2.212 ms) : 2148, 2275
. : milestone, 2212,
iast_GLOBAL (2.251 ms) : 2187, 2314
. : milestone, 2251,
profiling (2.082 ms) : 2029, 2135
. : milestone, 2082,
tracing (2.036 ms) : 1986, 2086
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~af20a7ce35, baseline=1.55.0-SNAPSHOT~c0b9147e6b
dateFormat X
axisFormat %s
section baseline
no_agent (15.504 s) : 15504000, 15504000
. : milestone, 15504000,
appsec (14.51 s) : 14510000, 14510000
. : milestone, 14510000,
iast (18.839 s) : 18839000, 18839000
. : milestone, 18839000,
iast_GLOBAL (18.125 s) : 18125000, 18125000
. : milestone, 18125000,
profiling (15.494 s) : 15494000, 15494000
. : milestone, 15494000,
tracing (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
section candidate
no_agent (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
appsec (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
iast (18.547 s) : 18547000, 18547000
. : milestone, 18547000,
iast_GLOBAL (18.118 s) : 18118000, 18118000
. : milestone, 18118000,
profiling (14.748 s) : 14748000, 14748000
. : milestone, 14748000,
tracing (15.265 s) : 15265000, 15265000
. : milestone, 15265000,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
This PR adds another Gradle task to the
ConfigInversionLinterplugin. The task goes through all Configuration definitions indd-trace-api/src/main/java/datadog/trace/api/configand ensures that all defined configurations exist in the localmetadata/supported-configurations.jsonfile. Note that some files (specificallyProfilingConfig.java) also define default values in the package, and the Gradle task accounts for that by skipping all strings ending with_DEFAULT.Additionally, the
ConfigInversionLinterplugin was mistakenly not activated in prior PRs. This PR activates the plugin to enable all relevant tasks.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]