Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): rewrite that one test not to use naked waitpid #10722

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Sep 19, 2024

When we switched to gitlab, this one test started hanging indefinitely. I think we should have better waits. This fixes precisely one of them.

Backporting a few versions because this could have CI issues.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@sanchda sanchda added changelog/no-changelog A changelog entry is not required for this PR. backport 2.11 backport 2.12 backport 2.13 labels Sep 19, 2024
@sanchda sanchda requested a review from a team as a code owner September 19, 2024 19:07
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/profiling/test_main.py                                            @DataDog/profiling-python

@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2024

Benchmarks

Benchmark execution time: 2024-09-19 22:10:35

Comparing candidate commit 7f3a8fa in PR branch sanchda/eliminate_naked_waitpid with baseline commit b07f73a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants