Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): support http server error status configuration #10723

Merged
merged 10 commits into from
Oct 2, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Sep 19, 2024

DD_TRACE_HTTP_SERVER_ERROR_STATUSES can only be enabled via the programmatic api. This PR adds an environment variable that can be used to update this configuration.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur force-pushed the munir/add-support-for-http-error-status-env branch from 8e891bc to afae1c3 Compare September 19, 2024 19:38
Copy link
Contributor

CODEOWNERS have been resolved as:

releasenotes/notes/support_http_client_error_status_env-acdf049c64330a20.yaml  @DataDog/apm-python
ddtrace/settings/config.py                                              @DataDog/python-guild @DataDog/apm-sdk-api-python
docs/configuration.rst                                                  @DataDog/python-guild
tests/tracer/test_trace_utils.py                                        @DataDog/apm-sdk-api-python

@mabdinur mabdinur force-pushed the munir/add-support-for-http-error-status-env branch from afae1c3 to 550a850 Compare September 19, 2024 19:38
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Sep 19, 2024

Datadog Report

Branch report: munir/add-support-for-http-error-status-env
Commit report: 5b9800c
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 19m 51.75s Total duration (16m 20.77s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2024

Benchmarks

Benchmark execution time: 2024-10-02 19:41:08

Comparing candidate commit 5b9800c in PR branch munir/add-support-for-http-error-status-env with baseline commit afb6f2f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 371 metrics, 53 unstable metrics.

@mabdinur mabdinur changed the title feat(tracing): support http server error status env feat(tracing): support http server error status configuration Sep 23, 2024
@mabdinur mabdinur marked this pull request as ready for review September 23, 2024 19:55
@mabdinur mabdinur requested review from a team as code owners September 23, 2024 19:55
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
docs/configuration.rst Outdated Show resolved Hide resolved
@mabdinur mabdinur force-pushed the munir/add-support-for-http-error-status-env branch from a8fb6d5 to 7cb25d0 Compare October 2, 2024 18:40
@mabdinur mabdinur enabled auto-merge (squash) October 2, 2024 18:41
docs/configuration.rst Outdated Show resolved Hide resolved
@mabdinur mabdinur merged commit da7625f into main Oct 2, 2024
580 checks passed
@mabdinur mabdinur deleted the munir/add-support-for-http-error-status-env branch October 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants