Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(di): use enum value for evaluate_at property [backport 2.13] #11150

Closed
wants to merge 2 commits into from
Closed

fix(di): use enum value for evaluate_at property [backport 2.13] #11150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d120c
fix(di): use enum value for evaluate_at property (#11100)
P403n1x87 Oct 24, 2024
48fbc9e
Merge branch '2.13' into backport-11100-to-2.13
P403n1x87 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ddtrace/debugging/_probe/remoteconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from ddtrace.debugging._probe.model import MetricFunctionProbe
from ddtrace.debugging._probe.model import MetricLineProbe
from ddtrace.debugging._probe.model import Probe
from ddtrace.debugging._probe.model import ProbeEvaluateTimingForMethod
from ddtrace.debugging._probe.model import ProbeType
from ddtrace.debugging._probe.model import SpanDecoration
from ddtrace.debugging._probe.model import SpanDecorationFunctionProbe
Expand Down Expand Up @@ -102,7 +103,7 @@ def build(cls, args: Dict[str, Any], attribs: Dict[str, Any]) -> Any:

args["module"] = where.get("type") or where["typeName"]
args["func_qname"] = where.get("method") or where["methodName"]
args["evaluate_at"] = attribs.get("evaluateAt")
args["evaluate_at"] = ProbeEvaluateTimingForMethod[attribs.get("evaluateAt", "DEFAULT")]

return cls.__function_class__(**args)

Expand Down
5 changes: 5 additions & 0 deletions releasenotes/notes/fix-span-decoration-probe-timing-dc4ce0664fa645b9.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
fixes:
- |
dynamic instrumentation: Fixes an issue that prevented dynamic span tags
probes from adding the requested tags to the requested span.
Loading