Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otel): collect telemetry for otel configurations #11351

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 11, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Nov 11, 2024

CODEOWNERS have been resolved as:

ddtrace/settings/_otel_remapper.py                                      @DataDog/apm-core-python
tests/.suitespec.json                                                   @DataDog/python-guild @DataDog/apm-core-python
tests/opentelemetry/test_config.py                                      @DataDog/apm-sdk-api-python
tests/telemetry/test_writer.py                                          @DataDog/apm-core-python

@mabdinur mabdinur force-pushed the munir/collect-telemetry-for-otel-envs branch from 438834b to f0d301f Compare November 11, 2024 20:08
@mabdinur mabdinur changed the title otel: collect telemetry for otel configurations chore(otel): collect telemetry for otel configurations Nov 11, 2024
@mabdinur mabdinur force-pushed the munir/collect-telemetry-for-otel-envs branch from f0d301f to 4c33030 Compare November 11, 2024 20:27
@pr-commenter
Copy link

pr-commenter bot commented Nov 11, 2024

Benchmarks

Benchmark execution time: 2024-11-15 01:41:01

Comparing candidate commit 39e924b in PR branch munir/collect-telemetry-for-otel-envs with baseline commit 4f7052e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 12, 2024

Datadog Report

Branch report: munir/collect-telemetry-for-otel-envs
Commit report: 39e924b
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 21m 33.66s Total duration (15m 13.56s time saved)

@mabdinur mabdinur marked this pull request as ready for review November 13, 2024 20:06
@mabdinur mabdinur requested review from a team as code owners November 13, 2024 20:06
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 14, 2024
@mabdinur mabdinur force-pushed the munir/collect-telemetry-for-otel-envs branch from 2591f68 to 3de7e3e Compare November 14, 2024 17:22
@mabdinur mabdinur requested a review from a team as a code owner November 14, 2024 17:22
@mabdinur mabdinur force-pushed the munir/collect-telemetry-for-otel-envs branch from 3de7e3e to f803a3c Compare November 14, 2024 17:49
@mabdinur mabdinur force-pushed the munir/collect-telemetry-for-otel-envs branch from 2f8d6b2 to 39e924b Compare November 15, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant