Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pyramid flaky test #11369

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Nov 12, 2024

The pyramid test flaky marker was set to Jan 2024 so it is expired by now.

While looking at the failed pipelines, example: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/703862626

One of the reasons it fails is because there's a new base service name and it is no longer blank:

meta mismatch on '_dd.base_service': got 'tests.contrib.pyramid.app' which does not match expected ''.

Related to #11274

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/pyramid/test_pyramid.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.pyramid.test_pyramid.test_simple_pyramid_app_endpoint[ddtrace-run_python_tests_contrib_pyramid_app_app.py].json  @DataDog/apm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: wantsui/fix-failed-pyramid-test
Commit report: 8071433
Test service: dd-trace-py

✅ 0 Failed, 1286 Passed, 0 Skipped, 28m 26.63s Total duration (7m 32.11s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2024

Benchmarks

Benchmark execution time: 2024-11-12 19:47:32

Comparing candidate commit 8071433 in PR branch wantsui/fix-failed-pyramid-test with baseline commit 9e7acd0 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 387 metrics, 2 unstable metrics.

scenario:iast_aspects-rsplit_aspect

  • 🟩 execution_time [-184.698ns; -158.806ns] or [-10.120%; -8.701%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants