Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix codespell errors in changelog #11378

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Nov 13, 2024

Fix two codespell errors in the changelog. These pre-existing errors were blocking new release note generation after enforcing stricter codespell checks.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@quinna-h quinna-h requested a review from a team as a code owner November 13, 2024 14:57
Copy link
Contributor

CODEOWNERS have been resolved as:

CHANGELOG.md                                                            @DataDog/apm-python

@quinna-h quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 13, 2024
@quinna-h quinna-h enabled auto-merge (squash) November 13, 2024 14:59
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: fix-codespell-changelog
Commit report: d5906f1
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 21m 19.87s Total duration (15m 26.6s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-13 15:37:32

Comparing candidate commit d5906f1 in PR branch fix-codespell-changelog with baseline commit 48e8952 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@quinna-h quinna-h merged commit b18a73c into main Nov 13, 2024
663 of 665 checks passed
@quinna-h quinna-h deleted the fix-codespell-changelog branch November 13, 2024 15:59
quinna-h added a commit that referenced this pull request Nov 13, 2024
Fix two codespell errors in the changelog. These pre-existing errors
were blocking new release note generation after enforcing stricter
codespell checks.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants