Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extend flaky until timestamp for grpc #11399

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Nov 13, 2024

As part of #11274, the previous until timestamp for grpc was Oct 2024 which has already passed. Unless anyone knows about ipv6 support, this PR extends the timestamp until Jan 2025 to buy some more time.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@wantsui wantsui requested review from a team as code owners November 13, 2024 21:39
@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 13, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/grpc/test_grpc.py                                         @DataDog/apm-idm-python @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: wantsui/extend-grpc-flaky-time
Commit report: c974f76
Test service: dd-trace-py

✅ 0 Failed, 607 Passed, 679 Skipped, 19m 2.07s Total duration (17m 45.06s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-14 15:37:52

Comparing candidate commit 0b75d5b in PR branch wantsui/extend-grpc-flaky-time with baseline commit ef58a6b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 328 metrics, 2 unstable metrics.

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future improvement, only skip this test in GitLab so it can still run locally, or if we moved it somewhere else it will start to run and pass again.

Not needed to make that change here, just documenting the idea for the future if we liked it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants