-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extend flaky until
timestamp for grpc
#11399
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 607 Passed, 679 Skipped, 19m 2.07s Total duration (17m 45.06s time saved) |
BenchmarksBenchmark execution time: 2024-11-14 15:37:52 Comparing candidate commit 0b75d5b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 328 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future improvement, only skip this test in GitLab so it can still run locally, or if we moved it somewhere else it will start to run and pass again.
Not needed to make that change here, just documenting the idea for the future if we liked it.
As part of #11274, the previous
until
timestamp for grpc was Oct 2024 which has already passed. Unless anyone knows about ipv6 support, this PR extends the timestamp until Jan 2025 to buy some more time.Checklist
Reviewer Checklist