Nicole cybul/flaky test investigation3 #13265
Conversation
This reverts commit 80ee6c6.
|
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| ) | ||
|
|
||
| @staticmethod | ||
| def _extract_llmobs_metrics(resp: Any) -> Dict[str, Any]: |
There was a problem hiding this comment.
🟠 Code Quality Violation
do not use Any, use a concrete type (...read more)
Use the Any type very carefully. Most of the time, the Any type is used because we do not know exactly what type is being used. If you want to specify that a value can be of any type, use object instead of Any.
Learn More
| @@ -284,6 +292,187 @@ def get_messages_from_converse_content(role: str, content: list): | |||
| return messages | |||
|
|
|||
|
|
|||
| def openai_set_meta_tags_from_completion(span: Span, kwargs: Dict[str, Any], completions: Any) -> None: | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
do not use Any, use a concrete type (...read more)
Use the Any type very carefully. Most of the time, the Any type is used because we do not know exactly what type is being used. If you want to specify that a value can be of any type, use object instead of Any.
Learn More
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 234 ± 3 ms. The average import time from base is: 234 ± 2 ms. The import time difference between this PR and base is: -0.1 ± 0.1 ms. The difference is not statistically significant (z = -1.14). Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-24 15:45:54 Comparing candidate commit a6d8500 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 499 metrics, 8 unstable metrics. scenario:iast_aspects-format_map_aspect
|
Checklist
Reviewer Checklist