-
Notifications
You must be signed in to change notification settings - Fork 431
fix(iast): avoid excessive filtering of stacktrace locations #13272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 236 ± 4 ms. The average import time from base is: 243 ± 4 ms. The import time difference between this PR and base is: -6.8 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-29 16:17:33 Comparing candidate commit 4eec4ef in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 497 metrics, 9 unstable metrics. scenario:iast_aspects-format_map_aspect
scenario:telemetryaddmetric-1-distribution-metric-1-times
|
0a215f0
to
afe4076
Compare
Current stacktrace filtering code returned no location if all frames are outside the current working directory or in site-packages. This often happens in the following scenarios:
In these cases, vulnerabilities were being dropped. The fix includes:
<template>
or anything starting with<
), and not in the stdlib path (but potentially in the purelib path) is found and saved as a backup frame, if any. If none is found, no location is returned.In practice, this means that vulnerabilities found in site-packages, with no other relevant frame, will be reported.
APPSEC-57414
Checklist
Reviewer Checklist