Skip to content

chore(tracing): add additional debug logging to APM_TRACING rc callback #14446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

chore(tracing): add additional debug logging to APM_TRACING rc callback #14446

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fd104d
chore(tracing): add additional debug logging to APM_TRACING rc callback
brettlangdon Aug 28, 2025
a17ea9d
Apply suggestion from @brettlangdon
brettlangdon Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ddtrace/internal/remoteconfig/products/apm_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,26 @@
def _rc_callback(payloads: t.Sequence[Payload]) -> None:
for payload in payloads:
if payload.metadata is None or (content := payload.content) is None:
log.debug("ignoring invalid APM Tracing remote config payload")
continue

if (service_target := t.cast(t.Optional[dict], content.get("service_target"))) is not None:
if (service := t.cast(str, service_target.get("service"))) is not None and service != config.service:
if (
service := t.cast(t.Optional[str], service_target.get("service"))
) is not None and service != config.service:
log.debug("ignoring APM Tracing remote config payload for service: %r != %r", service, config.service)
continue

if (env := t.cast(str, service_target.get("env"))) is not None and env != config.env:
log.debug("ignoring APM Tracing remote config payload for env: %r != %r", env, config.env)
continue
else:
log.debug("APM Tracing remote config payload has no service_target, accepting")

if (lib_config := t.cast(dict, content.get("lib_config"))) is not None:
dispatch("apm-tracing.rc", (lib_config, config))
else:
log.debug("ignoring invalid APM Tracing remote config payload with no lib_config")


class APMTracingAdapter(PubSub):
Expand Down
Loading