-
Notifications
You must be signed in to change notification settings - Fork 455
chore(celery): refactor test_task_chain_task_call_task to use snapshots instead #14452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 267 ± 2 ms. The average import time from base is: 269 ± 3 ms. The import time difference between this PR and base is: -1.2 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsCandidate: turn-chained-task-snapshots (b3b7f5f) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
The previous method of comparing against the logs doesn't work anymore because the ddtrace logs don't show up there.
As a result this condition was wrong:
This PR uses snapshots to assert on the number of spans being created instead.
Checklist
Reviewer Checklist