-
Notifications
You must be signed in to change notification settings - Fork 463
chore(llmobs): remove google_generativeai integration #14820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
6d26067
to
9ea5fb7
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 247 ± 6 ms. The average import time from base is: 250 ± 7 ms. The import time difference between this PR and base is: -2.2 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate yunkim/kill-google-generativeai (24ebfa9) with baseline main (cbd2a7d) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.453ms (SLO: <22.300ms -8.3%) vs baseline: -0.2% Memory: ✅ 65.440MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.346ms (SLO: <1.450ms -7.2%) vs baseline: -0.2% Memory: ✅ 64.563MB (SLO: <67.000MB -3.6%) vs baseline: +4.8% ✅ iastTime: ✅ 20.487ms (SLO: <22.250ms -7.9%) vs baseline: -0.2% Memory: ✅ 65.393MB (SLO: <67.000MB -2.4%) vs baseline: +4.7% ✅ profilerTime: ✅ 15.293ms (SLO: <16.550ms -7.6%) vs baseline: +0.4% Memory: ✅ 53.772MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.568ms (SLO: <21.750ms -5.4%) vs baseline: +0.2% Memory: ✅ 65.507MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.139ms (SLO: <28.200ms -7.3%) vs baseline: -0.3% Memory: ✅ 67.564MB (SLO: <69.500MB -2.8%) vs baseline: +5.1% ✅ tracerTime: ✅ 20.492ms (SLO: <21.750ms -5.8%) vs baseline: -0.1% Memory: ✅ 65.544MB (SLO: <67.000MB -2.2%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.111ms (SLO: <23.500ms -5.9%) vs baseline: +0.3% Memory: ✅ 66.762MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ tracer-dont-create-db-spansTime: ✅ 19.326ms (SLO: <21.500ms 📉 -10.1%) vs baseline: -0.3% Memory: ✅ 65.469MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.653ms (SLO: <17.500ms -4.8%) vs baseline: -0.1% Memory: ✅ 65.426MB (SLO: <66.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.532ms (SLO: <21.750ms -5.6%) vs baseline: +0.3% Memory: ✅ 71.346MB (SLO: <72.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.473ms (SLO: <19.650ms -6.0%) vs baseline: +0.2% Memory: ✅ 65.434MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.732ms (SLO: <20.100ms -6.8%) vs baseline: -0.2% Memory: ✅ 65.288MB (SLO: <67.000MB -2.6%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.225ms (SLO: <21.500ms -5.9%) vs baseline: ~same Memory: ✅ 65.517MB (SLO: <67.000MB -2.2%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.292ms (SLO: <22.000ms -7.8%) vs baseline: -0.4% Memory: ✅ 65.424MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.066ms (SLO: <19.850ms -9.0%) vs baseline: -0.2% Memory: ✅ 65.294MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.190ms (SLO: <19.400ms -6.2%) vs baseline: +0.8% Memory: ✅ 65.235MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 18.067ms (SLO: <19.450ms -7.1%) vs baseline: ~same Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.560ms (SLO: <4.750ms -4.0%) vs baseline: ~same Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.583ms (SLO: <6.750ms -2.5%) vs baseline: +0.4% Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.542ms (SLO: <4.750ms -4.4%) vs baseline: -0.3% Memory: ✅ 61.971MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.865ms (SLO: <2.000ms -6.8%) vs baseline: +0.4% Memory: ✅ 45.515MB (SLO: <47.000MB -3.2%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.862ms (SLO: <2.000ms -6.9%) vs baseline: +0.2% Memory: ✅ 42.330MB (SLO: <49.000MB 📉 -13.6%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.910ms (SLO: <2.100ms -9.1%) vs baseline: ~same Memory: ✅ 46.458MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.370ms (SLO: <3.650ms -7.7%) vs baseline: -0.3% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.362ms (SLO: <3.650ms -7.9%) vs baseline: +0.4% Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.370ms (SLO: <3.650ms -7.7%) vs baseline: +0.5% Memory: ✅ 58.225MB (SLO: <60.000MB -3.0%) vs baseline: +4.7% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 40.948ms (SLO: <47.150ms 📉 -13.2%) vs baseline: +0.5% Memory: ✅ 44.185MB (SLO: <47.000MB -6.0%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 321.427ms (SLO: <344.800ms -6.8%) vs baseline: +1.2% Memory: ✅ 616.681MB (SLO: <630.000MB -2.1%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 285.691ms (SLO: <314.000ms -9.0%) vs baseline: -0.4% Memory: ✅ 619.528MB (SLO: <630.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ get-contextTime: ✅ 82.806ms (SLO: <92.350ms 📉 -10.3%) vs baseline: +2.6% Memory: ✅ 39.755MB (SLO: <46.500MB 📉 -14.5%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 38.373ms (SLO: <44.500ms 📉 -13.8%) vs baseline: ~same Memory: ✅ 43.527MB (SLO: <47.500MB -8.4%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 58.203ms (SLO: <67.650ms 📉 -14.0%) vs baseline: -0.1% Memory: ✅ 40.130MB (SLO: <47.000MB 📉 -14.6%) vs baseline: +4.9% ✅ set-statusTime: ✅ 44.703ms (SLO: <50.400ms 📉 -11.3%) vs baseline: +1.2% Memory: ✅ 43.566MB (SLO: <47.000MB -7.3%) vs baseline: +5.1% ✅ startTime: ✅ 37.580ms (SLO: <43.450ms 📉 -13.5%) vs baseline: -0.4% Memory: ✅ 43.596MB (SLO: <47.000MB -7.2%) vs baseline: +4.9% ✅ start-finishTime: ✅ 84.229ms (SLO: <88.000ms -4.3%) vs baseline: +1.6% Memory: ✅ 34.603MB (SLO: <46.500MB 📉 -25.6%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 84.284ms (SLO: <89.000ms -5.3%) vs baseline: +0.4% Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +4.9% ✅ update-nameTime: ✅ 39.333ms (SLO: <45.150ms 📉 -12.9%) vs baseline: +0.7% Memory: ✅ 43.955MB (SLO: <47.000MB -6.5%) vs baseline: +4.9% 🟡 span - 26/26✅ add-eventTime: ✅ 20.929ms (SLO: <22.500ms -7.0%) vs baseline: +2.5% Memory: ✅ 49.671MB (SLO: <53.000MB -6.3%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 90.380ms (SLO: <93.500ms -3.3%) vs baseline: +0.3% Memory: ✅ 690.622MB (SLO: <961.000MB 📉 -28.1%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 147.801ms (SLO: <155.000ms -4.6%) vs baseline: -0.2% Memory: ✅ 690.571MB (SLO: <962.500MB 📉 -28.3%) vs baseline: +4.9% ✅ get-contextTime: ✅ 19.037ms (SLO: <20.500ms -7.1%) vs baseline: +1.0% Memory: ✅ 48.325MB (SLO: <53.000MB -8.8%) vs baseline: +4.6% ✅ is-recordingTime: ✅ 19.244ms (SLO: <20.500ms -6.1%) vs baseline: +0.3% Memory: ✅ 48.414MB (SLO: <53.000MB -8.7%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 38.496ms (SLO: <40.000ms -3.8%) vs baseline: +2.5% Memory: ✅ 42.473MB (SLO: <53.000MB 📉 -19.9%) vs baseline: +4.9% ✅ set-statusTime: ✅ 20.794ms (SLO: <22.000ms -5.5%) vs baseline: ~same Memory: ✅ 48.409MB (SLO: <53.000MB -8.7%) vs baseline: +4.9% ✅ startTime: ✅ 19.240ms (SLO: <20.500ms -6.1%) vs baseline: +2.8% Memory: ✅ 48.455MB (SLO: <53.000MB -8.6%) vs baseline: +4.8% ✅ start-finishTime: ✅ 51.939ms (SLO: <52.500ms 🟡 -1.1%) vs baseline: +1.6% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 53.331ms (SLO: <54.500ms -2.1%) vs baseline: +1.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ start-finish-traceid128Time: ✅ 55.829ms (SLO: <56.000ms 🟡 -0.3%) vs baseline: +1.9% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.6% ✅ start-traceid128Time: ✅ 19.168ms (SLO: <22.500ms 📉 -14.8%) vs baseline: ~same Memory: ✅ 48.381MB (SLO: <53.000MB -8.7%) vs baseline: +4.7% ✅ update-nameTime: ✅ 19.346ms (SLO: <22.000ms 📉 -12.1%) vs baseline: +0.5% Memory: ✅ 49.089MB (SLO: <53.000MB -7.4%) vs baseline: +4.6%
|
MLOB-4040
Description
Removes the google_generativeai integration. This is end of life and replaced by the google_genai library and integration, as recommended by google's official genai documentation. This is part of our ddtrace 4.0 release.