-
Notifications
You must be signed in to change notification settings - Fork 469
chore(profiling): rename profile-v2 test suites to profile #15328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: taegyunkim/prof-12836-test-cleanup
Are you sure you want to change the base?
chore(profiling): rename profile-v2 test suites to profile #15328
Conversation
|
|
| Venv( | ||
| name="profile-diff", | ||
| command="python scripts/diff.py {cmdargs}", | ||
| pys="3", | ||
| pkgs={ | ||
| "austin-python": "~=1.0", | ||
| "rich": latest, | ||
| }, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@P403n1x87 don't think this is used anywhere, so deleting...
this seems to be picked up when pattern:profile is used in the suitespec
scripts/diff.py is used by django-simple and flask-simple diff benchmarks
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 3 ms. The average import time from base is: 257 ± 3 ms. The import time difference between this PR and base is: -5.7 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate taegyunkim/prof-12836-suite-cleanup (40e0706) with baseline taegyunkim/prof-12836-test-cleanup (dbcdc56) 🟡 Near SLO Breach (2 suites)🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.299ms (SLO: <47.150ms 📉 -18.8%) vs baseline: -0.2% Memory: ✅ 38.915MB (SLO: <47.000MB 📉 -17.2%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 257.064ms (SLO: <344.800ms 📉 -25.4%) vs baseline: +0.2% Memory: ✅ 43.254MB (SLO: <47.500MB -8.9%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 314.963ms (SLO: <321.000ms 🟡 -1.9%) vs baseline: -0.4% Memory: ✅ 43.313MB (SLO: <47.500MB -8.8%) vs baseline: +5.0% ✅ get-contextTime: ✅ 78.778ms (SLO: <92.350ms 📉 -14.7%) vs baseline: +0.6% Memory: ✅ 39.243MB (SLO: <46.500MB 📉 -15.6%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 36.064ms (SLO: <44.500ms 📉 -19.0%) vs baseline: -0.2% Memory: ✅ 38.782MB (SLO: <47.500MB 📉 -18.4%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 57.000ms (SLO: <67.650ms 📉 -15.7%) vs baseline: -0.2% Memory: ✅ 39.429MB (SLO: <47.000MB 📉 -16.1%) vs baseline: +4.8% ✅ set-statusTime: ✅ 42.546ms (SLO: <50.400ms 📉 -15.6%) vs baseline: +0.4% Memory: ✅ 38.771MB (SLO: <47.000MB 📉 -17.5%) vs baseline: +4.6% ✅ startTime: ✅ 35.358ms (SLO: <43.450ms 📉 -18.6%) vs baseline: +0.2% Memory: ✅ 38.889MB (SLO: <47.000MB 📉 -17.3%) vs baseline: +4.9% ✅ start-finishTime: ✅ 82.036ms (SLO: <88.000ms -6.8%) vs baseline: +0.4% Memory: ✅ 36.628MB (SLO: <46.500MB 📉 -21.2%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 83.647ms (SLO: <89.000ms -6.0%) vs baseline: +0.6% Memory: ✅ 36.608MB (SLO: <46.500MB 📉 -21.3%) vs baseline: +4.6% ✅ update-nameTime: ✅ 36.802ms (SLO: <45.150ms 📉 -18.5%) vs baseline: +0.3% Memory: ✅ 38.892MB (SLO: <47.000MB 📉 -17.3%) vs baseline: +4.8% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.921µs (SLO: <20.000µs 📉 -85.4%) vs baseline: -0.3% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 199.021µs (SLO: <220.000µs -9.5%) vs baseline: +0.4% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.361µs (SLO: <20.000µs 📉 -83.2%) vs baseline: +1.4% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.359µs (SLO: <220.000µs 🟡 -1.7%) vs baseline: -0.5% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.175µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.3% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.737µs (SLO: <150.000µs -8.8%) vs baseline: -0.2% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.8% ✅ 1-rate-metric-1-timesTime: ✅ 3.043µs (SLO: <20.000µs 📉 -84.8%) vs baseline: -1.0% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 211.504µs (SLO: <250.000µs 📉 -15.4%) vs baseline: -0.3% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.5% ✅ 100-count-metrics-100-timesTime: ✅ 19.817ms (SLO: <22.000ms -9.9%) vs baseline: -1.1% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.249ms (SLO: <2.300ms -2.2%) vs baseline: -2.0% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.414ms (SLO: <1.550ms -8.8%) vs baseline: +0.6% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.192ms (SLO: <2.550ms 📉 -14.0%) vs baseline: ~same Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.660µs (SLO: <20.000µs 📉 -76.7%) vs baseline: +0.5% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 175.807µs (SLO: <250.000µs 📉 -29.7%) vs baseline: -0.5% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.113ms (SLO: <2.500ms 📉 -15.5%) vs baseline: -0.5% Memory: ✅ 35.271MB (SLO: <36.500MB -3.4%) vs baseline: +4.7%
|
…f-12836-suite-cleanup
Description
Testing
Risks
Additional Notes