Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f47df04
add comment explaining why we don't use when: always
igoragoli Nov 25, 2025
54a2df8
add slo change detection
igoragoli Nov 25, 2025
edf2787
improve comment explaining why we don't use when: always for SLO check
igoragoli Nov 26, 2025
841695d
add explicit when: on_success
igoragoli Nov 26, 2025
cacc6a6
add .check-slo-breaches template
igoragoli Nov 26, 2025
9800190
remove tags, add comment to remove image
igoragoli Nov 26, 2025
26c6385
test SLO change detection
igoragoli Nov 26, 2025
ea682f3
trigger ci
igoragoli Nov 26, 2025
e35062e
test if check-slo-breaches is interruptible
igoragoli Nov 26, 2025
38e3f73
test if check-slo-breaches is interruptible
igoragoli Nov 26, 2025
8e17ccf
test if check-slo-breaches is interruptible
igoragoli Nov 26, 2025
1ec0dab
trigger ci
igoragoli Nov 26, 2025
4d5b8c3
workflow auto_cancel: on_new_commit on microbenchmarks
igoragoli Nov 26, 2025
348ff29
trigger ci
igoragoli Nov 26, 2025
4c82654
workflow auto_cancel: on_new_commit on macrobenchmarks
igoragoli Nov 26, 2025
7424109
revert changes made for testing
igoragoli Nov 26, 2025
4e75a35
complete TODO for removing the image key on check-slo-breaches
igoragoli Nov 27, 2025
3a0d6dd
remove microbenchmarks' when: on_success since it's the default behavior
igoragoli Nov 27, 2025
2c45e11
Merge branch 'main' into augusto/apmsp-2373.update-slo-check
igoragoli Dec 1, 2025
9c9ca76
Merge branch 'main' into augusto/apmsp-2373.update-slo-check
igoragoli Dec 2, 2025
eb7e477
Merge branch 'main' into augusto/apmsp-2373.update-slo-check
emmettbutler Dec 2, 2025
b5f4e6e
Merge branch 'main' into augusto/apmsp-2373.update-slo-check
igoragoli Dec 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitlab/benchmarks/macrobenchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ include:
- project: 'DataDog/benchmarking-platform-tools'
file: 'images/templates/gitlab/check-slo-breaches.template.yml'

workflow:
auto_cancel:
on_new_commit: interruptible

variables:
MACROBENCHMARKS_CI_IMAGE: 486234852809.dkr.ecr.us-east-1.amazonaws.com/ci/benchmarking-platform:dd-trace-py-macrobenchmarks

Expand Down
23 changes: 17 additions & 6 deletions .gitlab/benchmarks/microbenchmarks.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
include:
- project: 'DataDog/benchmarking-platform-tools'
file: 'images/templates/gitlab/check-slo-breaches.template.yml'

workflow:
auto_cancel:
on_new_commit: interruptible

stages:
- build
- test
Expand All @@ -14,7 +22,6 @@ variables:

.benchmarks:
stage: test
when: on_success
tags: ["runner:apm-k8s-tweaked-metal"]
image: $MICROBENCHMARKS_CI_IMAGE
rules:
Expand Down Expand Up @@ -203,17 +210,21 @@ benchmarks-pr-comment:
UPSTREAM_BRANCH: $CI_COMMIT_REF_NAME # The branch or tag name for which project is built.
UPSTREAM_COMMIT_SHA: $CI_COMMIT_SHA # The commit revision the project is built for.

# Unlike pre-release SLO checks that run unconditionally (which have
# "when: always"), this PR-level check runs only if benchmarks succeed.
# Since benchmark failures block the PR directly, this job blocks the PR if
# benchmarks succeed but there are SLO breaches.
check-slo-breaches:
extends: .check-slo-breaches
stage: gate
tags: ["arch:amd64"]
image: registry.ddbuild.io/images/benchmarking-platform-tools-ubuntu:03c08c0
artifacts:
name: "artifacts"
when: always
paths:
- artifacts/
- reports/
expire_in: 3 months
script:
- export ARTIFACTS_DIR="$(pwd)/reports/"
- bp-runner .gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml
variables:
DDOCTOSTS_POLICY: "gitlab.github-access.read"
ARTIFACTS_DIR: "reports/"
SLO_FILE: ".gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.yml"
Loading