-
Notifications
You must be signed in to change notification settings - Fork 469
feat(crashtracking): dogfood draft pr #15425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 3 ms. The average import time from base is: 252 ± 4 ms. The import time difference between this PR and base is: -3.4 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate gyuheon0h/dual-upload-dogfood (637c110) with baseline main (2cfb922) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30✅ 1-count-metric-1-timesTime: ✅ 3.526µs (SLO: <20.000µs 📉 -82.4%) vs baseline: 📈 +19.6% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ 1-count-metrics-100-timesTime: ✅ 208.286µs (SLO: <220.000µs -5.3%) vs baseline: +4.2% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.296µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +0.3% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 221.469µs (SLO: <230.000µs -3.7%) vs baseline: +1.6% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.8% ✅ 1-gauge-metric-1-timesTime: ✅ 2.203µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +1.5% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.509µs (SLO: <150.000µs -8.3%) vs baseline: +1.0% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.118µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +1.7% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 222.507µs (SLO: <250.000µs 📉 -11.0%) vs baseline: +3.7% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 21.114ms (SLO: <22.000ms -4.0%) vs baseline: +2.7% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.9% ❌ 100-distribution-metrics-100-timesTime: ❌ 2.317ms (SLO: <2.300ms +0.7%) vs baseline: +1.1% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.420ms (SLO: <1.550ms -8.4%) vs baseline: +1.0% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.287ms (SLO: <2.550ms 📉 -10.3%) vs baseline: +2.4% Memory: ✅ 35.016MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 4.517µs (SLO: <20.000µs 📉 -77.4%) vs baseline: -1.1% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +5.2% ✅ flush-100-metricsTime: ✅ 176.295µs (SLO: <250.000µs 📉 -29.5%) vs baseline: +0.2% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.188ms (SLO: <2.500ms 📉 -12.5%) vs baseline: ~same Memory: ✅ 35.920MB (SLO: <36.500MB 🟡 -1.6%) vs baseline: +4.7% 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.260µs (SLO: <10.000µs 📉 -47.4%) vs baseline: 📈 +28.0% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 1.083µs (SLO: <10.000µs 📉 -89.2%) vs baseline: ~same Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.150µs (SLO: <10.000µs 📉 -38.5%) vs baseline: -0.2% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.268µs (SLO: <10.000µs 📉 -77.3%) vs baseline: -0.8% Memory: ✅ 40.069MB (SLO: <41.000MB -2.3%) vs baseline: +4.5% ✅ ospathnormcase_aspectTime: ✅ 3.386µs (SLO: <10.000µs 📉 -66.1%) vs baseline: -0.7% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 0.566µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.4% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.742µs (SLO: <10.000µs 📉 -52.6%) vs baseline: -0.8% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 1.585µs (SLO: <10.000µs 📉 -84.1%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 3.649µs (SLO: <10.000µs 📉 -63.5%) vs baseline: +0.4% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.694µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -1.3% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.487µs (SLO: <10.000µs 📉 -55.1%) vs baseline: +0.1% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathsplitext_noaspectTime: ✅ 1.380µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -1.0% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.6% 🟡 Near SLO Breach (17 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|

Description
Testing
Risks
Additional Notes