-
Notifications
You must be signed in to change notification settings - Fork 468
chore(ci_visibility): playwright integration poc #15448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
…l network interfaces Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…l network interfaces Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 260 ± 8 ms. The average import time from base is: 263 ± 7 ms. The import time difference between this PR and base is: -2.5 ± 0.3 ms. Import time breakdownThe following import paths have appeared:
|
Performance SLOsComparing candidate gnufede/playwright-poc (9e2da94) with baseline main (1767176) 📈 Performance Regressions (3 suites)📈 httppropagationinject - 16/16✅ ids_onlyTime: ✅ 22.750µs (SLO: <30.000µs 📉 -24.2%) vs baseline: 📈 +12.5% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ with_allTime: ✅ 27.954µs (SLO: <40.000µs 📉 -30.1%) vs baseline: +4.9% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ with_dd_originTime: ✅ 25.032µs (SLO: <30.000µs 📉 -16.6%) vs baseline: +6.0% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ with_priority_and_originTime: ✅ 24.470µs (SLO: <40.000µs 📉 -38.8%) vs baseline: +5.3% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ with_sampling_priorityTime: ✅ 21.332µs (SLO: <30.000µs 📉 -28.9%) vs baseline: +5.4% Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ with_tagsTime: ✅ 26.300µs (SLO: <40.000µs 📉 -34.3%) vs baseline: +5.8% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ with_tags_invalidTime: ✅ 27.561µs (SLO: <40.000µs 📉 -31.1%) vs baseline: +5.0% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ with_tags_max_sizeTime: ✅ 26.724µs (SLO: <40.000µs 📉 -33.2%) vs baseline: +5.6% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.861µs (SLO: <10.000µs 📉 -51.4%) vs baseline: 📈 +23.7% Memory: ✅ 40.383MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.3% ✅ ospathbasename_noaspectTime: ✅ 1.080µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.7% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 5.887µs (SLO: <10.000µs 📉 -41.1%) vs baseline: -1.1% Memory: ✅ 40.442MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 2.259µs (SLO: <10.000µs 📉 -77.4%) vs baseline: -0.5% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathnormcase_aspectTime: ✅ 3.273µs (SLO: <10.000µs 📉 -67.3%) vs baseline: +1.9% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.1% ✅ ospathnormcase_noaspectTime: ✅ 0.567µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.4% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.492µs (SLO: <10.000µs 📉 -55.1%) vs baseline: -1.0% Memory: ✅ 40.383MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 1.581µs (SLO: <10.000µs 📉 -84.2%) vs baseline: +0.5% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.402µs (SLO: <10.000µs 📉 -66.0%) vs baseline: +0.6% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.691µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.2% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.1% ✅ ospathsplitext_aspectTime: ✅ 4.278µs (SLO: <10.000µs 📉 -57.2%) vs baseline: +1.1% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.2% ✅ ospathsplitext_noaspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: -0.1% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.418µs (SLO: <20.000µs 📉 -82.9%) vs baseline: 📈 +17.2% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 199.806µs (SLO: <220.000µs -9.2%) vs baseline: -0.6% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.269µs (SLO: <20.000µs 📉 -83.7%) vs baseline: +0.3% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.926µs (SLO: <230.000µs -6.1%) vs baseline: +1.0% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.179µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.1% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.695µs (SLO: <150.000µs -8.9%) vs baseline: -0.7% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.086µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +0.8% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 214.907µs (SLO: <250.000µs 📉 -14.0%) vs baseline: +0.9% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.4% ✅ 100-count-metrics-100-timesTime: ✅ 20.230ms (SLO: <22.000ms -8.0%) vs baseline: -0.2% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.275ms (SLO: <2.300ms 🟡 -1.1%) vs baseline: +0.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.401ms (SLO: <1.550ms -9.6%) vs baseline: +0.2% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ 100-rate-metrics-100-timesTime: ✅ 2.187ms (SLO: <2.550ms 📉 -14.3%) vs baseline: -0.9% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 4.436µs (SLO: <20.000µs 📉 -77.8%) vs baseline: +0.8% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.2% ✅ flush-100-metricsTime: ✅ 173.576µs (SLO: <250.000µs 📉 -30.6%) vs baseline: -0.4% Memory: ✅ 35.389MB (SLO: <35.500MB 🟡 -0.3%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.176ms (SLO: <2.500ms 📉 -13.0%) vs baseline: -0.1% Memory: ✅ 35.979MB (SLO: <36.500MB 🟡 -1.4%) vs baseline: +4.6% 🟡 Near SLO Breach (18 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
This PR is a POC for a new Playwright integration, adding support for distributed tracing in browser automation tests.
Changes:
New Playwright Integration (
ddtrace/contrib/internal/playwright/)x-datadog-sampling-priority: 114(temporary value for E2E Tests) for test tracesextra_http_headers): For navigation requests (page.goto(), resource loading)fetch(),XMLHttpRequest)E2E Test HTTP Propagation (
ddtrace/propagation/http.py)_is_test_context()function: Detects if current span is part of a test tracetest.type = "test"tagInfrastructure Updates
Testing
New tests added (unit and integration), snapshot tests not yet done.
Risks
Low Risk:
Additional Notes
This is just a POC as part of a product investigation