Skip to content

Conversation

@vitor-de-araujo
Copy link
Contributor

@vitor-de-araujo vitor-de-araujo commented Nov 28, 2025

Description

This PR:

  • Changes HTTP methods to detect and report errors in a cleaner way. Previously we returned a tuple with the response object and response data, but depending on the error (e.g., connection refused), we might not even get a response object, and we would pass on the exception raised by the http.client module instead. Now the BackendConnector request methods return a BackendResult, containing information about the response and any errors that may have happened, even if there is no response.
  • Adds retry logic, based on the reported error types.
  • Adds telemetry for HTTP requests, using the reported error types, request duration and other data. Telemetry uses the telemetry_writer from ddtrace.internal.telemetry.

Telemetry for things besides HTTP requests will be added separately.

Testing

Unit tests.

Risks

None.

Additional Notes

None.

Base automatically changed from vitor-de-araujo/SDTEST-2803/reabsorb-ddtestpy to main December 2, 2025 08:22
@vitor-de-araujo vitor-de-araujo added CI App changelog/no-changelog A changelog entry is not required for this PR. labels Dec 2, 2025
@vitor-de-araujo vitor-de-araujo changed the title chore(ci_visibility): add telemetry to the new plugin (WIP) chore(ci_visibility): add telemetry to the new plugin, part 1 Dec 2, 2025
@vitor-de-araujo vitor-de-araujo marked this pull request as ready for review December 2, 2025 17:13
@vitor-de-araujo vitor-de-araujo requested a review from a team as a code owner December 2, 2025 17:13
@vitor-de-araujo vitor-de-araujo enabled auto-merge (squash) December 2, 2025 17:18
@vitor-de-araujo vitor-de-araujo merged commit e496a4b into main Dec 3, 2025
486 of 489 checks passed
@vitor-de-araujo vitor-de-araujo deleted the vitor-de-araujo/SDTEST-2663/telemetry branch December 3, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. CI App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants