-
Notifications
You must be signed in to change notification settings - Fork 474
perf: replace importlib.metadata usages with faster impl #15721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Performance SLOsComparing candidate taegyunkim/importlib-metadata (8e3d825) with baseline main (9ac98cb) ❌ Test Failures (1 suite)❌ packagespackageforrootmodulemapping - 3/4❌ cache_offTime: ❌ 842.094ms (SLO: <354.300ms 📈 +137.7%) vs baseline: 📈 +146.1% Memory: ✅ 38.222MB (SLO: <43.500MB 📉 -12.1%) vs baseline: -0.4% ✅ cache_onTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.6% Memory: ✅ 37.165MB (SLO: <43.000MB 📉 -13.6%) vs baseline: -2.4% 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 18.026µs (SLO: <20.000µs -9.9%) vs baseline: 📈 +21.4% Memory: ✅ 42.959MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ add_inplace_aspectTime: ✅ 14.829µs (SLO: <20.000µs 📉 -25.9%) vs baseline: -0.6% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.338µs (SLO: <10.000µs 📉 -96.6%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 0.544µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.9% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 17.935µs (SLO: <30.000µs 📉 -40.2%) vs baseline: -0.4% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 23.816µs (SLO: <30.000µs 📉 -20.6%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 2.738µs (SLO: <10.000µs 📉 -72.6%) vs baseline: +0.3% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ bytearray_noaspectTime: ✅ 1.466µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.8% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 16.662µs (SLO: <20.000µs 📉 -16.7%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.5% ✅ bytes_noaspectTime: ✅ 1.429µs (SLO: <10.000µs 📉 -85.7%) vs baseline: +0.7% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 55.905µs (SLO: <70.000µs 📉 -20.1%) vs baseline: +0.4% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 3.253µs (SLO: <10.000µs 📉 -67.5%) vs baseline: ~same Memory: ✅ 43.096MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.1% ✅ capitalize_aspectTime: ✅ 14.700µs (SLO: <20.000µs 📉 -26.5%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 2.579µs (SLO: <10.000µs 📉 -74.2%) vs baseline: -0.6% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 14.684µs (SLO: <20.000µs 📉 -26.6%) vs baseline: +0.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 3.156µs (SLO: <10.000µs 📉 -68.4%) vs baseline: -0.9% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 15.676µs (SLO: <30.000µs 📉 -47.7%) vs baseline: +0.9% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 1.597µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -1.1% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 18.261µs (SLO: <30.000µs 📉 -39.1%) vs baseline: 📈 +22.8% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 1.476µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -1.3% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 170.984µs (SLO: <200.000µs 📉 -14.5%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <43.250MB 🟡 -0.4%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 190.890µs (SLO: <200.000µs -4.6%) vs baseline: ~same Memory: ✅ 43.155MB (SLO: <43.500MB 🟡 -0.8%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 3.855µs (SLO: <10.000µs 📉 -61.5%) vs baseline: +1.1% Memory: ✅ 42.959MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ format_noaspectTime: ✅ 3.137µs (SLO: <10.000µs 📉 -68.6%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 15.261µs (SLO: <20.000µs 📉 -23.7%) vs baseline: -0.6% Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.3% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 17.054µs (SLO: <20.000µs 📉 -14.7%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 1.537µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -1.5% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 20.846µs (SLO: <30.000µs 📉 -30.5%) vs baseline: +0.1% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.1% ✅ ljust_noaspectTime: ✅ 2.708µs (SLO: <10.000µs 📉 -72.9%) vs baseline: +0.9% Memory: ✅ 42.920MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 17.836µs (SLO: <30.000µs 📉 -40.5%) vs baseline: -0.3% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.2% ✅ lower_noaspectTime: ✅ 2.428µs (SLO: <10.000µs 📉 -75.7%) vs baseline: -0.8% Memory: ✅ 42.959MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 17.649µs (SLO: <20.000µs 📉 -11.8%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 1.856µs (SLO: <10.000µs 📉 -81.4%) vs baseline: -0.5% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 165.726µs (SLO: <200.000µs 📉 -17.1%) vs baseline: -0.2% Memory: ✅ 43.214MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 179.537µs (SLO: <200.000µs 📉 -10.2%) vs baseline: +2.6% Memory: ✅ 43.234MB (SLO: <43.500MB 🟡 -0.6%) vs baseline: +5.1% ✅ modulo_aspect_for_bytesTime: ✅ 168.323µs (SLO: <200.000µs 📉 -15.8%) vs baseline: ~same Memory: ✅ 43.214MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.441µs (SLO: <200.000µs 📉 -13.8%) vs baseline: +0.1% Memory: ✅ 43.116MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 3.674µs (SLO: <10.000µs 📉 -63.3%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 211.881µs (SLO: <300.000µs 📉 -29.4%) vs baseline: -0.1% Memory: ✅ 43.155MB (SLO: <44.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 2.907µs (SLO: <10.000µs 📉 -70.9%) vs baseline: ~same Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.5% ✅ repr_aspectTime: ✅ 1.423µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +1.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ repr_noaspectTime: ✅ 0.525µs (SLO: <10.000µs 📉 -94.8%) vs baseline: -0.8% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.1% ✅ rstrip_aspectTime: ✅ 19.069µs (SLO: <30.000µs 📉 -36.4%) vs baseline: +0.1% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 2.044µs (SLO: <10.000µs 📉 -79.6%) vs baseline: +6.0% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 15.862µs (SLO: <20.000µs 📉 -20.7%) vs baseline: -0.3% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.3% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ stringio_aspectTime: ✅ 53.865µs (SLO: <80.000µs 📉 -32.7%) vs baseline: -0.5% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 3.602µs (SLO: <10.000µs 📉 -64.0%) vs baseline: -1.1% Memory: ✅ 43.116MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.3% ✅ strip_aspectTime: ✅ 17.593µs (SLO: <20.000µs 📉 -12.0%) vs baseline: -1.3% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 1.872µs (SLO: <10.000µs 📉 -81.3%) vs baseline: -1.5% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 18.298µs (SLO: <30.000µs 📉 -39.0%) vs baseline: -1.6% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 2.791µs (SLO: <10.000µs 📉 -72.1%) vs baseline: -0.6% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ title_aspectTime: ✅ 18.203µs (SLO: <20.000µs -9.0%) vs baseline: -0.6% Memory: ✅ 42.979MB (SLO: <43.000MB 🟡 ~same) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 2.651µs (SLO: <10.000µs 📉 -73.5%) vs baseline: -1.1% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 24.327µs (SLO: <30.000µs 📉 -18.9%) vs baseline: 📈 +18.0% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 4.303µs (SLO: <10.000µs 📉 -57.0%) vs baseline: -0.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 17.965µs (SLO: <30.000µs 📉 -40.1%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.1% ✅ upper_noaspectTime: ✅ 2.427µs (SLO: <10.000µs 📉 -75.7%) vs baseline: -0.4% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.177µs (SLO: <10.000µs 📉 -48.2%) vs baseline: 📈 +22.5% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 4.271µs (SLO: <10.000µs 📉 -57.3%) vs baseline: +0.3% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.243µs (SLO: <10.000µs 📉 -37.6%) vs baseline: +0.1% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 6.299µs (SLO: <10.000µs 📉 -37.0%) vs baseline: -0.2% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.551µs (SLO: <10.000µs 📉 -64.5%) vs baseline: +0.2% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 3.603µs (SLO: <10.000µs 📉 -64.0%) vs baseline: -0.8% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.903µs (SLO: <10.000µs 📉 -51.0%) vs baseline: +0.3% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +5.0% ✅ ospathsplit_noaspectTime: ✅ 4.973µs (SLO: <10.000µs 📉 -50.3%) vs baseline: -0.5% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.736µs (SLO: <10.000µs 📉 -62.6%) vs baseline: -1.1% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.752µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -0.2% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 4.615µs (SLO: <10.000µs 📉 -53.9%) vs baseline: +0.3% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.2% ✅ ospathsplitext_noaspectTime: ✅ 4.633µs (SLO: <10.000µs 📉 -53.7%) vs baseline: -0.1% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.364µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +11.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 198.821µs (SLO: <220.000µs -9.6%) vs baseline: -1.2% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.291µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -2.1% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.201µs (SLO: <230.000µs -7.3%) vs baseline: -1.2% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.198µs (SLO: <20.000µs 📉 -89.0%) vs baseline: ~same Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.496µs (SLO: <150.000µs -9.0%) vs baseline: ~same Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.114µs (SLO: <20.000µs 📉 -84.4%) vs baseline: -1.7% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 211.999µs (SLO: <250.000µs 📉 -15.2%) vs baseline: -1.6% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.027ms (SLO: <22.000ms -9.0%) vs baseline: +0.8% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.237ms (SLO: <2.550ms 📉 -12.3%) vs baseline: -0.8% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.397ms (SLO: <1.550ms -9.9%) vs baseline: -0.5% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.187ms (SLO: <2.550ms 📉 -14.2%) vs baseline: +0.3% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ flush-1-metricTime: ✅ 4.576µs (SLO: <20.000µs 📉 -77.1%) vs baseline: ~same Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 172.687µs (SLO: <250.000µs 📉 -30.9%) vs baseline: -0.2% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.168ms (SLO: <2.500ms 📉 -13.3%) vs baseline: -0.5% Memory: ✅ 36.058MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +4.9% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Testing
Risks
Additional Notes