-
Notifications
You must be signed in to change notification settings - Fork 474
chore(profiling): clang-tidy fixes #15734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
5250b6c to
9993bc6
Compare
9993bc6 to
53c2736
Compare
Performance SLOsComparing candidate kowalski/chore-profiling-clang-tidy-fixes (53c2736) with baseline main (efceaad) 📈 Performance Regressions (3 suites)📈 iastaspects - 116/116✅ add_aspectTime: ✅ 18.050µs (SLO: <20.000µs -9.8%) vs baseline: 📈 +21.8% Memory: ✅ 42.920MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 14.813µs (SLO: <20.000µs 📉 -25.9%) vs baseline: -1.2% Memory: ✅ 43.116MB (SLO: <43.250MB 🟡 -0.3%) vs baseline: +5.3% ✅ add_inplace_noaspectTime: ✅ 0.336µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -0.3% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.550µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -0.4% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.0% ✅ bytearray_aspectTime: ✅ 18.019µs (SLO: <30.000µs 📉 -39.9%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 23.953µs (SLO: <30.000µs 📉 -20.2%) vs baseline: +0.4% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytearray_extend_noaspectTime: ✅ 2.741µs (SLO: <10.000µs 📉 -72.6%) vs baseline: ~same Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 1.466µs (SLO: <10.000µs 📉 -85.3%) vs baseline: -0.4% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 16.759µs (SLO: <20.000µs 📉 -16.2%) vs baseline: +1.1% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 1.410µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 55.531µs (SLO: <70.000µs 📉 -20.7%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ bytesio_noaspectTime: ✅ 3.259µs (SLO: <10.000µs 📉 -67.4%) vs baseline: ~same Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.4% ✅ capitalize_aspectTime: ✅ 14.684µs (SLO: <20.000µs 📉 -26.6%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ capitalize_noaspectTime: ✅ 2.589µs (SLO: <10.000µs 📉 -74.1%) vs baseline: -0.5% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 14.712µs (SLO: <20.000µs 📉 -26.4%) vs baseline: +0.1% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ casefold_noaspectTime: ✅ 3.159µs (SLO: <10.000µs 📉 -68.4%) vs baseline: ~same Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.4% ✅ decode_aspectTime: ✅ 15.703µs (SLO: <30.000µs 📉 -47.7%) vs baseline: +0.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 1.601µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.3% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.3% ✅ encode_aspectTime: ✅ 18.286µs (SLO: <30.000µs 📉 -39.0%) vs baseline: 📈 +23.5% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 1.483µs (SLO: <10.000µs 📉 -85.2%) vs baseline: -0.7% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 171.299µs (SLO: <200.000µs 📉 -14.4%) vs baseline: +0.5% Memory: ✅ 43.234MB (SLO: <43.250MB 🟡 ~same) vs baseline: +5.0% ✅ format_map_aspectTime: ✅ 191.354µs (SLO: <200.000µs -4.3%) vs baseline: ~same Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.6% ✅ format_map_noaspectTime: ✅ 3.775µs (SLO: <10.000µs 📉 -62.3%) vs baseline: -1.0% Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 3.142µs (SLO: <10.000µs 📉 -68.6%) vs baseline: -1.2% Memory: ✅ 42.526MB (SLO: <43.250MB 🟡 -1.7%) vs baseline: +3.5% ✅ index_aspectTime: ✅ 15.386µs (SLO: <20.000µs 📉 -23.1%) vs baseline: +0.3% Memory: ✅ 43.096MB (SLO: <43.250MB 🟡 -0.4%) vs baseline: +5.3% ✅ index_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.1% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ join_aspectTime: ✅ 17.135µs (SLO: <20.000µs 📉 -14.3%) vs baseline: +0.2% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ join_noaspectTime: ✅ 1.549µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.4% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.2% ✅ ljust_aspectTime: ✅ 20.981µs (SLO: <30.000µs 📉 -30.1%) vs baseline: +0.4% Memory: ✅ 43.057MB (SLO: <43.250MB 🟡 -0.4%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 2.714µs (SLO: <10.000µs 📉 -72.9%) vs baseline: +0.8% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +3.7% ✅ lower_aspectTime: ✅ 17.951µs (SLO: <30.000µs 📉 -40.2%) vs baseline: +0.1% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 2.440µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +0.6% Memory: ✅ 42.782MB (SLO: <43.250MB 🟡 -1.1%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 17.644µs (SLO: <20.000µs 📉 -11.8%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <43.250MB 🟡 -0.8%) vs baseline: +4.6% ✅ lstrip_noaspectTime: ✅ 1.865µs (SLO: <10.000µs 📉 -81.4%) vs baseline: ~same Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.5% ✅ modulo_aspectTime: ✅ 166.917µs (SLO: <200.000µs 📉 -16.5%) vs baseline: +0.5% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 179.971µs (SLO: <200.000µs 📉 -10.0%) vs baseline: +2.9% Memory: ✅ 43.195MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +5.1% ✅ modulo_aspect_for_bytesTime: ✅ 169.590µs (SLO: <200.000µs 📉 -15.2%) vs baseline: +0.5% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.8% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.759µs (SLO: <200.000µs 📉 -14.1%) vs baseline: -0.5% Memory: ✅ 43.136MB (SLO: <43.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 3.686µs (SLO: <10.000µs 📉 -63.1%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.0% ✅ replace_aspectTime: ✅ 212.182µs (SLO: <300.000µs 📉 -29.3%) vs baseline: +0.3% Memory: ✅ 43.195MB (SLO: <44.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 2.904µs (SLO: <10.000µs 📉 -71.0%) vs baseline: ~same Memory: ✅ 42.821MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.5% ✅ repr_aspectTime: ✅ 1.420µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +0.1% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.523µs (SLO: <10.000µs 📉 -94.8%) vs baseline: -2.0% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.4% ✅ rstrip_aspectTime: ✅ 19.074µs (SLO: <30.000µs 📉 -36.4%) vs baseline: -0.2% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 2.046µs (SLO: <10.000µs 📉 -79.5%) vs baseline: +5.8% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +3.8% ✅ slice_aspectTime: ✅ 15.836µs (SLO: <20.000µs 📉 -20.8%) vs baseline: +0.4% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -1.0% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 54.113µs (SLO: <80.000µs 📉 -32.4%) vs baseline: +0.2% Memory: ✅ 43.077MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.2% ✅ stringio_noaspectTime: ✅ 3.636µs (SLO: <10.000µs 📉 -63.6%) vs baseline: +0.5% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.1% ✅ strip_aspectTime: ✅ 17.746µs (SLO: <20.000µs 📉 -11.3%) vs baseline: +1.0% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 1.857µs (SLO: <10.000µs 📉 -81.4%) vs baseline: +0.8% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.7% ✅ swapcase_aspectTime: ✅ 18.557µs (SLO: <30.000µs 📉 -38.1%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 2.810µs (SLO: <10.000µs 📉 -71.9%) vs baseline: -0.3% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +3.9% ✅ title_aspectTime: ✅ 18.323µs (SLO: <30.000µs 📉 -38.9%) vs baseline: -0.4% Memory: ✅ 42.959MB (SLO: <43.000MB 🟡 ~same) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 2.685µs (SLO: <10.000µs 📉 -73.2%) vs baseline: -0.2% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.4% ✅ translate_aspectTime: ✅ 24.354µs (SLO: <30.000µs 📉 -18.8%) vs baseline: 📈 +18.6% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 4.337µs (SLO: <10.000µs 📉 -56.6%) vs baseline: -0.4% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 18.065µs (SLO: <30.000µs 📉 -39.8%) vs baseline: +0.7% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.149µs (SLO: <10.000µs 📉 -48.5%) vs baseline: 📈 +20.8% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 4.329µs (SLO: <10.000µs 📉 -56.7%) vs baseline: ~same Memory: ✅ 41.327MB (SLO: <43.500MB -5.0%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 6.228µs (SLO: <10.000µs 📉 -37.7%) vs baseline: -0.4% Memory: ✅ 41.504MB (SLO: <43.500MB -4.6%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 6.293µs (SLO: <10.000µs 📉 -37.1%) vs baseline: -0.3% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.584µs (SLO: <10.000µs 📉 -64.2%) vs baseline: +0.7% Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.5% ✅ ospathnormcase_noaspectTime: ✅ 3.604µs (SLO: <10.000µs 📉 -64.0%) vs baseline: +0.4% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.901µs (SLO: <10.000µs 📉 -51.0%) vs baseline: -0.2% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 4.992µs (SLO: <10.000µs 📉 -50.1%) vs baseline: -1.2% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.767µs (SLO: <10.000µs 📉 -62.3%) vs baseline: +0.6% Memory: ✅ 41.524MB (SLO: <43.500MB -4.5%) vs baseline: +5.3% ✅ ospathsplitdrive_noaspectTime: ✅ 0.752µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -0.7% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.669µs (SLO: <10.000µs 📉 -53.3%) vs baseline: +1.0% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 4.680µs (SLO: <10.000µs 📉 -53.2%) vs baseline: +1.3% Memory: ✅ 41.445MB (SLO: <43.500MB -4.7%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.379µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +13.3% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 1-count-metrics-100-timesTime: ✅ 198.811µs (SLO: <220.000µs -9.6%) vs baseline: -1.7% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.292µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -1.0% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.453µs (SLO: <230.000µs -6.8%) vs baseline: -0.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.181µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.6% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.523µs (SLO: <150.000µs -9.7%) vs baseline: -0.6% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.117µs (SLO: <20.000µs 📉 -84.4%) vs baseline: -0.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 210.560µs (SLO: <250.000µs 📉 -15.8%) vs baseline: -1.0% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 19.855ms (SLO: <22.000ms -9.7%) vs baseline: ~same Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.3% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.225ms (SLO: <2.550ms 📉 -12.8%) vs baseline: +0.5% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.4% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.399ms (SLO: <1.550ms -9.7%) vs baseline: +0.2% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.187ms (SLO: <2.550ms 📉 -14.2%) vs baseline: +0.4% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.576µs (SLO: <20.000µs 📉 -77.1%) vs baseline: +0.7% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 172.758µs (SLO: <250.000µs 📉 -30.9%) vs baseline: -0.3% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.175ms (SLO: <2.500ms 📉 -13.0%) vs baseline: +0.6% Memory: ✅ 36.137MB (SLO: <36.500MB 🟡 -1.0%) vs baseline: +5.0% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Testing
Risks
Additional Notes