-
Notifications
You must be signed in to change notification settings - Fork 474
ci: implement check_requirements_lockfiles in gitlab [APMLP-800] #15738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm
Performance SLOsComparing candidate emmett.butler/reqs-lock-glab (671d732) with baseline main (20542e4) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 17.873µs (SLO: <20.000µs 📉 -10.6%) vs baseline: 📈 +19.9% Memory: ✅ 42.880MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +5.3% ✅ add_inplace_aspectTime: ✅ 14.979µs (SLO: <20.000µs 📉 -25.1%) vs baseline: +0.9% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.4% ✅ add_inplace_noaspectTime: ✅ 0.337µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -1.3% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.0% ✅ add_noaspectTime: ✅ 0.549µs (SLO: <10.000µs 📉 -94.5%) vs baseline: +0.7% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 17.973µs (SLO: <30.000µs 📉 -40.1%) vs baseline: ~same Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.5% ✅ bytearray_extend_aspectTime: ✅ 23.735µs (SLO: <30.000µs 📉 -20.9%) vs baseline: ~same Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.5% ✅ bytearray_extend_noaspectTime: ✅ 2.755µs (SLO: <10.000µs 📉 -72.4%) vs baseline: +0.5% Memory: ✅ 42.605MB (SLO: <43.500MB -2.1%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 1.462µs (SLO: <10.000µs 📉 -85.4%) vs baseline: -1.1% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.4% ✅ bytes_aspectTime: ✅ 16.553µs (SLO: <20.000µs 📉 -17.2%) vs baseline: +0.3% Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 1.411µs (SLO: <10.000µs 📉 -85.9%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.2% ✅ bytesio_aspectTime: ✅ 55.234µs (SLO: <70.000µs 📉 -21.1%) vs baseline: -0.3% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 3.264µs (SLO: <10.000µs 📉 -67.4%) vs baseline: -0.5% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 14.589µs (SLO: <20.000µs 📉 -27.1%) vs baseline: ~same Memory: ✅ 42.684MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.0% ✅ capitalize_noaspectTime: ✅ 2.593µs (SLO: <10.000µs 📉 -74.1%) vs baseline: -0.4% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 14.698µs (SLO: <20.000µs 📉 -26.5%) vs baseline: +0.8% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.1% ✅ casefold_noaspectTime: ✅ 3.180µs (SLO: <10.000µs 📉 -68.2%) vs baseline: -0.1% Memory: ✅ 42.762MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.4% ✅ decode_aspectTime: ✅ 15.647µs (SLO: <30.000µs 📉 -47.8%) vs baseline: ~same Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.1% ✅ decode_noaspectTime: ✅ 1.591µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.7% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +5.3% ✅ encode_aspectTime: ✅ 18.136µs (SLO: <30.000µs 📉 -39.5%) vs baseline: 📈 +22.6% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.1% ✅ encode_noaspectTime: ✅ 1.491µs (SLO: <10.000µs 📉 -85.1%) vs baseline: -0.3% Memory: ✅ 42.664MB (SLO: <43.500MB 🟡 -1.9%) vs baseline: +4.3% ✅ format_aspectTime: ✅ 170.673µs (SLO: <200.000µs 📉 -14.7%) vs baseline: -0.3% Memory: ✅ 42.743MB (SLO: <43.250MB 🟡 -1.2%) vs baseline: +4.0% ✅ format_map_aspectTime: ✅ 191.040µs (SLO: <200.000µs -4.5%) vs baseline: ~same Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.2% ✅ format_map_noaspectTime: ✅ 3.793µs (SLO: <10.000µs 📉 -62.1%) vs baseline: ~same Memory: ✅ 42.861MB (SLO: <43.250MB 🟡 -0.9%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 3.143µs (SLO: <10.000µs 📉 -68.6%) vs baseline: -0.6% Memory: ✅ 42.762MB (SLO: <43.250MB 🟡 -1.1%) vs baseline: +5.0% ✅ index_aspectTime: ✅ 15.238µs (SLO: <20.000µs 📉 -23.8%) vs baseline: -0.2% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.3% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ join_aspectTime: ✅ 16.953µs (SLO: <20.000µs 📉 -15.2%) vs baseline: -0.8% Memory: ✅ 42.644MB (SLO: <43.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 1.552µs (SLO: <10.000µs 📉 -84.5%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.250MB 🟡 -1.5%) vs baseline: +4.6% ✅ ljust_aspectTime: ✅ 20.905µs (SLO: <30.000µs 📉 -30.3%) vs baseline: +0.6% Memory: ✅ 42.664MB (SLO: <43.250MB 🟡 -1.4%) vs baseline: +4.8% ✅ ljust_noaspectTime: ✅ 2.686µs (SLO: <10.000µs 📉 -73.1%) vs baseline: -0.1% Memory: ✅ 42.743MB (SLO: <43.250MB 🟡 -1.2%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 17.823µs (SLO: <30.000µs 📉 -40.6%) vs baseline: -0.6% Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 2.447µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +0.9% Memory: ✅ 42.782MB (SLO: <43.250MB 🟡 -1.1%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 17.555µs (SLO: <20.000µs 📉 -12.2%) vs baseline: -0.3% Memory: ✅ 42.703MB (SLO: <43.250MB 🟡 -1.3%) vs baseline: +4.4% ✅ lstrip_noaspectTime: ✅ 1.862µs (SLO: <10.000µs 📉 -81.4%) vs baseline: -0.5% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.6% ✅ modulo_aspectTime: ✅ 166.195µs (SLO: <200.000µs 📉 -16.9%) vs baseline: ~same Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 179.729µs (SLO: <200.000µs 📉 -10.1%) vs baseline: +2.9% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.0% ✅ modulo_aspect_for_bytesTime: ✅ 168.266µs (SLO: <200.000µs 📉 -15.9%) vs baseline: ~same Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 172.155µs (SLO: <200.000µs 📉 -13.9%) vs baseline: +0.3% Memory: ✅ 43.214MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 3.677µs (SLO: <10.000µs 📉 -63.2%) vs baseline: -0.4% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ replace_aspectTime: ✅ 211.965µs (SLO: <300.000µs 📉 -29.3%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <44.000MB -2.2%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 2.898µs (SLO: <10.000µs 📉 -71.0%) vs baseline: -0.2% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.4% ✅ repr_aspectTime: ✅ 1.429µs (SLO: <10.000µs 📉 -85.7%) vs baseline: +0.2% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +4.5% ✅ repr_noaspectTime: ✅ 0.523µs (SLO: <10.000µs 📉 -94.8%) vs baseline: -0.7% Memory: ✅ 42.723MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ rstrip_aspectTime: ✅ 19.022µs (SLO: <30.000µs 📉 -36.6%) vs baseline: -0.8% Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +4.1% ✅ rstrip_noaspectTime: ✅ 2.061µs (SLO: <10.000µs 📉 -79.4%) vs baseline: +6.0% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 15.789µs (SLO: <20.000µs 📉 -21.1%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.500MB -2.0%) vs baseline: +4.6% ✅ slice_noaspectTime: ✅ 0.598µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -0.5% Memory: ✅ 42.703MB (SLO: <43.500MB 🟡 -1.8%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 53.920µs (SLO: <80.000µs 📉 -32.6%) vs baseline: ~same Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 3.613µs (SLO: <10.000µs 📉 -63.9%) vs baseline: ~same Memory: ✅ 42.743MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.3% ✅ strip_aspectTime: ✅ 17.563µs (SLO: <20.000µs 📉 -12.2%) vs baseline: -0.6% Memory: ✅ 42.821MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +5.5% ✅ strip_noaspectTime: ✅ 1.869µs (SLO: <10.000µs 📉 -81.3%) vs baseline: -0.2% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.5% ✅ swapcase_aspectTime: ✅ 18.511µs (SLO: <30.000µs 📉 -38.3%) vs baseline: +0.2% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 2.824µs (SLO: <10.000µs 📉 -71.8%) vs baseline: +0.4% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 18.258µs (SLO: <30.000µs 📉 -39.1%) vs baseline: ~same Memory: ✅ 42.625MB (SLO: <43.000MB 🟡 -0.9%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 2.706µs (SLO: <10.000µs 📉 -72.9%) vs baseline: +1.3% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 24.289µs (SLO: <30.000µs 📉 -19.0%) vs baseline: 📈 +18.8% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.6% ✅ translate_noaspectTime: ✅ 4.307µs (SLO: <10.000µs 📉 -56.9%) vs baseline: -0.6% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 17.965µs (SLO: <30.000µs 📉 -40.1%) vs baseline: -0.2% Memory: ✅ 42.566MB (SLO: <43.500MB -2.1%) vs baseline: +4.5% ✅ upper_noaspectTime: ✅ 2.448µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +1.0% Memory: ✅ 42.782MB (SLO: <43.500MB 🟡 -1.7%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.168µs (SLO: <10.000µs 📉 -48.3%) vs baseline: 📈 +21.2% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 4.305µs (SLO: <10.000µs 📉 -56.9%) vs baseline: +0.6% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.237µs (SLO: <10.000µs 📉 -37.6%) vs baseline: -0.2% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 6.294µs (SLO: <10.000µs 📉 -37.1%) vs baseline: -0.3% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.562µs (SLO: <10.000µs 📉 -64.4%) vs baseline: -1.7% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +5.1% ✅ ospathnormcase_noaspectTime: ✅ 3.594µs (SLO: <10.000µs 📉 -64.1%) vs baseline: -0.9% Memory: ✅ 41.327MB (SLO: <43.500MB -5.0%) vs baseline: +4.6% ✅ ospathsplit_aspectTime: ✅ 4.867µs (SLO: <10.000µs 📉 -51.3%) vs baseline: -1.1% Memory: ✅ 41.347MB (SLO: <43.500MB -5.0%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 4.983µs (SLO: <10.000µs 📉 -50.2%) vs baseline: -0.4% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.753µs (SLO: <10.000µs 📉 -62.5%) vs baseline: -0.1% Memory: ✅ 41.307MB (SLO: <43.500MB -5.0%) vs baseline: +4.5% ✅ ospathsplitdrive_noaspectTime: ✅ 0.747µs (SLO: <10.000µs 📉 -92.5%) vs baseline: -0.3% Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.620µs (SLO: <10.000µs 📉 -53.8%) vs baseline: -0.8% Memory: ✅ 41.563MB (SLO: <43.500MB -4.5%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 4.648µs (SLO: <10.000µs 📉 -53.5%) vs baseline: -0.6% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +5.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.367µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +13.9% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.1% ✅ 1-count-metrics-100-timesTime: ✅ 199.447µs (SLO: <220.000µs -9.3%) vs baseline: -0.6% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.293µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.9% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.595µs (SLO: <230.000µs -5.8%) vs baseline: +1.5% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.5% ✅ 1-gauge-metric-1-timesTime: ✅ 2.214µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +1.5% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.853µs (SLO: <150.000µs -8.1%) vs baseline: +0.9% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.5% ✅ 1-rate-metric-1-timesTime: ✅ 3.121µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +1.0% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.4% ✅ 1-rate-metrics-100-timesTime: ✅ 213.406µs (SLO: <250.000µs 📉 -14.6%) vs baseline: ~same Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.105ms (SLO: <22.000ms -8.6%) vs baseline: +0.8% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.249ms (SLO: <2.550ms 📉 -11.8%) vs baseline: +1.2% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: +1.0% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.203ms (SLO: <2.550ms 📉 -13.6%) vs baseline: +1.2% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.593µs (SLO: <20.000µs 📉 -77.0%) vs baseline: +0.5% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 173.218µs (SLO: <250.000µs 📉 -30.7%) vs baseline: -0.1% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.170ms (SLO: <2.500ms 📉 -13.2%) vs baseline: -0.2% Memory: ✅ 36.137MB (SLO: <36.500MB 🟡 -1.0%) vs baseline: +4.9% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
|
@brettlangdon do you know where to disable the requirement of the github version of this check? |
This change migrates the requirements lockfiles CI check from Github Actions to Gitlab in the interest of reducing dependence on Github Actions.