-
Notifications
You must be signed in to change notification settings - Fork 474
fix(ffe): fix exposure logging according to requirements (#15686) #15739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.19
Are you sure you want to change the base?
Conversation
<!-- Provide an overview of the change and motivation for the change --> This fixes feature flags exposure logging according to [requirements](https://datadoghq.atlassian.net/wiki/spaces/PANA/pages/5906009399/FFE+SDK+requirements) and [new system tests](DataDog/system-tests#5868). <!-- Describe your testing strategy or note what tests are included --> Updated python tests but haven't tested with system tests. <!-- Note any risks associated with this change, or "None" if no risks --> I guess none <!-- Any other information that would be helpful for reviewers --> --------- Co-authored-by: Leo Romanovsky <[email protected]> (cherry picked from commit 1dcf5d1)
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 217 ± 3 ms. The average import time from base is: 224 ± 6 ms. The import time difference between this PR and base is: -7.4 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate backport-15686-to-3.19 (1ec1800) with baseline 3.19 (89b9f91) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.4% Memory: ✅ 37.985MB (SLO: <41.500MB -8.5%) vs baseline: +5.4% ✅ add_inplace_aspectTime: ✅ 0.390µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +2.8% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.286µs (SLO: <10.000µs 📉 -97.1%) vs baseline: -1.0% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.357µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.3% Memory: ✅ 37.808MB (SLO: <41.500MB -8.9%) vs baseline: +4.3% ✅ bytearray_aspectTime: ✅ 1.336µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.2% Memory: ✅ 37.749MB (SLO: <41.500MB -9.0%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.576µs (SLO: <10.000µs 📉 -84.2%) vs baseline: +5.0% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.622µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.4% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +5.1% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.9% Memory: ✅ 37.749MB (SLO: <41.500MB -9.0%) vs baseline: +4.5% ✅ bytes_aspectTime: ✅ 1.294µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +2.0% Memory: ✅ 37.965MB (SLO: <41.500MB -8.5%) vs baseline: +5.2% ✅ bytes_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 1.303µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -1.9% Memory: ✅ 37.827MB (SLO: <41.500MB -8.8%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 0.509µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +2.1% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.738µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.1% Memory: ✅ 37.788MB (SLO: <41.500MB -8.9%) vs baseline: +4.5% ✅ capitalize_noaspectTime: ✅ 0.438µs (SLO: <10.000µs 📉 -95.6%) vs baseline: ~same Memory: ✅ 37.749MB (SLO: <41.500MB -9.0%) vs baseline: +4.4% ✅ casefold_aspectTime: ✅ 0.743µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.2% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +5.0% ✅ casefold_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.5% Memory: ✅ 37.827MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 0.425µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.5% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +5.1% ✅ encode_aspectTime: ✅ 0.712µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.3% Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: ~same Memory: ✅ 37.788MB (SLO: <41.500MB -8.9%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 3.336µs (SLO: <10.000µs 📉 -66.6%) vs baseline: ~same Memory: ✅ 37.847MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 3.526µs (SLO: <10.000µs 📉 -64.7%) vs baseline: -0.6% Memory: ✅ 37.827MB (SLO: <41.500MB -8.8%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 0.830µs (SLO: <10.000µs 📉 -91.7%) vs baseline: +1.7% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 0.598µs (SLO: <10.000µs 📉 -94.0%) vs baseline: ~same Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.341µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -0.2% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +5.1% ✅ index_noaspectTime: ✅ 0.315µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.2% Memory: ✅ 37.965MB (SLO: <41.500MB -8.5%) vs baseline: +5.4% ✅ join_aspectTime: ✅ 1.285µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +0.6% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 0.541µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.5% Memory: ✅ 37.906MB (SLO: <41.500MB -8.7%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 2.906µs (SLO: <20.000µs 📉 -85.5%) vs baseline: 📈 +13.6% Memory: ✅ 37.985MB (SLO: <41.500MB -8.5%) vs baseline: +5.5% ✅ ljust_noaspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.4% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 2.335µs (SLO: <10.000µs 📉 -76.6%) vs baseline: +5.9% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.1% ✅ lstrip_aspectTime: ✅ 2.435µs (SLO: <20.000µs 📉 -87.8%) vs baseline: 📈 +12.0% Memory: ✅ 37.788MB (SLO: <41.500MB -8.9%) vs baseline: +4.4% ✅ lstrip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.3% Memory: ✅ 37.808MB (SLO: <41.500MB -8.9%) vs baseline: +4.7% ✅ modulo_aspectTime: ✅ 0.969µs (SLO: <10.000µs 📉 -90.3%) vs baseline: +0.2% Memory: ✅ 37.788MB (SLO: <41.500MB -8.9%) vs baseline: +4.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.487µs (SLO: <10.000µs 📉 -85.1%) vs baseline: -0.2% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.957µs (SLO: <10.000µs 📉 -90.4%) vs baseline: +1.0% Memory: ✅ 37.808MB (SLO: <41.500MB -8.9%) vs baseline: +4.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.168µs (SLO: <10.000µs 📉 -88.3%) vs baseline: +0.3% Memory: ✅ 37.808MB (SLO: <41.500MB -8.9%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.676µs (SLO: <10.000µs 📉 -93.2%) vs baseline: +1.0% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.3% ✅ replace_aspectTime: ✅ 4.917µs (SLO: <10.000µs 📉 -50.8%) vs baseline: ~same Memory: ✅ 37.768MB (SLO: <41.500MB -9.0%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 0.465µs (SLO: <10.000µs 📉 -95.3%) vs baseline: +0.4% Memory: ✅ 37.965MB (SLO: <41.500MB -8.5%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 0.950µs (SLO: <10.000µs 📉 -90.5%) vs baseline: -0.4% Memory: ✅ 37.866MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.455µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.3% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.3% ✅ rstrip_aspectTime: ✅ 1.862µs (SLO: <20.000µs 📉 -90.7%) vs baseline: +0.2% Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.9% Memory: ✅ 38.024MB (SLO: <41.500MB -8.4%) vs baseline: +5.6% ✅ slice_aspectTime: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.2% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.449µs (SLO: <10.000µs 📉 -95.5%) vs baseline: ~same Memory: ✅ 37.827MB (SLO: <41.500MB -8.8%) vs baseline: +5.3% ✅ stringio_aspectTime: ✅ 1.705µs (SLO: <10.000µs 📉 -82.9%) vs baseline: -0.7% Memory: ✅ 37.768MB (SLO: <41.500MB -9.0%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 0.925µs (SLO: <10.000µs 📉 -90.8%) vs baseline: ~same Memory: ✅ 37.867MB (SLO: <41.500MB -8.8%) vs baseline: +5.2% ✅ strip_aspectTime: ✅ 2.178µs (SLO: <20.000µs 📉 -89.1%) vs baseline: ~same Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 0.392µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.3% Memory: ✅ 37.808MB (SLO: <41.500MB -8.9%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 2.507µs (SLO: <10.000µs 📉 -74.9%) vs baseline: +5.0% Memory: ✅ 37.886MB (SLO: <41.500MB -8.7%) vs baseline: +5.3% ✅ swapcase_noaspectTime: ✅ 0.542µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.4% Memory: ✅ 37.965MB (SLO: <41.500MB -8.5%) vs baseline: +5.6% ✅ title_aspectTime: ✅ 2.403µs (SLO: <10.000µs 📉 -76.0%) vs baseline: +2.7% Memory: ✅ 37.945MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ title_noaspectTime: ✅ 0.507µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +0.2% Memory: ✅ 37.945MB (SLO: <41.500MB -8.6%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 3.201µs (SLO: <10.000µs 📉 -68.0%) vs baseline: ~same Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +5.1% ✅ translate_noaspectTime: ✅ 1.044µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.2% Memory: ✅ 37.926MB (SLO: <41.500MB -8.6%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 2.211µs (SLO: <10.000µs 📉 -77.9%) vs baseline: +0.3% Memory: ✅ 38.063MB (SLO: <41.500MB -8.3%) vs baseline: +5.6% ✅ upper_noaspectTime: ✅ 0.376µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.5% Memory: ✅ 37.945MB (SLO: <41.500MB -8.6%) vs baseline: +5.5% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.324µs (SLO: <10.000µs 📉 -56.8%) vs baseline: +4.2% Memory: ✅ 38.299MB (SLO: <41.000MB -6.6%) vs baseline: +5.3% ✅ ospathbasename_noaspectTime: ✅ 1.096µs (SLO: <10.000µs 📉 -89.0%) vs baseline: +1.6% Memory: ✅ 38.240MB (SLO: <41.000MB -6.7%) vs baseline: +6.0% ✅ ospathjoin_aspectTime: ✅ 5.964µs (SLO: <10.000µs 📉 -40.4%) vs baseline: +0.4% Memory: ✅ 38.122MB (SLO: <41.000MB -7.0%) vs baseline: +5.7% ✅ ospathjoin_noaspectTime: ✅ 2.312µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +1.3% Memory: ✅ 37.867MB (SLO: <41.000MB -7.6%) vs baseline: +4.5% ✅ ospathnormcase_aspectTime: ✅ 3.417µs (SLO: <10.000µs 📉 -65.8%) vs baseline: -0.2% Memory: ✅ 38.260MB (SLO: <41.000MB -6.7%) vs baseline: +5.3% ✅ ospathnormcase_noaspectTime: ✅ 0.576µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +2.2% Memory: ✅ 38.240MB (SLO: <41.000MB -6.7%) vs baseline: +6.1% ✅ ospathsplit_aspectTime: ✅ 4.716µs (SLO: <10.000µs 📉 -52.8%) vs baseline: +0.4% Memory: ✅ 38.004MB (SLO: <41.000MB -7.3%) vs baseline: +4.2% ✅ ospathsplit_noaspectTime: ✅ 1.593µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.6% Memory: ✅ 37.847MB (SLO: <41.000MB -7.7%) vs baseline: +4.4% ✅ ospathsplitdrive_aspectTime: ✅ 4.217µs (SLO: <10.000µs 📉 -57.8%) vs baseline: 📈 +16.8% Memory: ✅ 37.808MB (SLO: <41.000MB -7.8%) vs baseline: +3.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.705µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.6% Memory: ✅ 38.122MB (SLO: <41.000MB -7.0%) vs baseline: +5.8% ✅ ospathsplitext_aspectTime: ✅ 4.542µs (SLO: <10.000µs 📉 -54.6%) vs baseline: +0.9% Memory: ✅ 38.240MB (SLO: <41.000MB -6.7%) vs baseline: +5.2% ✅ ospathsplitext_noaspectTime: ✅ 1.384µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +1.1% Memory: ✅ 38.063MB (SLO: <41.000MB -7.2%) vs baseline: +5.3% 🟡 Near SLO Breach (2 suites)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.594ms (SLO: <4.750ms -3.3%) vs baseline: -0.2% Memory: ✅ 64.036MB (SLO: <66.500MB -3.7%) vs baseline: +4.6% ✅ appsec-postTime: ✅ 6.622ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.1% Memory: ✅ 63.968MB (SLO: <66.500MB -3.8%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.579ms (SLO: <4.750ms -3.6%) vs baseline: -0.6% Memory: ✅ 64.060MB (SLO: <66.500MB -3.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.859ms (SLO: <2.000ms -7.1%) vs baseline: -0.6% Memory: ✅ 47.850MB (SLO: <49.500MB -3.3%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.5% Memory: ✅ 44.553MB (SLO: <49.000MB -9.1%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: ~same Memory: ✅ 48.640MB (SLO: <50.000MB -2.7%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: -0.3% Memory: ✅ 54.413MB (SLO: <56.000MB -2.8%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 54.354MB (SLO: <56.500MB -3.8%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.344ms (SLO: <3.650ms -8.4%) vs baseline: -0.3% Memory: ✅ 54.297MB (SLO: <60.000MB -9.5%) vs baseline: +4.8% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.926µs (SLO: <20.000µs 📉 -85.4%) vs baseline: +0.5% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 199.882µs (SLO: <220.000µs -9.1%) vs baseline: +0.2% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.218µs (SLO: <20.000µs 📉 -83.9%) vs baseline: ~same Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.188µs (SLO: <220.000µs -2.6%) vs baseline: +0.2% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.3% ✅ 1-gauge-metric-1-timesTime: ✅ 2.162µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.4% Memory: ✅ 34.406MB (SLO: <35.500MB -3.1%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.164µs (SLO: <150.000µs -8.6%) vs baseline: ~same Memory: ✅ 34.387MB (SLO: <35.500MB -3.1%) vs baseline: +4.8% ✅ 1-rate-metric-1-timesTime: ✅ 3.034µs (SLO: <20.000µs 📉 -84.8%) vs baseline: -0.6% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 213.320µs (SLO: <250.000µs 📉 -14.7%) vs baseline: +0.7% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.527ms (SLO: <22.000ms -6.7%) vs baseline: +2.3% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.273ms (SLO: <2.300ms 🟡 -1.2%) vs baseline: +2.5% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.405ms (SLO: <1.550ms -9.4%) vs baseline: +0.9% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.6% ✅ 100-rate-metrics-100-timesTime: ✅ 2.186ms (SLO: <2.550ms 📉 -14.3%) vs baseline: +0.7% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.498µs (SLO: <20.000µs 📉 -77.5%) vs baseline: +0.8% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 173.767µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.8% Memory: ✅ 34.446MB (SLO: <35.500MB -3.0%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.108ms (SLO: <2.500ms 📉 -15.7%) vs baseline: +0.1% Memory: ✅ 35.193MB (SLO: <36.500MB -3.6%) vs baseline: +4.6%
|
tests](DataDog/system-tests#5868).
Updated python tests but haven't tested with system tests.I guess none
(cherry picked from commit 1dcf5d1)
Description
Testing
Risks
Additional Notes