-
Notifications
You must be signed in to change notification settings - Fork 474
add link_span method #15740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add link_span method #15740
Conversation
|
|
Performance SLOsComparing candidate nicole-cybul/manual-span-linking (b95b435) with baseline main (76fed57) ❌ Test Failures (1 suite)❌ iastaspects - 117/118✅ add_aspectTime: ✅ 17.917µs (SLO: <20.000µs 📉 -10.4%) vs baseline: 📈 +18.9% Memory: ✅ 42.998MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 14.887µs (SLO: <20.000µs 📉 -25.6%) vs baseline: -0.6% Memory: ✅ 43.037MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 0.340µs (SLO: <10.000µs 📉 -96.6%) vs baseline: +0.2% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 0.546µs (SLO: <10.000µs 📉 -94.5%) vs baseline: -0.8% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ bytearray_aspectTime: ✅ 18.086µs (SLO: <30.000µs 📉 -39.7%) vs baseline: +0.3% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ bytearray_extend_aspectTime: ✅ 23.913µs (SLO: <30.000µs 📉 -20.3%) vs baseline: +0.6% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ bytearray_extend_noaspectTime: ✅ 2.729µs (SLO: <10.000µs 📉 -72.7%) vs baseline: +3.4% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 1.472µs (SLO: <10.000µs 📉 -85.3%) vs baseline: +0.6% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 16.576µs (SLO: <20.000µs 📉 -17.1%) vs baseline: -1.2% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 1.421µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +2.1% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.4% ✅ bytesio_aspectTime: ✅ 55.206µs (SLO: <70.000µs 📉 -21.1%) vs baseline: -0.2% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.4% ✅ bytesio_noaspectTime: ✅ 3.257µs (SLO: <10.000µs 📉 -67.4%) vs baseline: +1.1% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 14.623µs (SLO: <20.000µs 📉 -26.9%) vs baseline: -0.4% Memory: ✅ 42.585MB (SLO: <43.500MB -2.1%) vs baseline: +3.9% ✅ capitalize_noaspectTime: ✅ 2.593µs (SLO: <10.000µs 📉 -74.1%) vs baseline: +2.2% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.4% ✅ casefold_aspectTime: ✅ 14.610µs (SLO: <20.000µs 📉 -27.0%) vs baseline: -0.7% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 3.163µs (SLO: <10.000µs 📉 -68.4%) vs baseline: +2.1% Memory: ✅ 42.920MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 15.616µs (SLO: <30.000µs 📉 -47.9%) vs baseline: -0.2% Memory: ✅ 43.096MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 1.586µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -1.2% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 18.130µs (SLO: <30.000µs 📉 -39.6%) vs baseline: 📈 +20.8% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 1.480µs (SLO: <10.000µs 📉 -85.2%) vs baseline: +0.2% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ format_aspectTime: ✅ 170.795µs (SLO: <200.000µs 📉 -14.6%) vs baseline: ~same Memory: ✅ 43.116MB (SLO: <43.250MB 🟡 -0.3%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 190.819µs (SLO: <200.000µs -4.6%) vs baseline: -0.2% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.3% ✅ format_map_noaspectTime: ✅ 3.800µs (SLO: <10.000µs 📉 -62.0%) vs baseline: +2.3% Memory: ✅ 42.782MB (SLO: <43.250MB 🟡 -1.1%) vs baseline: +4.4% ✅ format_noaspectTime: ✅ 3.175µs (SLO: <10.000µs 📉 -68.3%) vs baseline: +0.3% Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +4.6% ✅ index_aspectTime: ✅ 15.266µs (SLO: <20.000µs 📉 -23.7%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <43.250MB 🟡 -0.5%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 0.465µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.3% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ join_aspectTime: ✅ 17.032µs (SLO: <20.000µs 📉 -14.8%) vs baseline: ~same Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 1.554µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +4.1% Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 20.835µs (SLO: <30.000µs 📉 -30.6%) vs baseline: -0.4% Memory: ✅ 43.057MB (SLO: <43.250MB 🟡 -0.4%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 2.711µs (SLO: <10.000µs 📉 -72.9%) vs baseline: +2.4% Memory: ✅ 42.959MB (SLO: <43.250MB 🟡 -0.7%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 17.848µs (SLO: <30.000µs 📉 -40.5%) vs baseline: -0.4% Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ lower_noaspectTime: ✅ 2.419µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +1.6% Memory: ✅ 43.116MB (SLO: <43.250MB 🟡 -0.3%) vs baseline: +5.1% ✅ lstrip_aspectTime: ✅ 17.605µs (SLO: <20.000µs 📉 -12.0%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <43.250MB 🟡 -0.6%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 1.861µs (SLO: <10.000µs 📉 -81.4%) vs baseline: +2.3% Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 166.362µs (SLO: <200.000µs 📉 -16.8%) vs baseline: ~same Memory: ✅ 43.018MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 174.646µs (SLO: <200.000µs 📉 -12.7%) vs baseline: ~same Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +4.5% ✅ modulo_aspect_for_bytesTime: ✅ 168.711µs (SLO: <200.000µs 📉 -15.6%) vs baseline: +0.4% Memory: ✅ 43.214MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +5.1% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 171.830µs (SLO: <200.000µs 📉 -14.1%) vs baseline: ~same Memory: ✅ 43.214MB (SLO: <43.500MB 🟡 -0.7%) vs baseline: +5.3% ✅ modulo_noaspectTime: ✅ 3.765µs (SLO: <10.000µs 📉 -62.3%) vs baseline: +2.5% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 211.710µs (SLO: <300.000µs 📉 -29.4%) vs baseline: -1.2% Memory: ✅ 43.175MB (SLO: <44.000MB 🟡 -1.9%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 2.897µs (SLO: <10.000µs 📉 -71.0%) vs baseline: 📉 -44.2% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 1.422µs (SLO: <10.000µs 📉 -85.8%) vs baseline: +3.4% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 0.523µs (SLO: <10.000µs 📉 -94.8%) vs baseline: -0.1% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ rstrip_aspectTime: ✅ 19.057µs (SLO: <30.000µs 📉 -36.5%) vs baseline: -0.5% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 2.013µs (SLO: <10.000µs 📉 -79.9%) vs baseline: +6.9% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 15.808µs (SLO: <20.000µs 📉 -21.0%) vs baseline: -1.2% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.1% ✅ slice_noaspectTime: ✅ 0.595µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -1.6% Memory: ✅ 42.861MB (SLO: <43.500MB 🟡 -1.5%) vs baseline: +4.7% ✅ stringio_aspectTime: ✅ 54.028µs (SLO: <80.000µs 📉 -32.5%) vs baseline: ~same Memory: ✅ 42.939MB (SLO: <43.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 3.636µs (SLO: <10.000µs 📉 -63.6%) vs baseline: +2.7% Memory: ✅ 42.900MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ strip_aspectTime: ✅ 17.715µs (SLO: <20.000µs 📉 -11.4%) vs baseline: +0.4% Memory: ✅ 43.037MB (SLO: <43.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 1.855µs (SLO: <10.000µs 📉 -81.4%) vs baseline: +1.6% Memory: ✅ 42.998MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ swapcase_aspectTime: ✅ 18.531µs (SLO: <30.000µs 📉 -38.2%) vs baseline: +0.3% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ swapcase_noaspectTime: ✅ 2.827µs (SLO: <10.000µs 📉 -71.7%) vs baseline: +0.8% Memory: ✅ 43.057MB (SLO: <43.500MB 🟡 -1.0%) vs baseline: +5.1% ❌ title_aspectTime: ❌ 22.075µs (SLO: <20.000µs 📈 +10.4%) vs baseline: 📈 +20.7% Memory: ✅ 43.037MB (SLO: <43.000MB ~same) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 2.682µs (SLO: <10.000µs 📉 -73.2%) vs baseline: +1.1% Memory: ✅ 42.979MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ translate_aspectTime: ✅ 20.506µs (SLO: <30.000µs 📉 -31.6%) vs baseline: -0.2% Memory: ✅ 42.959MB (SLO: <43.500MB 🟡 -1.2%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 4.310µs (SLO: <10.000µs 📉 -56.9%) vs baseline: +1.2% Memory: ✅ 42.802MB (SLO: <43.500MB 🟡 -1.6%) vs baseline: +4.5% ✅ upper_aspectTime: ✅ 17.937µs (SLO: <30.000µs 📉 -40.2%) vs baseline: +1.0% Memory: ✅ 43.096MB (SLO: <43.500MB 🟡 -0.9%) vs baseline: +5.1% ✅ upper_noaspectTime: ✅ 2.456µs (SLO: <10.000µs 📉 -75.4%) vs baseline: +3.0% Memory: ✅ 42.880MB (SLO: <43.500MB 🟡 -1.4%) vs baseline: +4.4% 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.149µs (SLO: <10.000µs 📉 -48.5%) vs baseline: 📈 +21.5% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 4.231µs (SLO: <10.000µs 📉 -57.7%) vs baseline: -2.1% Memory: ✅ 41.425MB (SLO: <43.500MB -4.8%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.220µs (SLO: <10.000µs 📉 -37.8%) vs baseline: +1.1% Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 6.319µs (SLO: <10.000µs 📉 -36.8%) vs baseline: +1.1% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.573µs (SLO: <10.000µs 📉 -64.3%) vs baseline: +2.6% Memory: ✅ 41.327MB (SLO: <43.500MB -5.0%) vs baseline: +4.4% ✅ ospathnormcase_noaspectTime: ✅ 3.582µs (SLO: <10.000µs 📉 -64.2%) vs baseline: -0.2% Memory: ✅ 41.465MB (SLO: <43.500MB -4.7%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.858µs (SLO: <10.000µs 📉 -51.4%) vs baseline: ~same Memory: ✅ 41.366MB (SLO: <43.500MB -4.9%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 4.994µs (SLO: <10.000µs 📉 -50.1%) vs baseline: +1.2% Memory: ✅ 41.484MB (SLO: <43.500MB -4.6%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.763µs (SLO: <10.000µs 📉 -62.4%) vs baseline: ~same Memory: ✅ 41.406MB (SLO: <43.500MB -4.8%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.743µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.5% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.626µs (SLO: <10.000µs 📉 -53.7%) vs baseline: -0.5% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 4.662µs (SLO: <10.000µs 📉 -53.4%) vs baseline: -0.1% Memory: ✅ 41.386MB (SLO: <43.500MB -4.9%) vs baseline: +4.5% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.379µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +11.3% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 200.307µs (SLO: <220.000µs -9.0%) vs baseline: -1.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.292µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -1.4% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 213.050µs (SLO: <230.000µs -7.4%) vs baseline: -3.0% Memory: ✅ 34.918MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.167µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.9% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.395µs (SLO: <150.000µs -9.1%) vs baseline: ~same Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ 1-rate-metric-1-timesTime: ✅ 3.080µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -3.1% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 213.060µs (SLO: <250.000µs 📉 -14.8%) vs baseline: -1.3% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.134ms (SLO: <22.000ms -8.5%) vs baseline: ~same Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.268ms (SLO: <2.550ms 📉 -11.0%) vs baseline: -0.4% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.403ms (SLO: <1.550ms -9.5%) vs baseline: ~same Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +5.2% ✅ 100-rate-metrics-100-timesTime: ✅ 2.208ms (SLO: <2.550ms 📉 -13.4%) vs baseline: -0.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.5% ✅ flush-1-metricTime: ✅ 4.591µs (SLO: <20.000µs 📉 -77.0%) vs baseline: -0.5% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 175.355µs (SLO: <250.000µs 📉 -29.9%) vs baseline: +1.1% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.3% ✅ flush-1000-metricsTime: ✅ 2.169ms (SLO: <2.500ms 📉 -13.2%) vs baseline: -0.3% Memory: ✅ 36.058MB (SLO: <36.500MB 🟡 -1.2%) vs baseline: +4.9% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Testing
Risks
Additional Notes