Skip to content

Gnufede/ddtest appsec llmobs followup - #19917

Draft
gnufede wants to merge 3 commits into
gnufede/ddtest-dogfoodingfrom
gnufede/ddtest-appsec-llmobs-followup
Draft

Gnufede/ddtest appsec llmobs followup#19917
gnufede wants to merge 3 commits into
gnufede/ddtest-dogfoodingfrom
gnufede/ddtest-appsec-llmobs-followup

Conversation

@gnufede

@gnufede gnufede commented Aug 28, 2026

Copy link
Copy Markdown
Member

Description

Testing

Risks

Additional Notes

gnufede added 3 commits August 28, 2026 11:14
@gnufede
ci: opt-in appsec_threats_fastapi_iast and mistralai to ddtest
628afa2 
Add ddtest: true to appsec_threats_fastapi_iast (tests/appsec/suitespec.yml)
and mistralai (tests/llmobs/suitespec.yml), with corresponding riotfile.py
changes (DDTEST_SUITE_PATH, DDTEST_TESTS_LOCATION, command placeholders).

appsec_threats_fastapi_iast also adds:
- DDTEST_PYTEST_ADDOPTS: -k 'Test_FastAPI and not Test_FastAPI_RC' to
  exclude the RC test class (which needs DD_REMOTE_CONFIGURATION_ENABLED=true,
  handled by the dedicated appsec_threats_fastapi_rc suite).
- services: [testagent] for snapshot comparison.
- env: _DD_PYTEST_XDIST_INFERRED_SERVICE for stable service inference.

Split from #19870 to isolate CODEOWNER approvals.
@gnufede
ci: opt-in appsec_integrations_django and profile to ddtest
63d5046 
Add ddtest: true (ddtest_nodes: 2) to appsec_integrations_django
(tests/appsec/suitespec.yml) and profile (tests/profiling/suitespec.yml)
suites, with corresponding riotfile.py changes (DDTEST_SUITE_PATH,
DDTEST_TESTS_LOCATION, command placeholders).

Split from #19870 to isolate CODEOWNER approvals.
@gnufede
fix(ci): add _DD_PYTEST_XDIST_INFERRED_SERVICE to appsec_integrations…
e28712c 
…_django and profile

Same fix as tracer/celery: ddtest passes individual files to pytest, so
detect_service picks the first file's subpackage. Set the env var in the
suitespec to short-circuit detect_service at import time.
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Aug 28, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | check-slo-breaches — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 10 tests - 10 passed on retry View in Datadog

🚧 2 tests that failed were ignored due to quarantine View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e28712c | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 28, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-28 11:46:38

Comparing candidate commit e28712c in PR branch gnufede/ddtest-appsec-llmobs-followup with baseline commit 421ff77 in branch gnufede/ddtest-dogfooding.

📊 Benchmarking dashboard

Found 0 performance improvements and 7 performance regressions! Performance is the same for 578 metrics, 11 unstable metrics, 18 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.440µs; +2.588µs] or [+14.463%; +15.342%]

scenario:iastaspects-add_aspect

  • 🟥 execution_time [+12.831µs; +15.102µs] or [+12.993%; +15.292%]

scenario:iastaspects-stringio_noaspect

  • 🟥 execution_time [+26.764µs; +30.433µs] or [+8.128%; +9.242%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+140.661µs; +150.866µs] or [+35.826%; +38.425%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+40.710µs; +44.366µs] or [+28.999%; +31.603%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+644.846ns; +692.893ns] or [+23.804%; +25.578%]

scenario:tracer-small

  • 🟥 execution_time [+30.346µs; +32.929µs] or [+9.318%; +10.111%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-664.210ns; +788.949ns] or [-6.117%; +7.265%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-36.241ns; +30.020ns] or [-5.899%; +4.887%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1448.760ns; +1835.995ns] or [-8.595%; +10.892%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-1095.071ns; +1360.183ns] or [-8.526%; +10.590%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-254.956ns; +393.108ns] or [-7.038%; +10.851%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-190.595ns; +315.441ns] or [-6.630%; +10.973%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-77.123ns; +67.879ns] or [-6.555%; +5.769%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4198.219ns; +3773.958ns] or [-10.235%; +9.201%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-841.960ns; +698.143ns] or [-10.290%; +8.533%]

scenario:flasksqli-tracer-enabled

  • unstable execution_time [-60.955µs; +182.168µs] or [-2.758%; +8.242%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-58999.344ns; +57812.558ns] or [-9.491%; +9.300%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:span-start
  • scenario:telemetryaddmetric-record-100-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gnufede