Skip to content

ci: auto-retry build windows jobs - #19926

Open
KowalskiThomas wants to merge 1 commit into
mainfrom
kowalski/ci-auto-retry-build-windows-jobs
Open

ci: auto-retry build windows jobs#19926
KowalskiThomas wants to merge 1 commit into
mainfrom
kowalski/ci-auto-retry-build-windows-jobs

Conversation

@KowalskiThomas

Copy link
Copy Markdown
Collaborator

Description

Hopefully we save ourselves some MQ attempts; we've been having a lot of CI infra issues lately with those jobs.

@KowalskiThomas
KowalskiThomas requested review from a team as code owners August 28, 2026 14:34
@KowalskiThomas KowalskiThomas added changelog/no-changelog A changelog entry is not required for this PR. CI labels Aug 28, 2026
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.gitlab/package.yml                                                     @DataDog/python-guild @DataDog/apm-core-python

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 28, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 28, 2026

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.llmobs._integrations.langgraph -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._integrations.claude_agent_sdk -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.llmobs._utils -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)
ddtrace.debugging._signal.model -×-> ddtrace.trace  (product:debugging -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

⚠️ Warnings

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 13 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | contrib/aiobotocore 8/8 — 🔄 Retry may pass, looks flaky

View more details · View in GitLab

View all 13 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 15 tests - 11 passed on retry View in Datadog

🚧 12 tests that failed were ignored due to quarantine View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 38c13ec | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Aug 28, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-08-28 15:22:28

Comparing candidate commit 38c13ec in PR branch kowalski/ci-auto-retry-build-windows-jobs with baseline commit 4f7e2fb in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 8 performance regressions! Performance is the same for 578 metrics, 10 unstable metrics, 1 known flaky benchmarks, 17 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.494µs; +2.656µs] or [+14.776%; +15.735%]

scenario:iastaspects-add_aspect

  • 🟥 execution_time [+14.851µs; +17.886µs] or [+15.051%; +18.127%]

scenario:iastaspects-join_aspect

  • 🟥 execution_time [+55.840µs; +62.630µs] or [+26.450%; +29.666%]

scenario:iastaspects-title_aspect

  • 🟥 execution_time [+66.804µs; +72.963µs] or [+24.251%; +26.487%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+130.979µs; +139.646µs] or [+31.337%; +33.410%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+40.399µs; +45.369µs] or [+28.265%; +31.743%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+648.900ns; +688.470ns] or [+24.027%; +25.492%]

scenario:tracer-small

  • 🟥 execution_time [+27.534µs; +29.926µs] or [+8.462%; +9.197%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-716.652ns; +744.848ns] or [-6.562%; +6.820%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-35.266ns; +30.797ns] or [-5.768%; +5.037%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1483.654ns; +1806.621ns] or [-8.784%; +10.696%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-780.820ns; +1716.296ns] or [-6.091%; +13.388%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-266.313ns; +379.278ns] or [-7.350%; +10.467%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-193.312ns; +312.209ns] or [-6.715%; +10.845%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-74.674ns; +75.561ns] or [-6.347%; +6.422%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4312.303ns; +3639.657ns] or [-10.484%; +8.849%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-846.130ns; +713.039ns] or [-10.405%; +8.768%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-62.806µs; +55.338µs] or [-10.026%; +8.834%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-ljust_noaspect

  • 🟥 execution_time [+58.727µs; +63.844µs] or [+20.845%; +22.661%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:span-start
  • scenario:telemetryaddmetric-record-100-metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants