chore(compat): MAX_PY=3.14 last-supported, NEXT_MAX_PY=3.15 fail-closed (PROF-14439)

[vlad-scherbich]

Description

Delta vs #19906.

MAX_PY is (3, 14) (last officially supported; matches requires-python <3.15). NEXT_MAX_PY is derived from MAX_PY as (3, 15). wrap/lazy do not raise at NEXT_MAX_PY; they match merged #19910 (trampoline / WrappingContext on 3.15) and fail-close at 3.16. PY_315_VERSION_INFO is the CPython API floor and is never aliased to MAX_PY. After 3.15 GAs, bump MAX_PY to (3, 15).

WrappingContext raises at 3.16 (monitoring already works on 3.15). SSI exclusive max is 3.16 so 3.15 injection remains (#19843).

Layer	Meaning	Which PR
Compiled into artifact	n/a	—
Armed at runtime	wrap() live on 3.15; fail-close at 3.16	this PR (ports #19910)
Observable in product/Python	MAX_PY=3.14, NEXT_MAX_PY=3.15, PY_315 floor	this PR

Testing

Constants pin MAX_PY=(3, 14), NEXT_MAX_PY=(3, 15), PY_315=(3, 15) and not aliased to MAX_PY. wrap() runs on 3.15; monkeypatch pins fail-close at 3.16.

Risks

None.

Additional Notes

Does not change requires-python. SSI/WrappingContext use 3.16, not NEXT_MAX_PY.

No release note: internal constants, changelog/no-changelog.

[cit-pr-commenter-54b7da]

Circular import analysis

⚠️ Existing circular imports

There are 3 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.llmobs -> ddtrace.llmobs._evaluators -> ddtrace.llmobs._evaluators.format -> ddtrace.llmobs._experiment -> ddtrace.llmobs
ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector
ddtrace.appsec._asm_request_context -> ddtrace.appsec._iast._iast_request_context_base -> ddtrace.appsec._iast._iast_env -> ddtrace.appsec._iast.reporter -> ddtrace.appsec._exploit_prevention.stack_traces -> ddtrace.appsec._asm_request_context

[cit-pr-commenter-54b7da]

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 240 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 240 highest severity)

ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=135)
ddtrace.internal.ci_visibility.filters -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=133)
ddtrace.internal.ci_visibility.api._base -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=133)
ddtrace.appsec._listeners -×-> ddtrace.trace  (product:appsec -> product:tracing, score=133)
ddtrace.llmobs._utils -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=133)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

[cit-pr-commenter-54b7da]

Codeowners resolved as

Resolved from the full PR diff against vlad/py315-riotfile using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

.gitlab/scripts/prune-unsupported-wheels.sh                             @DataDog/python-guild @DataDog/apm-core-python
.gitlab/templates/cached-testrunner.yml                                 @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/bytecode_injection/__init__.py                         @DataDog/apm-core-python
ddtrace/internal/compat.py                                              @DataDog/python-guild @DataDog/apm-core-python
ddtrace/internal/coverage/instrumentation_py3_12.py                     @DataDog/ci-app-libraries
ddtrace/internal/module.py                                              @DataDog/debugger-python @DataDog/apm-core-python
ddtrace/internal/monitoring.py                                          @DataDog/apm-core-python
ddtrace/internal/wrapping/__init__.py                                   @DataDog/apm-core-python
ddtrace/internal/wrapping/asyncs.py                                     @DataDog/apm-core-python
ddtrace/internal/wrapping/context.py                                    @DataDog/apm-core-python
ddtrace/internal/wrapping/generators.py                                 @DataDog/apm-core-python
hooks/pre-commit/05-run-bandit                                          @DataDog/python-guild
hooks/scripts/run-mypy.sh                                               @DataDog/python-guild
lib-injection/sources/sitecustomize.py                                  @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild
riotfile.py                                                             @DataDog/apm-python
tests/internal/test_py315_import_degrade.py                             @DataDog/apm-core-python

[pr-commenter]

Benchmarks

Benchmark execution time: 2026-08-30 03:22:39

Comparing candidate commit 57ccbdc in PR branch vlad/py315-current-py-version with baseline commit 23f857d in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 7 performance regressions! Performance is the same for 578 metrics, 10 unstable metrics, 3 known flaky benchmarks, 15 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

• 🟩 = significantly better candidate vs. baseline
• 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-tracecontext_headers

• 🟥 execution_time [+2.458µs; +2.661µs] or [+7.724%; +8.363%]

scenario:httppropagationinject-ids_only

• 🟥 execution_time [+2.786µs; +2.921µs] or [+16.994%; +17.815%]

scenario:iastaspects-add_aspect

• 🟥 execution_time [+7.700µs; +9.437µs] or [+7.587%; +9.299%]

scenario:iastaspectsospath-ospathbasename_aspect

• 🟥 execution_time [+126.853µs; +133.764µs] or [+30.225%; +31.871%]

scenario:iastaspectssplit-rsplit_aspect

• 🟥 execution_time [+38.158µs; +44.043µs] or [+26.217%; +30.261%]

scenario:telemetryaddmetric-1-count-metric-1-times

• 🟥 execution_time [+620.966ns; +669.694ns] or [+22.947%; +24.748%]

scenario:tracer-small

• 🟥 execution_time [+31.037µs; +33.986µs] or [+9.363%; +10.252%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

• unstable execution_time [-745.334ns; +730.727ns] or [-6.773%; +6.641%]

scenario:coreapiscenario-core_dispatch_1_listener

• unstable execution_time [-29.726ns; +36.987ns] or [-4.887%; +6.081%]

scenario:coreapiscenario-core_dispatch_50_listeners

• unstable execution_time [-1650.691ns; +1638.711ns] or [-9.694%; +9.624%]

scenario:coreapiscenario-core_dispatch_exception_listeners

• unstable execution_time [-1344.411ns; +1194.616ns] or [-10.157%; +9.025%]

scenario:coreapiscenario-core_dispatch_listeners

• unstable execution_time [-324.512ns; +327.334ns] or [-8.811%; +8.888%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

• unstable execution_time [-252.655ns; +260.493ns] or [-8.611%; +8.879%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

• unstable execution_time [-72.384ns; +72.312ns] or [-6.163%; +6.157%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

• unstable execution_time [-3798.634ns; +4126.741ns] or [-9.330%; +10.135%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

• unstable execution_time [-848.792ns; +703.721ns] or [-10.411%; +8.632%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

• unstable execution_time [-57.460µs; +60.233µs] or [-9.221%; +9.666%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:iastaspects-casefold_noaspect

• 🟥 execution_time [+64.462µs; +70.032µs] or [+26.238%; +28.505%]

scenario:iastaspects-translate_aspect

• 🟥 execution_time [+91.762µs; +102.161µs] or [+21.214%; +23.618%]

scenario:span-start

• 🟥 execution_time [+1.121ms; +1.303ms] or [+7.861%; +9.137%]

Known flaky benchmarks without significant changes:

• scenario:errortrackingflasksqli-baseline
• scenario:flasksimple-iast-get
• scenario:iastaspects-casefold_aspect
• scenario:iastaspects-index_aspect
• scenario:iastaspects-ljust_noaspect
• scenario:iastaspects-lower_aspect
• scenario:iastaspects-replace_aspect
• scenario:iastaspects-swapcase_aspect
• scenario:iastaspects-title_noaspect
• scenario:iastaspects-translate_noaspect
• scenario:iastaspects-upper_noaspect
• scenario:packagespackageforrootmodulemapping-cache_off
• scenario:packagespackageforrootmodulemapping-cache_on
• scenario:sethttpmeta-all-enabled
• scenario:telemetryaddmetric-record-100-metrics

[datadog-prod-us1-6]

 

✨ Unblock PR with BitsAI

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 6 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | check_requirements_lockfiles — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | prechecks — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-py | rust ci — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 6 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 57ccbdc | Docs | View more details | Give us feedback!}

[Copilot]

Pull request overview

This PR standardizes Python version bound constants in ddtrace.internal.compat by introducing MAX_PY_VERSION / NEXT_MAX_PY_VERSION and derived predicates (PY_GTE_MAX, PY_GTE_NEXT_MAX), then updates internal call sites and tests to use these shared checks (including wrapping fail-closed behavior and injection runtime allow-listing).

Changes:

• Add MAX/NEXT_MAX version constants + predicates to ddtrace.internal.compat.
• Replace ad-hoc version comparisons with shared predicates in wrapping-related code paths and tests.
• Align injection bootstrap runtime allow-list upper bound with NEXT_MAX_PY_VERSION_INFO.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ddtrace/internal/compat.py	Adds MAX/NEXT_MAX constants and PY_GTE_* predicates (with updated exports).
ddtrace/internal/wrapping/__init__.py	Switches wrap/wrap_bytecode fail-closed gate to PY_GTE_MAX.
ddtrace/internal/wrapping/context.py	Switches the 3.16+ fail-closed import-time gate to PY_GTE_NEXT_MAX.
ddtrace/internal/module.py	Updates lazy-module behavior gating to PY_GTE_MAX.
ddtrace/internal/monitoring.py	Replaces 3.15+ import guard with a MAX-based guard/message.
ddtrace/internal/coverage/instrumentation_py3_12.py	Replaces hardcoded 3.15 boundaries with MAX_PY_VERSION_INFO for PEP 810-related behavior.
lib-injection/sources/sitecustomize.py	Sets injection runtime exclusive upper bound to (3, 16) via NEXT_MAX_PY_VERSION_INFO.
tests/internal/test_py315_import_degrade.py	Adds assertions for the new constants/predicates and updates skipifs to use PY_GTE_MAX.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.