Fix process spawn#5634
Conversation
|
👋 Hey @marcotc, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2026-04-23 00:38:31 UTC |
Typing analysisNote: Ignored files are excluded from the next sections. Untyped methodsThis PR introduces 1 untyped method and 2 partially typed methods, and clears 1 untyped method and 1 partially typed method. It decreases the percentage of typed methods from 61.33% to 61.28% (-0.05%). Untyped methods (+1-1)❌ Introduced:Partially typed methods (+2-1)❌ Introduced:If you believe a method or an attribute is rightfully untyped or partially typed, you can add |
| self.@env_provider: ^() -> ::Hash[::String, ::String] | ||
|
|
||
| def self.apply!: (lineage_envs_provider: ^() -> ::Hash[::String, ::String]) -> true | ||
| def self.apply!: (env_provider: ^() -> ::Hash[::String, ::String]) -> untyped |
There was a problem hiding this comment.
| def self.apply!: (env_provider: ^() -> ::Hash[::String, ::String]) -> untyped | |
| def self.apply!: (env_provider: ^() -> ::Hash[::String, ::String]) -> void |
| true | ||
| end | ||
|
|
||
| # Vessel for env_provider propagation. |
There was a problem hiding this comment.
nit: We can improve clarity
| # Vessel for env_provider propagation. | |
| # Prepends Process.spawn to merge env_provider into the child env. |
| write_io.close | ||
| Process.wait(pid) | ||
|
|
||
| read_io.read.lines.map { |line| line.chomp.split('=', 2) }.to_h |
There was a problem hiding this comment.
this should fix the failing tests
| read_io.read.lines.map { |line| line.chomp.split('=', 2) }.to_h | |
| read_io.read.lines.filter_map do |line| | |
| parts = line.chomp.split("=", 2) | |
| parts if parts.size == 2 | |
| end.to_h |
Fixes #5621
What does this PR do?
Motivation:
Change log entry
Additional Notes:
How to test the change?