Arm fixups #476
Draft
Arm fixups #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_gettime - snapshot/map the vDSO so DWFL can surface proper kernel helper symbols - add workspace remapping hooks to resolve virtiofs-hosted binaries This helps with the MacOS dev workflow
- Extract vdso file info to a separate RAII class - Fix compilation warnings
r1viollet
commented
Dec 4, 2025
| DsoOrigin::kProcMaps}; | ||
| } | ||
|
|
||
| void DsoHdr::init_workspace_remap() { |
Collaborator
Author
There was a problem hiding this comment.
sorry for this complexity, though this allows me to work with docker, it should be a no-op for folks
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
nsavoire
reviewed
Dec 4, 2025
| addr &= top_byte_mask; | ||
|
|
||
| constexpr unsigned canonical_bits = 48; | ||
| if (canonical_bits < k_top_byte_shift) { |
Collaborator
There was a problem hiding this comment.
I don't understand the logic of this function:
this condition is always true, therefore the previous masking operation is unnecessary
nsavoire
approved these changes
Dec 4, 2025
Collaborator
Author
|
I'll work on splitting the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Working from MacOS aarch64, I was not able to get proper frames.
With these changes, I no longer have failures on Simple Malloc tests.
Additional Notes
This will require a branch in
ddprof-buildto cache elfutils:https://github.com/DataDog/ddprof-build/pull/152
How to test the change?
Describe here in detail how the change can be validated. This is a great section to call out specific tests you've added or improved, or to acknowledge code sections which are particularly difficult to test.