Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span Links Beta Documentation #20717

Merged
merged 18 commits into from
Dec 18, 2023
Merged

Span Links Beta Documentation #20717

merged 18 commits into from
Dec 18, 2023

Conversation

brett0000FF
Copy link
Contributor

@brett0000FF brett0000FF commented Nov 21, 2023 •
edited
Loading

Updates

  • TODO: Need better screenshot for trace view.
  • TODO: Need better code example for PHP.
  • TODO: Need better code example for Java. Edit: linking to OTel docs for Java.
  • TODO: Create new page with Span Link use cases under Sending Traces to Datadog.
  • TODO: Link from Trace View to how-to.
  • TODO: Clarify sentence about "Linked spans were not ingested" For example, linked spans are displayed only when the corresponding spans has been ingested and indexed (by retention filter for instance).

What does this PR do? What is the motivation?

Support for span links is now available (beta).

Merge instructions

  • Please merge after reviewing

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner November 21, 2023 00:31
@github-actions github-actions bot added the Images Images are added/removed with this PR label Nov 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@brett0000FF brett0000FF requested a review from PROFeNoM November 21, 2023 01:08
drichards-87
drichards-87 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had one very minor suggestion.

content/en/tracing/trace_collection/custom_instrumentation/java.md Outdated Show resolved Hide resolved
PerfectSlayer
PerfectSlayer reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick call out that [OpenTelemetry Context propagation][1] | [Datadog distributed header format][9] is used instead. is no more true.
It will be supported by default from 1.24.0. Otherwise, it needs to be setup with the provided link.

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Nov 29, 2023
@brett0000FF brett0000FF merged commit c7f3d6d into master Dec 18, 2023
7 checks passed
@brett0000FF brett0000FF deleted the brett0000FF/span-links branch December 18, 2023 19:29
MaelNamNam pushed a commit that referenced this pull request Jan 17, 2024
@brett0000FF @MaelNamNam
Span Links Beta Documentation (#20717)
a2d5ca2 
* Add Span Links (Beta) tab to Trace Explorer docs.

* Add sections to custom instrumentation for PHP and Java.

* Update code snippets and trace view screenshot.

* Missing period.

* Fix code snippets per Alexandre

* Remove Java from DD lib custom instrumentation. Note in OTel instrumentation instead.

* Change OTel context propagation support (unrelated to span links).

* Make link to trace explorer more precise. Remove from Java.

* Add new Span Links page to Sending Traces to Datadog.

* Reorganize and clean up Span Links page.

* Redo Trace View section now that we have a full span links page.

* Apply feedback from review.

* Adjust headings.

* Remove fan-out use cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

@PROFeNoM PROFeNoM PROFeNoM left review comments

@drichards-87 drichards-87 drichards-87 approved these changes

@divyatag divyatag Awaiting requested review from divyatag

@yoannrobin yoannrobin Awaiting requested review from yoannrobin

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend Images Images are added/removed with this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brett0000FF @PerfectSlayer @PROFeNoM @drichards-87