Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-9128] NDM restructure #26588

Merged
merged 20 commits into from
Dec 27, 2024
Merged

Conversation

aliciascott
Copy link
Contributor

@aliciascott aliciascott commented Dec 4, 2024

What does this PR do? What is the motivation?

This PR restructures some of the NDM content, noteably changing the "Getting Started" page to "Setup" and nesting some new pages underneath (4th level Nav).

Creates new Glossary page.

Additionally new content has been pulled and added to the Troubleshooting page.

Lastly, it appears that there are several “net new” pages, however, much of the content (new troubleshooting page, ping page, SD-WAN page, etc), have been pulled out of the Getting Started page and branched to new subpages underneath (now called Setup)

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@aliciascott aliciascott requested review from a team as code owners December 4, 2024 00:21
@aliciascott aliciascott added the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 4, 2024
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Dec 4, 2024
@github-actions github-actions bot added the Images Images are added/removed with this PR label Dec 4, 2024
@aliciascott aliciascott added editorial review Waiting on a more in-depth review and removed WORK IN PROGRESS No review needed, it's a wip ;) labels Dec 10, 2024
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall! I added a few suggestions, including some that are a little more in-depth. If you want to get this PR merged first before tackling the bigger ones, let me know and I'll approve whenever!

content/en/network_monitoring/devices/glossary.md Outdated Show resolved Hide resolved
content/en/network_monitoring/devices/glossary.md Outdated Show resolved Hide resolved
content/en/network_monitoring/devices/glossary.md Outdated Show resolved Hide resolved
content/en/network_monitoring/devices/ping.md Show resolved Hide resolved
content/en/network_monitoring/devices/troubleshooting.md Outdated Show resolved Hide resolved
content/en/network_monitoring/devices/troubleshooting.md Outdated Show resolved Hide resolved
content/en/network_monitoring/devices/troubleshooting.md Outdated Show resolved Hide resolved
content/en/network_monitoring/devices/troubleshooting.md Outdated Show resolved Hide resolved
content/en/network_monitoring/devices/troubleshooting.md Outdated Show resolved Hide resolved
@aliciascott
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 27, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-27 15:42:32 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2024-12-27 15:49:17 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 312859f into master Dec 27, 2024
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aliciascott/DOCS-9128-NDM-restructure branch December 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants