Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dotnet.md #26604

Closed
wants to merge 2 commits into from
Closed

Update dotnet.md #26604

wants to merge 2 commits into from

Conversation

johannbotha
Copy link
Contributor

Updating Dog net based on Igor's recommendation https://dd.slack.com/archives/C072SJJM3D1/p1733342114505629

@johannbotha johannbotha requested a review from a team as a code owner December 4, 2024 20:10
@michaelcretzman
Copy link
Contributor

michaelcretzman commented Dec 4, 2024 •
edited
Loading

Approved.
You can merge your PR by adding a comment containing /merge.
The PR will go into the merge queue automatically once it's approved.

FYI - Name your branch slack_username/branch_name.

If you don't include the forward slash (/), the Gitlab pipeline won't run and you won't get a branch preview. Getting a branch preview makes it easier for us to check for any issues with your PR, such as broken links. Using a Slack username ensures you get build notifications in Slack.

@johannbotha
Copy link
Contributor Author

/merge

/merge

@janewang-datadog janewang-datadog self-requested a review December 13, 2024 14:59
janewang-datadog
janewang-datadog requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@janewang-datadog janewang-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the library name in addition to the link

IBM.Data.DB2.Core

@johannbotha
Copy link
Contributor Author

update the library name in addition to the link

IBM.Data.DB2.Core

Update to IBMMQDotnetClient

@johannbotha
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-12-13 16:56:57 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-13 20:57:00 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

johannbotha added a commit that referenced this pull request Dec 16, 2024
@johannbotha
Update dotnet.md
7061f37 
Clone of below PR that follows branch naming conventions

#26604
@johannbotha johannbotha mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piochelepiotr piochelepiotr piochelepiotr approved these changes

@kr-igor kr-igor kr-igor approved these changes

@michaelcretzman michaelcretzman michaelcretzman approved these changes

@janewang-datadog janewang-datadog janewang-datadog approved these changes

Assignees
No one assigned
Labels
mergequeue-status: removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johannbotha @michaelcretzman @piochelepiotr @kr-igor @janewang-datadog