-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs on muting CSM issues #26614
Update docs on muting CSM issues #26614
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions
content/en/security/cloud_security_management/review_remediate/mute_issues.md
Outdated
Show resolved
Hide resolved
content/en/security/cloud_security_management/review_remediate/mute_issues.md
Outdated
Show resolved
Hide resolved
content/en/security/cloud_security_management/review_remediate/mute_issues.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sandra (neko) <[email protected]>
Co-authored-by: Sandra (neko) <[email protected]>
Co-authored-by: Sandra (neko) <[email protected]>
Thanks for flagging those, @lucasdmaley ! I've made those updates, so if you take another look at the preview page, you should see them there. Let me know how it looks and don't hesitate to let me know if you need any further changes :) |
Thank you for making those changes @janine-c! Just noticed one thing - |
Thanks, @lucasdmaley , great catch! I added the Vulnerabilities explorer - let me know if you think I got the nuance for that right, or if you'd like to work on the phrasing a bit more :) I appreciate your attention to detail here while I'm still learning the nuances of how these explorers work differently! |
No worries at all! Phrasing looks right on what you added, I'd just make sure to add "Vulnerabilities" into this line:
|
@lucasdmaley Updated that wording - it originally omitted the Vulnerabilities explorer because it was leading into the part about manually removing those queries, but hopefully this is clearer :) |
Ah, that makes sense - this is definitely clearer. Thank you for going back in to add all of these details, looks good to go! |
/merge |
Devflow running:
|
What does this PR do? What is the motivation?
In this PR:
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes