Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for ASM Envoy Integration and GCP Service Extension #26912

Merged
merged 8 commits into from
Feb 21, 2025

Conversation

e-n-0
Copy link
Member

@e-n-0 e-n-0 commented Dec 27, 2024

What does this PR do? What is the motivation?

This PR adds the documentation in preview for the ASM Envoy and ASM GCP Service Extension integrations.
This adds the setup and compatibility requirements.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@e-n-0 e-n-0 force-pushed the flavien/envoy-gcp branch from aa25ed0 to 9c4d9c0 Compare December 27, 2024 13:19
@e-n-0 e-n-0 force-pushed the flavien/envoy-gcp branch 2 times, most recently from e8fbdc4 to 45987ef Compare December 27, 2024 15:01
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Dec 27, 2024
@e-n-0 e-n-0 self-assigned this Dec 27, 2024
@e-n-0 e-n-0 force-pushed the flavien/envoy-gcp branch 2 times, most recently from 712daed to 8ba1c35 Compare December 27, 2024 15:11
@e-n-0 e-n-0 force-pushed the flavien/envoy-gcp branch from 8ba1c35 to fdca741 Compare December 27, 2024 18:12
@e-n-0 e-n-0 marked this pull request as ready for review February 7, 2025 14:48
@e-n-0 e-n-0 requested review from a team as code owners February 7, 2025 14:48
@estherk15 estherk15 added the editorial review Waiting on a more in-depth review label Feb 7, 2025
@estherk15
Copy link
Contributor

Documentation Editorial Review card: https://datadoghq.atlassian.net/browse/DOCS-10032

reviewed and revised topics submitted by SWE in ASM Libraries .NET
@michaelcretzman michaelcretzman self-assigned this Feb 21, 2025
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a review pass. looks good. ready for merge on Approval from corpweb

@michaelcretzman michaelcretzman merged commit 7f9c510 into master Feb 21, 2025
11 checks passed
@michaelcretzman michaelcretzman deleted the flavien/envoy-gcp branch February 21, 2025 22:44
@brett0000FF brett0000FF mentioned this pull request Feb 26, 2025
1 task
jhssilva pushed a commit that referenced this pull request Mar 12, 2025
Co-authored-by: Michael Cretzman <[email protected]>
Co-authored-by: Michael Cretzman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants