Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DD_TRACE_AGENT_URL in Go Library Config #27059

Merged
merged 1 commit into from
Jan 17, 2025
Merged

DD_TRACE_AGENT_URL in Go Library Config #27059

merged 1 commit into from
Jan 17, 2025

Conversation

brett0000FF
Copy link
Contributor

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner January 9, 2025 22:45
@brett0000FF brett0000FF requested a review from ajgajg1134 January 9, 2025 22:45
@brett0000FF
Copy link
Contributor Author

@ajgajg1134 - It seems like we are missing DD_TRACE_AGENT_URL in our library config docs. Would you please be able to verify the changes I added? Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Preview links (active after the build_preview check completes)

Modified Files

ajgajg1134
ajgajg1134 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look good to me but you might want to double check with apm-go internally

@brett0000FF
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 17, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-17 17:00:44 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.

2025-01-17 17:08:34 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 79ae79f into master Jan 17, 2025
19 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the brett.blue/DOCS-9533 branch January 17, 2025 17:08
domalessi pushed a commit that referenced this pull request Jan 20, 2025
@brett0000FF @domalessi
Add entry for DD_TRACE_AGENT_URL. (#27059)
d7eb513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

@michaelcretzman michaelcretzman michaelcretzman approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brett0000FF @ajgajg1134 @michaelcretzman