Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CASEM-1642] Add Granular Access Control in case Management #27153

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

sysy6r
Copy link
Contributor

@sysy6r sysy6r commented Jan 16, 2025

What does this PR do? What is the motivation?

Case Management team is going to be releasing Project-level Access Control end of january. We want to update the public documentation to guide users as to what they can expect from this new feature.

Also, we are in the same release removing the Membership concept in case management : users won't be able to be a member of project, or to join or leave a project. so, we want to remove that from the documentation as well

Merge instructions

It's not ready to be merged. We want to merge this after we have GA the feature end of january

Merge readiness:

  • Ready for merge

@github-actions github-actions bot added the Images Images are added/removed with this PR label Jan 16, 2025
@sysy6r sysy6r changed the title Add Granular Access Control in case Management [CASEM-1642] Add Granular Access Control in case Management Jan 16, 2025
@sysy6r sysy6r force-pushed the sylvain.cizaire/add-granular-project-rbac branch from a8f9ed4 to 7cf7a84 Compare January 20, 2025 12:30
@sysy6r sysy6r marked this pull request as ready for review January 20, 2025 13:41
@sysy6r sysy6r requested a review from a team as a code owner January 20, 2025 13:41
@kayayarai kayayarai added Do Not Merge Just do not merge this PR :) editorial review Waiting on a more in-depth review labels Jan 20, 2025

By default, access to projects and cases is unrestricted. [Granular Access Control][1] can be used to manage the permissions of users, teams, roles, or your full organization at the project level. There are four sets of permissions that can be used:
- **Manager**: Users can create and edit cases, views, settings, and permissions of the project, and can delete the project.
- **Contributor**: Users can create, comment and edit cases, but not change settings or permissions or the project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Contributor**: Users can create, comment and edit cases, but not change settings or permissions or the project.
- **Contributor**: Users can create, comment on, and edit cases. They can't change settings, permissions, or the project.

By default, access to projects and cases is unrestricted. [Granular Access Control][1] can be used to manage the permissions of users, teams, roles, or your full organization at the project level. There are four sets of permissions that can be used:
- **Manager**: Users can create and edit cases, views, settings, and permissions of the project, and can delete the project.
- **Contributor**: Users can create, comment and edit cases, but not change settings or permissions or the project.
- **Viewer**: Users can view and watch all cases, views and settings of the project. They can’t create, edit, or comment on cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Viewer**: Users can view and watch all cases, views and settings of the project. They can’t create, edit, or comment on cases.
- **Viewer**: Users can view and watch all cases, views, and settings of the project. They can’t create, edit, or comment on cases.

- **Viewer**: Users can view and watch all cases, views and settings of the project. They can’t create, edit, or comment on cases.
- **No Access**: Users can’t view any cases, views, or settings of the project.

Note that other Datadog products that integrate with Case Management in an automated way such as Monitors are able to create cases within a project regardless of the project’s access settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that other Datadog products that integrate with Case Management in an automated way such as Monitors are able to create cases within a project regardless of the project’s access settings
**Note:** Other Datadog products that integrate with Case Management, such as Monitors, are able to automatically create cases within a project regardless of the project’s access settings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image contains company email addresses. Please blur the address or replace them with fake emails. Alternately, you could remove this image. The doc is clear and understandable without it, and images create a maintenance burden.

@github-actions github-actions bot removed the Images Images are added/removed with this PR label Jan 24, 2025
@sysy6r sysy6r requested a review from urseberry January 28, 2025 11:25
@urseberry
Copy link
Contributor

Sylvain wants this merged Thursday February 6.

@sysy6r
Copy link
Contributor Author

sysy6r commented Feb 6, 2025

cc @urseberry I just re-ordered the list of resources in the table (last commit) as I noticed they are supposed to be in alphabetical order. Also, feel free to merge, everything is ready on our side 🚀

@urseberry urseberry removed the Do Not Merge Just do not merge this PR :) label Feb 6, 2025
@urseberry
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-06 22:05:20 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-02-06 22:11:07 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3e0fda6 into master Feb 6, 2025
15 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sylvain.cizaire/add-granular-project-rbac branch February 6, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants