Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify expected agentless costs #27350

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Clarify expected agentless costs #27350

merged 7 commits into from
Feb 7, 2025

Conversation

aviat
Copy link
Contributor

@aviat aviat commented Jan 28, 2025 •
edited
Loading

What does this PR do? What is the motivation?

Better explain cost to users. Describe auto scaling.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@aviat aviat added the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 28, 2025
@aviat aviat requested a review from a team as a code owner January 28, 2025 19:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@aviat aviat force-pushed the jeanbaptiste.aviat/al-costs branch from 6ee5ca8 to edb6720 Compare January 28, 2025 21:17
@aviat aviat changed the title Agentless: better describe costs & auto scaling Agentless: better describe costs Jan 28, 2025
@aviat aviat changed the title Agentless: better describe costs Clarify expected agentless costs Jan 28, 2025
@aviat aviat removed the WORK IN PROGRESS No review needed, it's a wip ;) label Feb 6, 2025
@aviat aviat requested a review from cyrbouchiat February 6, 2025 19:36
@aviat
Copy link
Contributor Author

aviat commented Feb 6, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 6, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-02-06 19:37:15 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-06 23:38:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

estherk15
estherk15 reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, let me know if you have any questions!

aviat and others added 4 commits February 7, 2025 11:14
@aviat @estherk15
Move section around
87f800e 
Co-authored-by: Esther Kim <[email protected]>
@aviat @estherk15
Move section around
5df19b1 
Co-authored-by: Esther Kim <[email protected]>
@aviat @estherk15
Reword bullets
3c07560 
Co-authored-by: Esther Kim <[email protected]>
@aviat
Add link
a7972e8
@aviat aviat requested a review from estherk15 February 7, 2025 16:20
@aviat
Copy link
Contributor Author

aviat commented Feb 7, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 7, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-02-07 20:14:27 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.

2025-02-07 20:20:16 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 597a17b into master Feb 7, 2025
18 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jeanbaptiste.aviat/al-costs branch February 7, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherk15 estherk15 estherk15 approved these changes

@cyrbouchiat cyrbouchiat cyrbouchiat approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviat @estherk15 @cyrbouchiat