Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Automatic multi-line aggregation part in Advanced Log Collection Configurations #27361

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

daenypark
Copy link

@daenypark daenypark commented Jan 29, 2025

What does this PR do? What is the motivation?

There are tons of customers asking how to add auto multi-line options in docker and kubernetes. The current content for docker and kubernetes is confusing because it mentioned to add options in datadog.yaml while docker and kubernetes need another approach.

Automatic multi-line detection uses a list of common regular expressions to attempt to match logs. If the built-in list is not sufficient, you can also add custom patterns in the datadog.yaml file with the DD_LOGS_CONFIG_AUTO_MULTI_LINE_EXTRA_PATTERNS environment variable.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

I checked updated configuration with my Sandbox and confirmed it worked.

@daenypark daenypark requested review from a team as code owners January 29, 2025 14:34
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@daenypark daenypark changed the title [WIP] Update Automatic multi-line aggregation part in Advanced Log Collection Configurations Update Automatic multi-line aggregation part in Advanced Log Collection Configurations Jan 29, 2025
Copy link
Contributor

@JacksonDavenport JacksonDavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small recommendations, additionally were those go.mod & go.sum files accidentally committed? Would be good to revert those changes.

content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
@daenypark daenypark removed the request for review from a team January 29, 2025 19:20
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
content/en/agent/logs/advanced_log_collection.md Outdated Show resolved Hide resolved
daenypark and others added 3 commits January 29, 2025 18:23
Apply feedback from document team.

Co-authored-by: Ursula Chen <[email protected]>
Fixed some box format "```" and re-arrange extra pattern note.
@daenypark daenypark requested a review from urseberry January 30, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants