Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DOCS-9900) Update Terraform template #27389

Merged
merged 5 commits into from
Feb 13, 2025
Merged

(DOCS-9900) Update Terraform template #27389

merged 5 commits into from
Feb 13, 2025

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented Jan 30, 2025 •
edited
Loading

What does this PR do? What is the motivation?

  • Update the doc with a new Terraform resource
  • Add a new site-region for gov

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@buraizu buraizu added the WORK IN PROGRESS No review needed, it's a wip ;) label Jan 30, 2025
@buraizu buraizu requested a review from a team as a code owner January 30, 2025 23:34
@github-actions github-actions bot added the Guide Content impacting a guide label Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

ktmq
ktmq approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@ktmq ktmq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one nit!

@buraizu buraizu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Feb 13, 2025
rtrieu
rtrieu approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the unresolved comment, this looks good!

@buraizu
Copy link
Contributor Author

buraizu commented Feb 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-13 19:36:32 UTC ℹ️ Start processing command /merge

2025-02-13 19:36:36 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.

2025-02-13 19:43:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3dc662c into master Feb 13, 2025
18 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the docs9900/aws-terraform-update branch February 13, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktmq ktmq ktmq approved these changes

@rtrieu rtrieu rtrieu approved these changes

Assignees
No one assigned
Labels
Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buraizu @ktmq @rtrieu