-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiling .NET] Update the .NET profiling doc to support Single Step APM Instrumentation #27414
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just some general questions/suggestions, thanks!
Hi team, just adding the |
@buraizu: It should be fine to merge now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, requesting some updates per the style guide and for clarity
|
||
1. Open the `dotnet-native-loader-dotnet-<pid>` log file in the `/var/log/datadog` folder. | ||
|
||
2. Look for `CorProfiler::Initialize: Continuous Profiler initialized successfully.` near the end. If that message is not present, enable debug logs by setting the `DD_TRACE_DEBUG` environment variable for the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. Look for `CorProfiler::Initialize: Continuous Profiler initialized successfully.` near the end. If that message is not present, enable debug logs by setting the `DD_TRACE_DEBUG` environment variable for the application. | |
2. Look for `CorProfiler::Initialize: Continuous Profiler initialized successfully` near the end. If that message is not present, enable debug logs by setting the `DD_TRACE_DEBUG` environment variable for the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a string that appears in the log file so I would not remove the .
- `Profiler signal handler was replaced again. It will not be restored: the profiler is disabled.` | ||
- `Fail to restore profiler signal handler.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `Profiler signal handler was replaced again. It will not be restored: the profiler is disabled.` | |
- `Fail to restore profiler signal handler.` | |
- `Profiler signal handler was replaced again. It will not be restored: the profiler is disabled` | |
- `Fail to restore profiler signal handler` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these strings appear as is in the log file, the . should not be removed.
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
/merge |
Devflow running:
|
What does this PR do? What is the motivation?
We faced customer cases where the profiling documentation could be misleading when APM is deployed with Single Step Instrumentation. So, the enabling and troubleshooting parts of the .NET profiling documentation are updated to be more explicit.
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes