Skip to content

Update manual_instrumentation.md adding .Net entry#27424

Merged
dd-mergequeue[bot] merged 22 commits into
masterfrom
steven.pham/dotnet-entry-manual-instrumentation
Feb 7, 2025
Merged

Update manual_instrumentation.md adding .Net entry#27424
dd-mergequeue[bot] merged 22 commits into
masterfrom
steven.pham/dotnet-entry-manual-instrumentation

Conversation

@gitstevenpham

@gitstevenpham gitstevenpham commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

Adds .Net entry based on https://dd.slack.com/archives/C05C61J554L/p1738011042428139

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@gitstevenpham gitstevenpham requested review from a team as code owners February 3, 2025 18:57
@github-actions

github-actions Bot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@gitstevenpham gitstevenpham force-pushed the steven.pham/dotnet-entry-manual-instrumentation branch from 70ff78c to 6aa7930 Compare February 3, 2025 19:21
remove extra `{{% /tab %}}`

@vandonr vandonr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we want to mention that doing that will also propagate the trace context ?
We could also link to the doc explaining how to trace propagate without DSM, which also has some nice examples of header getter/setter methods for some queues.

I'd even link in the other direction, from that doc linked above to here, like "hey, I see you want to inject trace context, how about injecting DSM at the same time ?"

{{% /tab %}}
{{% tab ".Net" %}}
<div class="alert alert-warning">
<strong>Note:</strong> DSM instrumentation does not work in Async operations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this wording is not too strong... It will work, it's just that context is broken/lost on a send following a receive. I don't know how to convey that in a clear way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does:

Note: In async operations, this may not work as expected because the context derived from the incoming message can be lost when producing a new message in different threads.

Sound?

Comment thread content/en/data_streams/manual_instrumentation.md Outdated
Comment thread content/en/data_streams/manual_instrumentation.md Outdated
gitstevenpham and others added 4 commits February 3, 2025 15:45
@gitstevenpham

gitstevenpham commented Feb 3, 2025

Copy link
Copy Markdown
Contributor Author

maybe we want to mention that doing that will also propagate the trace context ? We could also link to the doc explaining how to trace propagate without DSM, which also has some nice examples of header getter/setter methods for some queues.

I'd even link in the other direction, from that doc linked above to here, like "hey, I see you want to inject trace context, how about injecting DSM at the same time ?"

Added "The following example propogates the trace context. See Trace Context Propagation on how this is done in general."

@buraizu buraizu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some minor edits

Comment thread content/en/data_streams/manual_instrumentation.md Outdated
Comment thread content/en/data_streams/manual_instrumentation.md Outdated
Comment thread content/en/data_streams/manual_instrumentation.md Outdated
Comment thread content/en/data_streams/manual_instrumentation.md Outdated
Comment thread content/en/data_streams/manual_instrumentation.md Outdated
Comment thread content/en/data_streams/manual_instrumentation.md Outdated
gitstevenpham and others added 10 commits February 4, 2025 09:34
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@gitstevenpham

Copy link
Copy Markdown
Contributor Author

@buraizu can you help with the linking. I can't seem to get it to work

@johannbotha johannbotha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitstevenpham

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow

dd-devflow Bot commented Feb 7, 2025

Copy link
Copy Markdown

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-02-07 15:56:48 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-02-07 16:04:54 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants