-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update manual_instrumentation.md adding .Net entry #27424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manual_instrumentation.md adding .Net entry #27424
Conversation
Preview links (active after the
|
70ff78c
to
6aa7930
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we want to mention that doing that will also propagate the trace context ?
We could also link to the doc explaining how to trace propagate without DSM, which also has some nice examples of header getter/setter methods for some queues.
I'd even link in the other direction, from that doc linked above to here, like "hey, I see you want to inject trace context, how about injecting DSM at the same time ?"
{{% /tab %}} | ||
{{% tab ".Net" %}} | ||
<div class="alert alert-warning"> | ||
<strong>Note:</strong> DSM instrumentation does not work in Async operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this wording is not too strong... It will work, it's just that context is broken/lost on a send
following a receive
. I don't know how to convey that in a clear way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does:
Note: In async operations, this may not work as expected because the context derived from the incoming message can be lost when producing a new message in different threads.
Sound?
Co-authored-by: Raphaël Vandon <[email protected]>
Co-authored-by: Raphaël Vandon <[email protected]>
Added "The following example propogates the trace context. See Trace Context Propagation on how this is done in general." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some minor edits
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
@buraizu can you help with the linking. I can't seem to get it to work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Devflow running:
|
What does this PR do? What is the motivation?
Adds
.Net
entry based on https://dd.slack.com/archives/C05C61J554L/p1738011042428139Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes