Update manual_instrumentation.md adding .Net entry#27424
Conversation
Preview links (active after the
|
70ff78c to
6aa7930
Compare
vandonr
left a comment
There was a problem hiding this comment.
maybe we want to mention that doing that will also propagate the trace context ?
We could also link to the doc explaining how to trace propagate without DSM, which also has some nice examples of header getter/setter methods for some queues.
I'd even link in the other direction, from that doc linked above to here, like "hey, I see you want to inject trace context, how about injecting DSM at the same time ?"
| {{% /tab %}} | ||
| {{% tab ".Net" %}} | ||
| <div class="alert alert-warning"> | ||
| <strong>Note:</strong> DSM instrumentation does not work in Async operations |
There was a problem hiding this comment.
I wonder if this wording is not too strong... It will work, it's just that context is broken/lost on a send following a receive. I don't know how to convey that in a clear way.
There was a problem hiding this comment.
How does:
Note: In async operations, this may not work as expected because the context derived from the incoming message can be lost when producing a new message in different threads.
Sound?
Co-authored-by: Raphaël Vandon <raphael.vandon@datadoghq.com>
Co-authored-by: Raphaël Vandon <raphael.vandon@datadoghq.com>
Added "The following example propogates the trace context. See Trace Context Propagation on how this is done in general." |
buraizu
left a comment
There was a problem hiding this comment.
Requesting some minor edits
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
|
@buraizu can you help with the linking. I can't seem to get it to work |
|
/merge |
Devflow running:
|
What does this PR do? What is the motivation?
Adds
.Netentry based on https://dd.slack.com/archives/C05C61J554L/p1738011042428139Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes